* [PATCH] Unify DW_TAG_typedef case in new_symbol
@ 2023-08-30 21:33 Tom Tromey
2023-08-31 8:06 ` Guinevere Larsen
0 siblings, 1 reply; 3+ messages in thread
From: Tom Tromey @ 2023-08-30 21:33 UTC (permalink / raw)
To: gdb-patches; +Cc: Tom Tromey
This patch merges the DW_TAG_typedef case in new_symbol with some
other type-related cases. These all have identical code.
---
gdb/dwarf2/read.c | 6 +-----
1 file changed, 1 insertion(+), 5 deletions(-)
diff --git a/gdb/dwarf2/read.c b/gdb/dwarf2/read.c
index 5b32089094d..aa3d821552a 100644
--- a/gdb/dwarf2/read.c
+++ b/gdb/dwarf2/read.c
@@ -19376,15 +19376,11 @@ new_symbol (struct die_info *die, struct type *type, struct dwarf2_cu *cu,
}
}
break;
- case DW_TAG_typedef:
- sym->set_aclass_index (LOC_TYPEDEF);
- sym->set_domain (VAR_DOMAIN);
- list_to_add = cu->list_in_scope;
- break;
case DW_TAG_unspecified_type:
if (cu->lang () == language_ada)
break;
/* FALLTHROUGH */
+ case DW_TAG_typedef:
case DW_TAG_array_type:
case DW_TAG_base_type:
case DW_TAG_subrange_type:
--
2.41.0
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] Unify DW_TAG_typedef case in new_symbol
2023-08-30 21:33 [PATCH] Unify DW_TAG_typedef case in new_symbol Tom Tromey
@ 2023-08-31 8:06 ` Guinevere Larsen
2023-08-31 13:40 ` Tom Tromey
0 siblings, 1 reply; 3+ messages in thread
From: Guinevere Larsen @ 2023-08-31 8:06 UTC (permalink / raw)
To: Tom Tromey, gdb-patches
On 30/08/2023 23:33, Tom Tromey wrote:
> This patch merges the DW_TAG_typedef case in new_symbol with some
> other type-related cases. These all have identical code.
> ---
> gdb/dwarf2/read.c | 6 +-----
> 1 file changed, 1 insertion(+), 5 deletions(-)
>
> diff --git a/gdb/dwarf2/read.c b/gdb/dwarf2/read.c
> index 5b32089094d..aa3d821552a 100644
> --- a/gdb/dwarf2/read.c
> +++ b/gdb/dwarf2/read.c
> @@ -19376,15 +19376,11 @@ new_symbol (struct die_info *die, struct type *type, struct dwarf2_cu *cu,
> }
> }
> break;
> - case DW_TAG_typedef:
> - sym->set_aclass_index (LOC_TYPEDEF);
> - sym->set_domain (VAR_DOMAIN);
> - list_to_add = cu->list_in_scope;
> - break;
> case DW_TAG_unspecified_type:
> if (cu->lang () == language_ada)
> break;
> /* FALLTHROUGH */
> + case DW_TAG_typedef:
> case DW_TAG_array_type:
> case DW_TAG_base_type:
> case DW_TAG_subrange_type:
Nice reduction of complexity!
Reviewed-By: Guinevere Larsen <blarsen@redhat.com>
Hope some maintainer approves this soon!
--
Cheers,
Guinevere Larsen
She/Her/Hers
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] Unify DW_TAG_typedef case in new_symbol
2023-08-31 8:06 ` Guinevere Larsen
@ 2023-08-31 13:40 ` Tom Tromey
0 siblings, 0 replies; 3+ messages in thread
From: Tom Tromey @ 2023-08-31 13:40 UTC (permalink / raw)
To: Guinevere Larsen; +Cc: Tom Tromey, gdb-patches
>>>>> "Guinevere" == Guinevere Larsen <blarsen@redhat.com> writes:
Guinevere> Nice reduction of complexity!
Guinevere> Reviewed-By: Guinevere Larsen <blarsen@redhat.com>
Guinevere> Hope some maintainer approves this soon!
Thanks. Your review is enough for me, I'm going to check it in.
Tom
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-08-31 13:40 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-08-30 21:33 [PATCH] Unify DW_TAG_typedef case in new_symbol Tom Tromey
2023-08-31 8:06 ` Guinevere Larsen
2023-08-31 13:40 ` Tom Tromey
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).