From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-io1-xd35.google.com (mail-io1-xd35.google.com [IPv6:2607:f8b0:4864:20::d35]) by sourceware.org (Postfix) with ESMTPS id 432393858D28 for ; Mon, 28 Aug 2023 19:06:40 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 432393858D28 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=adacore.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=adacore.com Received: by mail-io1-xd35.google.com with SMTP id ca18e2360f4ac-794e0e8b588so35689239f.1 for ; Mon, 28 Aug 2023 12:06:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=adacore.com; s=google; t=1693249599; x=1693854399; h=mime-version:user-agent:message-id:in-reply-to:date:references :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=xHmkn8IHtfjg/I5bkFn9bZ7GaBMVPSMgQNVjZ0dcixk=; b=F4Q/9dlM/Ry1rg3DDvhm7CcEi/D/WlIkv6gs/1HEyWnxB6Rx3pHE0PbX+IyH2dW6V3 /GnV/agLZwaXd2dWL+lIV2AnRhlyw2/T4m+OUWIbWFb2lz99Nk0cPM3SHqa7/gVGY6l+ iOHSCNfp8eYQgyHBxMqFGSriV0u9NLznR5/L4PghoZaKB8mHowBHxIcMalrRCEpGB2wq V+qha1FftyraWRXcB1hRfI4Y7q9JeLjiHrFlVNbm8ZnXNXSrSG323M3O1aHE9MEUs3Ot 5+WMpr5dt2lpJ/Rp+wLI5+yCZzgNaeiRxSFDLMr91ywmEF/688Su3PWirPxmIeMISPcV ScOg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1693249599; x=1693854399; h=mime-version:user-agent:message-id:in-reply-to:date:references :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=xHmkn8IHtfjg/I5bkFn9bZ7GaBMVPSMgQNVjZ0dcixk=; b=AVEedwfIue1ThD6ywmB8BgUDtuzxcp5gRkWCaKsTJWe2maYa6FeRpao0IVxjysLkZs fn9HPCPSLkOCarFOaBurN0zFW23UaSXExFNyfkZJ1j/bBaOGJPsR/u1BUTnGnu2K1MJO +lVWIpURZ1dICOsEN7lM4wfevZe65hALLhdjE5URHr05x55fEzD7QRd9Lb1ZYrgfzxBT nstHCT7AJcIEG/ffcPsY9i9NJPV9vQixuo0SFxA2bh9tvn/4UT/VdpOrPI31Ah1cS/Qr M0s2R6qVpXbpmRlPCwzmVxZurMvqPd4pLRjAXc4ei2QI9nyvThc1CEouPhUOq3hxNEJn qnbg== X-Gm-Message-State: AOJu0Yw8NEQRgL+ZjsLRFofnpgXsQxhX5PMBBU7pokZ86mJPRg2pXdRn JZuwnCR4MjNe96SZdyxRpE93TsY2U6CGXSU5/ORHXg== X-Google-Smtp-Source: AGHT+IFhAcV8Ywe7ihDpk+69SSAqgWM3NxgnbP6Rr3zwEaZcA6p1q9GBWkhzmYPKxEr6jl9Pw+C7rA== X-Received: by 2002:a6b:6a12:0:b0:790:9f0c:3069 with SMTP id x18-20020a6b6a12000000b007909f0c3069mr17453008iog.9.1693249599426; Mon, 28 Aug 2023 12:06:39 -0700 (PDT) Received: from murgatroyd (75-166-150-212.hlrn.qwest.net. [75.166.150.212]) by smtp.gmail.com with ESMTPSA id n26-20020a02a91a000000b004165ac64e0asm2710216jam.40.2023.08.28.12.06.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 28 Aug 2023 12:06:38 -0700 (PDT) From: Tom Tromey To: John Baldwin Cc: Tom Tromey , gdb-patches@sourceware.org Subject: Re: [PATCH 0/4] Unify getpkt methods in remote.c References: <20230828-getpkt-cleanup-v1-0-0f3da220530c@adacore.com> <0451edf2-c709-9e97-5145-1b07653cda9b@FreeBSD.org> X-Attribution: Tom Date: Mon, 28 Aug 2023 13:06:38 -0600 In-Reply-To: <0451edf2-c709-9e97-5145-1b07653cda9b@FreeBSD.org> (John Baldwin's message of "Mon, 28 Aug 2023 10:51:53 -0700") Message-ID: <874jkjt29t.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Status: No, score=-5.2 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: >>>>> "John" == John Baldwin writes: John> int getpkt_1 (gdb::char_vector *buf, bool forever, bool *is_notif); John> int getpkt (gdb::char_vector *buf, bool *is_notif = nullptr) John> { return getpkt_1 (buf, false, is_notif); } John> int getpkt_wait (gdb::char_vector *buf, bool *is_notif = nullptr) John> { return getpkt_1 (buf, true, is_notif); } John> Maybe you could get by with defaulting both arguments to getpkt and John> not needing getpkt_1 at all, just having getpkt_wait() as wrapper? Yeah, unless the full API is unwieldy, I tend to prefer default arguments. I can tack on a patch to add this for the 'forever' argument. Tom