From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-io1-xd29.google.com (mail-io1-xd29.google.com [IPv6:2607:f8b0:4864:20::d29]) by sourceware.org (Postfix) with ESMTPS id 572A53858C20 for ; Mon, 14 Aug 2023 15:38:31 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 572A53858C20 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=adacore.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=adacore.com Received: by mail-io1-xd29.google.com with SMTP id ca18e2360f4ac-79093c0c68bso175166439f.0 for ; Mon, 14 Aug 2023 08:38:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=adacore.com; s=google; t=1692027510; x=1692632310; h=mime-version:user-agent:message-id:in-reply-to:date:references :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=6kq89QNE6mdJNq0yusu5ZgadrbBv99RU3tK2N/Z8vZM=; b=R1ai4uqPX096QqFOHEZjoWH7uyXk3HUqcSL3uEGk0NAKOz7TGu5rKoU9PWBNJj3IuT Hib7ex1UoICkSCzk0e7vbEjT+rGl6ERuBRKaipkgs8paK9RnWU80nT0KDvPzHXvIkago 5Ltof3jp2gmbVCLJakVCo7IvPIbTI6Bv3uOIxQ9nM+yMbr0PGmpaIlwag3vKYd5mmqUO omM5NtMCEiKTveieZjacKlYLTS5PQHZXWgiEf3FxvaHGCfn6eprAyw2pH0tMQW7375W5 1unIqgMG6FXKfsPC4qrj0aOuYLUZu10L0BUdwAUbIk0QkvdKkYYMBOhXcGPNWQizwOGl cqVg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1692027510; x=1692632310; h=mime-version:user-agent:message-id:in-reply-to:date:references :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=6kq89QNE6mdJNq0yusu5ZgadrbBv99RU3tK2N/Z8vZM=; b=Lr/KWtNVH5X869obgMsYuNtQQ7X0PPGQ/Zb2ryGHRbJi2bOTdPc/Be22oaLLdGnwDI 6w3KEwMWJffFIJNWb8lb+hAbu2d56cT6sram31zLRVLXaMhER8romdWpktZrMNZok7EP cnw4mC+lYW3iFpuwmFzKeESl4XAked71JxSwtnwiUUDY17gZx9/bEOLXy6D41I4SQycp sv+Gsc9sf1YHE8F1sELCdjy+/YgpjToMUuJIcoIjJ9WUIBqclJhMFCL+zlC2puMSi7Kr hrzX/uzUfO2mG0xP8YAfJLydd35/jCegmJaS6pXMPRHpc/CswrRiUL9JmI3zY1yTeGHy qiZw== X-Gm-Message-State: AOJu0YyIUpZQHtrmKXKFjVyoV4/WJlFCob9Dd7xv4odOCK++FHmzTiRg ki4y9ne0cH+wSXMkd7G0Twia6g== X-Google-Smtp-Source: AGHT+IEMaDxMQyjpS2I0l5TTcVNcTVnEOoD0aI1F/W3GrILsHGBRBCLGzbCkZINDOmePU75m2lFt5Q== X-Received: by 2002:a05:6602:686:b0:787:1d0a:ce87 with SMTP id dp6-20020a056602068600b007871d0ace87mr12481452iob.17.1692027510615; Mon, 14 Aug 2023 08:38:30 -0700 (PDT) Received: from murgatroyd (75-166-142-177.hlrn.qwest.net. [75.166.142.177]) by smtp.gmail.com with ESMTPSA id fn3-20020a056638640300b0042baf73ebfesm3052458jab.6.2023.08.14.08.38.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 14 Aug 2023 08:38:30 -0700 (PDT) From: Tom Tromey To: Andrew Burgess Cc: gdb-patches@sourceware.org, Tom Tromey Subject: Re: [PATCH 1/3] gdb: add gdb::make_unique function References: X-Attribution: Tom Date: Mon, 14 Aug 2023 09:38:29 -0600 In-Reply-To: (Andrew Burgess's message of "Mon, 14 Aug 2023 14:42:32 +0100") Message-ID: <874jl11vnu.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Status: No, score=-4.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: >>>>> "Andrew" == Andrew Burgess writes: Andrew> While GDB is still C++11, lets add a gdb::make_unique template Andrew> function that can be used to create std::unique_ptr objects, just like Andrew> the C++14 std::make_unique. Andrew> When we move to C++14 we can either alias gdb::make_unique to Andrew> std::make_unique, or just replace the 'gdb::' prefix throughout. This looks totally fine to me, but I wonder if this is a situation where we'd want to use the standard make_unique when it is available, like we do for some other things. Tom