From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from alt-proxy28.mail.unifiedlayer.com (alt-proxy28.mail.unifiedlayer.com [74.220.216.123]) by sourceware.org (Postfix) with ESMTPS id A3B2A3858D1E for ; Thu, 13 Jul 2023 16:53:21 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org A3B2A3858D1E Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey.com Received: from cmgw14.mail.unifiedlayer.com (unknown [10.0.90.129]) by progateway1.mail.pro1.eigbox.com (Postfix) with ESMTP id D239410038961 for ; Thu, 13 Jul 2023 16:53:20 +0000 (UTC) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with ESMTP id JzZAqEBh4BAs0JzZAq07ah; Thu, 13 Jul 2023 16:53:20 +0000 X-Authority-Reason: nr=8 X-Authority-Analysis: v=2.4 cv=DJxKXwBb c=1 sm=1 tr=0 ts=64b02c00 a=ApxJNpeYhEAb1aAlGBBbmA==:117 a=ApxJNpeYhEAb1aAlGBBbmA==:17 a=OWjo9vPv0XrRhIrVQ50Ab3nP57M=:19 a=dLZJa+xiwSxG16/P+YVxDGlgEgI=:19 a=ws7JD89P4LkA:10:nop_rcvd_month_year a=Qbun_eYptAEA:10:endurance_base64_authed_username_1 a=CCpqsmhAAAAA:8 a=zstS-IiYAAAA:8 a=OLk89X7XaS-hdAx4KnAA:9 a=ul9cdbp4aOFLsgKbc677:22 a=4G6NA9xxw8l3yy4pmD5M:22 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date:References :Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=It+tsBgkted2P094CIL1x53cwEdwv5L3WPD7JIG782I=; b=v2Jmbh+oyw1mU5O8yjNr4OUEUY BtAximKNgR20MkCz3r91xgGh7uesBAlKsjV4tzy7zquHQu3OVGwL4NPogIvFNo1ubOPMO93yjZbw7 0wIrZe/v11i3Lr9wOTOUaA2R2; Received: from 75-166-135-140.hlrn.qwest.net ([75.166.135.140]:40710 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1qJzZA-003xOh-1g; Thu, 13 Jul 2023 10:53:20 -0600 From: Tom Tromey To: Bruno Larsen via Gdb-patches Cc: Bruno Larsen Subject: Re: [PATCH v4 2/4] gdb/cli: add '.' as an argument for 'list' command References: <20230713102411.2279542-1-blarsen@redhat.com> <20230713102411.2279542-3-blarsen@redhat.com> X-Attribution: Tom Date: Thu, 13 Jul 2023 10:53:19 -0600 In-Reply-To: <20230713102411.2279542-3-blarsen@redhat.com> (Bruno Larsen via Gdb-patches's message of "Thu, 13 Jul 2023 12:24:09 +0200") Message-ID: <874jm7pxc0.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 75.166.135.140 X-Source-L: No X-Exim-ID: 1qJzZA-003xOh-1g X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 75-166-135-140.hlrn.qwest.net (murgatroyd) [75.166.135.140]:40710 X-Source-Auth: tom+tromey.com X-Email-Count: 10 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-Spam-Status: No, score=-3019.3 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,JMQ_SPF_NEUTRAL,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: >>>>> "Bruno" == Bruno Larsen via Gdb-patches writes: Bruno> Because this necessitated having the inferior running and the test was Bruno> (seemingly unnecessarily) using printf in a non-essential way and it Bruno> would make the resulting log harder to read for no benefit, it was Bruno> replaced by a differen t statement. Extra space in there. Normally I wouldn't point it out but I had one other small nit. Bruno> + try Bruno> + { Bruno> + /* Find the current line by getting the PC of the currently Bruno> + selected frame, and finding the line associated to it. */ Bruno> + frame_info_ptr frame = get_selected_frame (nullptr); Bruno> + CORE_ADDR curr_pc = get_frame_pc (frame); Bruno> + cursal = find_pc_line (curr_pc, 0); Bruno> + } Bruno> + catch (const gdb_exception &e) Bruno> + { Bruno> + /* If there was an exception above, it means the inferior Bruno> + is not running, so reset the current source location to Bruno> + the default. */ Bruno> + clear_current_source_symtab_and_line (); Bruno> + set_default_source_symtab_and_line (); Bruno> + cursal = get_current_source_symtab_and_line (); The indentation in the 'catch' part looks off. This is ok with these nits fixed, no need to re-send. Approved-By: Tom Tromey Tom