From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id 1D3253858CDB for ; Thu, 18 May 2023 15:54:42 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 1D3253858CDB Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1684425281; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=NU4loqsOlg2/v1L+hY19Oc2BV8u3FXlfZjP9Zm3USLc=; b=L5T9E066ubBCMyxTskrP0jyT1cePCNvYCb8mcBfyn3dqBGqhkvcsXKRIcs6bPpf0RlpH4Z FYGA/7FmyKzE38PwV6hYyFUDhw6mznm3KxjN32GpEBNCJpXDNqS/XIsONemc6icjqeTfrj 1eWpG3+JV0mj8qoV9gIXpNeyGZcOJG0= Received: from mail-wr1-f72.google.com (mail-wr1-f72.google.com [209.85.221.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-473-42vtT4jtNdy-IykNilWZ8A-1; Thu, 18 May 2023 11:54:40 -0400 X-MC-Unique: 42vtT4jtNdy-IykNilWZ8A-1 Received: by mail-wr1-f72.google.com with SMTP id ffacd0b85a97d-3094e661decso250807f8f.2 for ; Thu, 18 May 2023 08:54:40 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1684425279; x=1687017279; h=mime-version:message-id:date:references:in-reply-to:subject:cc:to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=NU4loqsOlg2/v1L+hY19Oc2BV8u3FXlfZjP9Zm3USLc=; b=EjZWrQdoGAOpJZppLcADX1tqVZ99j4LHlnWvtQMmsosIrT9lobREvUXNhLP29bSkji FWDsmyvDZ1y5nP9rgtS4E+w7DOwQSikYs5gTY7HZGahxOp0gjS3naNL86Lz1oSrQwwRr 0UUWyKSiqQZpSt/MKrsLyvj5byNxxSA2X3dMbEWObhC84WPwkz1mlUKDaMJFTtiJntT6 qGA5p1ZY4/17ZEs3ND4KNBTJ0FaQKjbtR2KNrWpRohEtWzQnHu9fG9RVkOSPy50Prwgq z3EyxGqdqaRkRcHwcQtRUf+IwcbEr35lgo8IAYOxPBhHXsgWCBuKXIKzIGanb79yNxTP X0Lw== X-Gm-Message-State: AC+VfDyvXadGfg6axDC0BVTiWbxdaymcUFRlnc+yopeGqDtVM8uQv5rC UOXLQ4xg639vB1cBXelZeA2eT+4erXZlDX1iim5jAuR1xvUiamYaxzl7v/snCfGPAqSkxv7dJi1 p1SKJWdpOHzNISD+0/2BZFEeNj90kXj+mcfJaSvwbK7ajUbdLUS6/LZgaAcLhfpkLRve3tTToP7 K7oh41Yg== X-Received: by 2002:a5d:574b:0:b0:309:32e5:b47a with SMTP id q11-20020a5d574b000000b0030932e5b47amr1746541wrw.63.1684425279237; Thu, 18 May 2023 08:54:39 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ7DTq11n7/9qag3Y4hbkwAHqCf31k2RV8efQByMABPPrJmGFjrdNapLQnroMumUbDa0Hyq0LQ== X-Received: by 2002:a5d:574b:0:b0:309:32e5:b47a with SMTP id q11-20020a5d574b000000b0030932e5b47amr1746508wrw.63.1684425278714; Thu, 18 May 2023 08:54:38 -0700 (PDT) Received: from localhost (11.72.115.87.dyn.plus.net. [87.115.72.11]) by smtp.gmail.com with ESMTPSA id b8-20020a5d4d88000000b003062c609115sm2601727wru.21.2023.05.18.08.54.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 18 May 2023 08:54:38 -0700 (PDT) From: Andrew Burgess To: Simon Marchi via Gdb-patches , gdb-patches@sourceware.org Cc: Simon Marchi Subject: Re: [PATCH 00/12] Use intrusive_list for breakpoints and breakpoint locations In-Reply-To: <20230511144832.17974-1-simon.marchi@efficios.com> References: <20230511144832.17974-1-simon.marchi@efficios.com> Date: Thu, 18 May 2023 16:54:37 +0100 Message-ID: <874jo9ab42.fsf@redhat.com> MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain X-Spam-Status: No, score=-5.7 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_NONE,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Simon Marchi via Gdb-patches writes: > This series changes two linked lists to use intrusive_list. There are > some cleanups before that, and some small fixes that needed to be made > to some of our iterator wrappers. I took a look through and left a few comments, but otherwise, this looks great. I also ran the testsuite locally, and saw no regressions. Reviewed-By: Andrew Burgess Thanks, Andrew > > Simon Marchi (12): > gdb: get gdbarch from syscall_catchpoint instead of location > gdb: make some breakpoint methods use `this` > gdb: constify breakpoint::print_it parameter > gdb: add breakpoint "has locations" methods > gdb: add breakpoint::first_loc methods > gdbsupport: add missing increment/decrement operators to > reference_to_pointer_iterator > gdb: link breakpoint locations with intrusive_list > gdb: remove bp_location_pointer_iterator > gdb: link breakpoints with intrusive_list > gdbsupport: make basic_safe_iterator::operator* return the same thing > as underlying iterator > gdbsupport: make filtered_iterator::operator* return the same thing as > underlying iterator > gdb: remove breakpoint_pointer_iterator > > gdb/ada-lang.c | 20 +- > gdb/break-catch-exec.c | 4 +- > gdb/break-catch-fork.c | 4 +- > gdb/break-catch-load.c | 25 +- > gdb/break-catch-sig.c | 4 +- > gdb/break-catch-syscall.c | 21 +- > gdb/break-catch-throw.c | 10 +- > gdb/breakpoint.c | 1225 ++++++++++---------- > gdb/breakpoint.h | 104 +- > gdb/dummy-frame.c | 4 +- > gdb/elfread.c | 8 +- > gdb/guile/scm-breakpoint.c | 4 +- > gdb/infrun.c | 11 +- > gdb/jit.c | 6 +- > gdb/python/py-breakpoint.c | 8 +- > gdb/python/py-finishbreakpoint.c | 8 +- > gdb/remote.c | 4 +- > gdb/solib-svr4.c | 10 +- > gdb/tracectf.c | 4 +- > gdb/tracefile-tfile.c | 4 +- > gdb/tracefile.c | 6 +- > gdb/tracepoint.c | 108 +- > gdb/tui/tui-winsource.c | 16 +- > gdbsupport/filtered-iterator.h | 7 +- > gdbsupport/reference-to-pointer-iterator.h | 18 + > gdbsupport/safe-iterator.h | 6 +- > 26 files changed, 848 insertions(+), 801 deletions(-) > > -- > 2.40.1