From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gproxy4-pub.mail.unifiedlayer.com (gproxy4-pub.mail.unifiedlayer.com [69.89.23.142]) by sourceware.org (Postfix) with ESMTPS id C4B423858D20 for ; Wed, 10 May 2023 16:29:19 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org C4B423858D20 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey.com Received: from cmgw12.mail.unifiedlayer.com (unknown [10.0.90.127]) by progateway6.mail.pro1.eigbox.com (Postfix) with ESMTP id 0922610042E20 for ; Wed, 10 May 2023 16:29:19 +0000 (UTC) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with ESMTP id wmgopgC87ZYqfwmgppnDfR; Wed, 10 May 2023 16:29:19 +0000 X-Authority-Reason: nr=8 X-Authority-Analysis: v=2.4 cv=fvEZ2H0f c=1 sm=1 tr=0 ts=645bc65f a=ApxJNpeYhEAb1aAlGBBbmA==:117 a=ApxJNpeYhEAb1aAlGBBbmA==:17 a=dLZJa+xiwSxG16/P+YVxDGlgEgI=:19 a=P0xRbXHiH_UA:10:nop_rcvd_month_year a=Qbun_eYptAEA:10:endurance_base64_authed_username_1 a=CCpqsmhAAAAA:8 a=CpOMGmdn2gH_mMZ8ZWYA:9 a=ul9cdbp4aOFLsgKbc677:22 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date:References :Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=c/XKCE1imzqSCnxmjqmtilf5nQcgV6h1Y0bgkXfm2A0=; b=JpNGr2Pg1jPB0/LHhN4HhXMKlu Iz6JW3BbvY4qlhaCTNYqCT49NCGKLvb4SxKPmZpHde+DLD7qTamf0AlViyUQQUubh7tn9cRucLUOS rBOefr0GEkTkeQ+HBwY6GNJXx; Received: from 71-211-191-82.hlrn.qwest.net ([71.211.191.82]:53206 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1pwmgo-00314j-PH; Wed, 10 May 2023 10:29:18 -0600 From: Tom Tromey To: Tom de Vries via Gdb-patches Cc: Tom de Vries , Tom Tromey Subject: Re: [RFC 3/3] [gdb/dap] Allow WAIT_FOR_EVENTS input References: <20230314130535.6369-1-tdevries@suse.de> <20230314130535.6369-4-tdevries@suse.de> X-Attribution: Tom Date: Wed, 10 May 2023 10:29:18 -0600 In-Reply-To: <20230314130535.6369-4-tdevries@suse.de> (Tom de Vries via Gdb-patches's message of "Tue, 14 Mar 2023 14:05:35 +0100") Message-ID: <874jok5ew1.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 71.211.191.82 X-Source-L: No X-Exim-ID: 1pwmgo-00314j-PH X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 71-211-191-82.hlrn.qwest.net (murgatroyd) [71.211.191.82]:53206 X-Source-Auth: tom+tromey.com X-Email-Count: 3 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-Spam-Status: No, score=-3019.6 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,JMQ_SPF_NEUTRAL,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: >>>>> "Tom" == Tom de Vries via Gdb-patches writes: Tom> Modify the dap input format to allow a WAIT_FOR_EVENTS line: Tom> ... Tom> Content-Length: 54 Tom> WAIT_FOR_EVENTS: 1 Tom> {"seq": 1, "type": "request", "command": "initialize"} Tom> Content-Length: 163 I think the commit message would benefit from an explanation of the rationale. Tom> + if line.startswith(b"WAIT_FOR_EVENTS:") and content_length != None: Tom> + line = line[16:].strip() Tom> + wait_for_events = int(line) Tom> + break A comment here explaining why gdb accepts this header and what it's useful for would also be good. Tom> + while True: Tom> + if wait_for_events <= self.send_event_cnt: Tom> + self.send_event_cnt -= wait_for_events Tom> + break Tom> + time.sleep(1) Can't this be while wait_for_events > self.send_event_cnt: time.sleep(1) Instead of sleep it is probably more efficient to use a queue of some kind and have the event-generation code write to it when the required number of events have been sent. Not sure if we really care in debug mode though. Tom