From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from alt-proxy28.mail.unifiedlayer.com (alt-proxy28.mail.unifiedlayer.com [74.220.216.123]) by sourceware.org (Postfix) with ESMTPS id C32653858C2C for ; Tue, 7 Mar 2023 19:27:58 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org C32653858C2C Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey.com Received: from cmgw10.mail.unifiedlayer.com (unknown [10.0.90.125]) by progateway1.mail.pro1.eigbox.com (Postfix) with ESMTP id 3BD1F1003A113 for ; Tue, 7 Mar 2023 19:27:58 +0000 (UTC) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with ESMTP id Zcycpx27HevcbZcycpNv3E; Tue, 07 Mar 2023 19:27:58 +0000 X-Authority-Reason: nr=8 X-Authority-Analysis: v=2.4 cv=afmkITkt c=1 sm=1 tr=0 ts=6407903e a=ApxJNpeYhEAb1aAlGBBbmA==:117 a=ApxJNpeYhEAb1aAlGBBbmA==:17 a=dLZJa+xiwSxG16/P+YVxDGlgEgI=:19 a=k__wU0fu6RkA:10:nop_rcvd_month_year a=Qbun_eYptAEA:10:endurance_base64_authed_username_1 a=CCpqsmhAAAAA:8 a=Ql7rr9ivDI5JrdY9FyEA:9 a=ul9cdbp4aOFLsgKbc677:22 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date:References :Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=sAcEurXj0AA1H79amQWDlKxQLwfZ0EdzgNpxW235HRw=; b=pUiUQYZPYdIztcFuIu8ihhDlQM fHqG1/ixN7X8lxg0jObtlYKjg3diSdXr+feBhFgV/Ani14yO8NxTl2FKHNBUWPqhxgRQLYk3zHSAt Ssz4RrMCei0UmKK22+Kv5SXHN; Received: from 75-166-130-93.hlrn.qwest.net ([75.166.130.93]:60354 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1pZcyb-000pP8-TW; Tue, 07 Mar 2023 12:27:57 -0700 From: Tom Tromey To: Simon Marchi via Gdb-patches Cc: Simon Marchi Subject: Re: [PATCH 1/3] gdb: make get_interp_info return a reference References: <20230302203224.118345-1-simon.marchi@efficios.com> <20230302203224.118345-2-simon.marchi@efficios.com> X-Attribution: Tom Date: Tue, 07 Mar 2023 12:27:54 -0700 In-Reply-To: <20230302203224.118345-2-simon.marchi@efficios.com> (Simon Marchi via Gdb-patches's message of "Thu, 2 Mar 2023 15:32:22 -0500") Message-ID: <874jqws6o5.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 75.166.130.93 X-Source-L: No X-Exim-ID: 1pZcyb-000pP8-TW X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 75-166-130-93.hlrn.qwest.net (murgatroyd) [75.166.130.93]:60354 X-Source-Auth: tom+tromey.com X-Email-Count: 4 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-Spam-Status: No, score=-3020.6 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,JMQ_SPF_NEUTRAL,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: >>>>> "Simon" == Simon Marchi via Gdb-patches writes: Simon> get_interp_info and get_current_interp_info always return non-nullptr, Simon> so they can return a reference instead of a pointer. Maybe it would be better here if ui_interp_info also disabled copying. Otherwise it seems easy to accidentally drop a "&" and wind up modifying a new copy. Well, that's my first reaction anyway. I'm not sure how much we should really be worried about it. Tom