From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-il1-x129.google.com (mail-il1-x129.google.com [IPv6:2607:f8b0:4864:20::129]) by sourceware.org (Postfix) with ESMTPS id 8CBA63858C20 for ; Mon, 6 Mar 2023 15:17:12 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 8CBA63858C20 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=adacore.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=adacore.com Received: by mail-il1-x129.google.com with SMTP id p13so6487643ilp.11 for ; Mon, 06 Mar 2023 07:17:12 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=adacore.com; s=google; t=1678115831; h=mime-version:user-agent:message-id:in-reply-to:date:references :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=gj7Yft6WsInTuQF+UESaH3VoC/d+J3zvpIJcuMHUSOU=; b=OoKubo+lKF6MGHWvy1NdO30Fyh1ltGU5lt3WVud8cycOqJ9eMX3UilOSNMm6hPusDt dkQABk88nQ+V1NgEKTuPmrrxu8icb00Vj3/yIEItU0aHhzdpUYJANlI3/ZLWayVRlfIG 0cXSNt3eoZ3OMlKEbxoPoyifNK7A62HgnzhvQ1uROfw8DBVW+3lAoVy+F/6hMsIntDAc tleJYxESLFuqN+PyVM2Y3P7q25n3DKYNDnrdjHwJmerXIPo7niT5uRuMuhaF7BYD2Vds xyQecygL2hDSIornXXmFf4ayUvg9hXTiJwjFyPJY+V84tB/odGgRAc+UokyGyKEw3G6D +hRw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1678115831; h=mime-version:user-agent:message-id:in-reply-to:date:references :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=gj7Yft6WsInTuQF+UESaH3VoC/d+J3zvpIJcuMHUSOU=; b=RaGmd+RlSPdwDBKI59xAHVMTGneqxnvl+Ac9h5sRFG8njpBUSQlBNFznDSs0DMdWt2 kYTtTLTgl89JIdy2zjKarzFiyuqfckb+7x4zvhxrbD0r+KNcaIeCnvDpa/lmaF6kzonY MyEUABFks3JLBIe5IwtHaLaDL0wMbD6c3HRQzhrMuNZXVaBFUbiPeZMfHq9Y9qIbGc11 3QO1rmkvqz3eWjfvM60NivmxfN+HF6xC3jq0ql0xSk3yPW/zZ0ElHbDan5/P/PEtS9IE cPY6CjXmSFp42QuBR7vwaYu09375nh+AfPRtUOFT/5QigVQH4ui64fG//598jX2NFs3v jaRw== X-Gm-Message-State: AO0yUKX9WrBhY9/ZRcvQIazVs+zUujK1lXv7h0Ij9TeEyyw30A4AUUIj ek4PFPsJX9jIg2zRzr0gz4qtQxKWukO+nOvFMaw= X-Google-Smtp-Source: AK7set8JzuQcMJEduHFWk7GD4BoBdn34NmT9MqffBUiMAsVGDtKAPi1mX6jHPvcmHQn7eZGKIidz8w== X-Received: by 2002:a05:6e02:1805:b0:316:e6e4:56ff with SMTP id a5-20020a056e02180500b00316e6e456ffmr10679409ilv.1.1678115831220; Mon, 06 Mar 2023 07:17:11 -0800 (PST) Received: from murgatroyd (75-166-130-93.hlrn.qwest.net. [75.166.130.93]) by smtp.gmail.com with ESMTPSA id i21-20020a02ca15000000b003ed2b203106sm3209633jak.164.2023.03.06.07.17.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 06 Mar 2023 07:17:10 -0800 (PST) From: Tom Tromey To: Tom Tromey via Gdb-patches Cc: Tom Tromey Subject: Re: [PATCH] Fix DAP stackTrace through frames without debuginfo References: <20230215194847.3805619-1-tromey@adacore.com> X-Attribution: Tom Date: Mon, 06 Mar 2023 08:17:10 -0700 In-Reply-To: <20230215194847.3805619-1-tromey@adacore.com> (Tom Tromey via Gdb-patches's message of "Wed, 15 Feb 2023 12:48:47 -0700") Message-ID: <874jqx7vux.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Status: No, score=-5.5 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: >>>>> "Tom" == Tom Tromey via Gdb-patches writes: Tom> The DAP stackTrace implementation did not fully account for frames Tom> without debuginfo. Attemping this would yield a result like: Tom> {"request_seq": 5, "type": "response", "command": "stackTrace", "success": false, "message": "'NoneType' object has no attribute 'filename'", "seq": 11} Tom> This patch fixes the problem by adding another check for None. I'm checking this in now. Tom