From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-il1-x12b.google.com (mail-il1-x12b.google.com [IPv6:2607:f8b0:4864:20::12b]) by sourceware.org (Postfix) with ESMTPS id 9CA543858C54 for ; Mon, 30 Jan 2023 14:26:26 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 9CA543858C54 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=adacore.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=adacore.com Received: by mail-il1-x12b.google.com with SMTP id z2so4581078ilq.2 for ; Mon, 30 Jan 2023 06:26:26 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=adacore.com; s=google; h=mime-version:user-agent:message-id:in-reply-to:date:references :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=DF3SABd0zPSYQt88O8YmJsuz1djQWXDI25bkxczl5ag=; b=FgedVLDwZO1YvO+Lc/2wz6W7oZ8WGLHfqoJuP6RKTjtplfAYWE7OkGoOABNUq830Ls kWF9MhBDv24gIyCo5nsb6eP8gZP9Tw7y8Hk/TwVB+Of1/rP4VbmfEigCkpLPGd368eTd x1AsE6LsGZj0g4k0+pDszJP42xXJe6yJP03k7BxQAfTMqeZ9EAqLVBCGvj3cGSQcIRz5 pnvmndokK5v1ARIzRRdv69WTcHDB8j/1STrflzgGzHX+MGPWKmly/NW5OOQF4ZH5RhcK ek1t1JZhylYHilswPMQZgMUHuOghZiSdLk9sF5jNEPnxbn7kjP7HjBi8rF7b8gPg7H69 6qhg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=mime-version:user-agent:message-id:in-reply-to:date:references :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=DF3SABd0zPSYQt88O8YmJsuz1djQWXDI25bkxczl5ag=; b=wfdTw4TZ3imphnWKt+QnmjMl/hJ3dXJncSS/OHOa68WmHHJ1jtV3H50PUbDkdUOean 9QAIUS3+rVAJDZPuBxvwZwXKOCaAe4qkgGX2HV0yO3UPyzHBgWQkC++JLsN0Pkt0JVhS OD8y+CGDDq6QnisiNdzJ2/BoVQ5/Qawh1HnEraRrHDZ0FA3+J+pEThDhg5SIH8G7y7Rm WUkeleXRymwcL8WFAnyhitKvsAYlAzIjEqDx/iiz9t/CcmEAyBSdideVIyB762BX3p64 Mx7nTILkbJjhpwGV42Oc5/5um2kJW4h3xGVsHOR5Bv2j0vIBySAyY05qHXMAaTcf9GeJ mPVg== X-Gm-Message-State: AO0yUKUVCzcAbn+FowEhdy2gUS+qUkL/mkeHWD0peI/fgAfoxdIdGFvo Sr1h/BiC810f+/KMgM2owWn3NQ== X-Google-Smtp-Source: AK7set9SRNTHQKitHY6+YttQDbGPINlQF62iRP0l8bzzjfrMf6MjRjE5KGt7eG2pCjHp+2KAu3z+/w== X-Received: by 2002:a05:6e02:1c22:b0:310:e499:274e with SMTP id m2-20020a056e021c2200b00310e499274emr7313649ilh.18.1675088785825; Mon, 30 Jan 2023 06:26:25 -0800 (PST) Received: from murgatroyd (75-166-146-144.hlrn.qwest.net. [75.166.146.144]) by smtp.gmail.com with ESMTPSA id z26-20020a056638215a00b003aabed37b1bsm3571628jaj.175.2023.01.30.06.26.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 30 Jan 2023 06:26:25 -0800 (PST) From: Tom Tromey To: Simon Marchi Cc: Tom Tromey , gdb-patches@sourceware.org Subject: Re: [PATCH] Make addrmap const-correct in cooked index References: <20230127162603.4127820-1-tromey@adacore.com> <8446b53b-bd73-637b-7613-45c896d7240f@simark.ca> <87cz6zptg4.fsf@tromey.com> <5246baed-6ebb-6299-f665-b36f02a5fe1b@simark.ca> X-Attribution: Tom Date: Mon, 30 Jan 2023 07:26:24 -0700 In-Reply-To: <5246baed-6ebb-6299-f665-b36f02a5fe1b@simark.ca> (Simon Marchi's message of "Fri, 27 Jan 2023 17:00:12 -0500") Message-ID: <874js8p08f.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Status: No, score=-11.3 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: >>>>> "Simon" == Simon Marchi writes: Simon> So, I redesigned my patch to instead provide both const and non-const Simon> versions of find and foreach. I think it's typical for containers in Simon> C++ anyway. See v2 below: This looks good to me. It addresses my objections. Simon> diff --git a/gdb/dwarf2/index-write.c b/gdb/dwarf2/index-write.c Simon> index ced58eab6612..7b1b2d6520cb 100644 Simon> --- a/gdb/dwarf2/index-write.c Simon> +++ b/gdb/dwarf2/index-write.c Simon> @@ -474,7 +474,7 @@ add_address_entry (data_buf &addr_vec, Simon> int Simon> addrmap_index_data::operator() (CORE_ADDR start_addr, void *obj) Simon> { Simon> - dwarf2_per_cu_data *per_cu = (dwarf2_per_cu_data *) obj; Simon> + dwarf2_per_cu_data *per_cu = static_cast (obj); This area could probably be constified at some point. Tom