From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from progateway7-pub.mail.pro1.eigbox.com (gproxy5-pub.mail.unifiedlayer.com [67.222.38.55]) by sourceware.org (Postfix) with ESMTPS id 962043858D28 for ; Tue, 24 Jan 2023 19:53:08 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 962043858D28 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey.com Received: from cmgw10.mail.unifiedlayer.com (unknown [10.0.90.125]) by progateway7.mail.pro1.eigbox.com (Postfix) with ESMTP id 0DC7B10049664 for ; Tue, 24 Jan 2023 19:53:08 +0000 (UTC) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with ESMTP id KPLwpxgksnkPJKPLwpxIHa; Tue, 24 Jan 2023 19:53:08 +0000 X-Authority-Reason: nr=8 X-Authority-Analysis: v=2.4 cv=f86NuM+M c=1 sm=1 tr=0 ts=63d03724 a=ApxJNpeYhEAb1aAlGBBbmA==:117 a=ApxJNpeYhEAb1aAlGBBbmA==:17 a=dLZJa+xiwSxG16/P+YVxDGlgEgI=:19 a=RvmDmJFTN0MA:10:nop_rcvd_month_year a=Qbun_eYptAEA:10:endurance_base64_authed_username_1 a=T_Alst9gAAAA:8 a=sWrzHx7cfML23ig2nvMA:9 a=DvZ5ixILWSEuw56YIEpp:22 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date:References :Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=DWb/OPAJfYs09EB9TUukIoj3JKitBt6b0H+0BiRnkfw=; b=lA7LgvAiO8cYwj9yFcoatMKfpa r2M9fKFVTwqUG1hE2DBzWdZnEsAEdILzPi2qnJiat/nOUki+PJ1MLN1Ol6vJUpGpZ9gJC9k3VowM8 g2D7ghCVgxzMHm4Y2GTaO4oyp; Received: from 97-122-76-186.hlrn.qwest.net ([97.122.76.186]:37046 helo=prentzel) by box5379.bluehost.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1pKPLv-000tFW-Nn; Tue, 24 Jan 2023 12:53:07 -0700 From: Tom Tromey To: Pedro Alves Cc: Tom Tromey , gdb-patches@sourceware.org Subject: Re: [PATCH 1/8] Convert skip_altivec_tests to allow form References: <20230122215558.1931803-1-tom@tromey.com> <20230122215558.1931803-2-tom@tromey.com> <43d91f20-d1d7-9797-195a-8ed136a660f3@palves.net> X-Attribution: Tom Date: Tue, 24 Jan 2023 12:53:03 -0700 In-Reply-To: <43d91f20-d1d7-9797-195a-8ed136a660f3@palves.net> (Pedro Alves's message of "Mon, 23 Jan 2023 19:45:49 +0000") Message-ID: <874jsfk8v4.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 97.122.76.186 X-Source-L: No X-Exim-ID: 1pKPLv-000tFW-Nn X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 97-122-76-186.hlrn.qwest.net (prentzel) [97.122.76.186]:37046 X-Source-Auth: tom+tromey.com X-Email-Count: 6 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-Spam-Status: No, score=-3021.7 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,JMQ_SPF_NEUTRAL,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: >>>>> "Pedro" == Pedro Alves writes: Pedro> On 2023-01-22 9:55 p.m., Tom Tromey wrote: >> -if {![istarget "powerpc*"] || [skip_altivec_tests]} { >> +require allow_altivec_tests >> +if {![istarget "powerpc*"]} { >> verbose "Skipping altivec abi tests." >> return >> } Pedro> Something preexisting, and that can be done after your patch, but Pedro> I note that it's odd that we have to check [istarget "powerpc*"] Pedro> explicitly. I don't think there are non-Power altivec systems? Pedro> I think the istarget check would be better moved inside Pedro> allow_altivec_tests. All existing callers have that same Pedro> istarget check, even. I've tacked on a patch to do this. Tom