From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-il1-x12d.google.com (mail-il1-x12d.google.com [IPv6:2607:f8b0:4864:20::12d]) by sourceware.org (Postfix) with ESMTPS id E4DC7385840A for ; Fri, 20 Jan 2023 17:05:09 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org E4DC7385840A Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=adacore.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=adacore.com Received: by mail-il1-x12d.google.com with SMTP id p12so2992859ilq.10 for ; Fri, 20 Jan 2023 09:05:09 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=adacore.com; s=google; h=mime-version:user-agent:message-id:in-reply-to:date:references :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=1a5/GO5FgFacYwNlSSeUrGt9ShrWhR5FNw5NdpWEdTk=; b=RgMKs3pLc7/SEG/VJQKxswAz92TnY9RDqUYU94LgdwUAuk9AGRyP7SWM8Fu86Yeg4D V6xnUB6wji/AocE6qViUEpTDBCmpZeotveY+ECI7bYHtEuTlcRbrz8wn1OFa5b80/ZYA Hzcw4cH1LFlDvC2zyS2sDgscxkt74EB/oy4nyr91k+KyQfnhIy8IxLYBoUYuA5//lpVW H2A+qyZdQlyP+WDZtuzUM8yJsJsxH6KNsI70V1/h7whuWeWIYDjgIFbK64haku8oxbyG mUi9Ehv9CEah2eEuZELgBMydhFAmfhzKj3QIgBGlk2G1KBbXjsujP5ltm5ARymgFoaUH P5gw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=mime-version:user-agent:message-id:in-reply-to:date:references :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=1a5/GO5FgFacYwNlSSeUrGt9ShrWhR5FNw5NdpWEdTk=; b=JVSGb99e0WpTnl/mA2vcfhugjqSd+SLIMnI0WkKZbEW8iAKOwUg6aV22cl1WxZEbjT o6YZ+yD5T4gyB4opc3XhrbMzSQoDxSp6IqqBaiTXB2YObJ2di+My7G32sdJXIZqVrOlF lnoy8GYA9fQ9D9x3/SYhLkngOwrqP7BzUniIrn7yAWkaLESdeKrbn1a78QwhpqObKRar KWKSUoSPQAjXV/8ZSWtFsAhvYJbcvvz0/83zOWOodyfD03ekzXOYjYdfVby2l94BYHJf 3nH+GTcf6QeNv033bYwJkbxC/ggFa7AF5G9PKnlC/pLDF/DkuR0YuQ+3ENk67GZ9e2A8 lu8g== X-Gm-Message-State: AFqh2koWnJwmeJZD4UvL5+bya/aoZ9ZQCU+6LZwohjqPIL184xz6bZSa TBAaO/AiI4oGghVIZBaVmxV3ZA== X-Google-Smtp-Source: AMrXdXuz0xmn1txfvNspFG/qsBzW/0WxJQdUkWSPFPoWgtrH3Wv2lzHp19GlpRdDIDRbp73PMFUswg== X-Received: by 2002:a05:6e02:11ac:b0:30d:b083:16a6 with SMTP id 12-20020a056e0211ac00b0030db08316a6mr10032877ilj.26.1674234308817; Fri, 20 Jan 2023 09:05:08 -0800 (PST) Received: from murgatroyd (97-122-76-186.hlrn.qwest.net. [97.122.76.186]) by smtp.gmail.com with ESMTPSA id w5-20020a022a05000000b003a7cbe1d235sm1281577jaw.12.2023.01.20.09.05.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 20 Jan 2023 09:05:08 -0800 (PST) From: Tom Tromey To: Simon Marchi via Gdb-patches Cc: Tom Tromey , Simon Marchi Subject: Re: [PATCH] Make gdb.ada/ptype_tagged_param.exp pass References: <20230119163150.492922-1-tromey@adacore.com> X-Attribution: Tom Date: Fri, 20 Jan 2023 10:05:07 -0700 In-Reply-To: (Simon Marchi via Gdb-patches's message of "Fri, 20 Jan 2023 12:00:10 -0500") Message-ID: <874jslyw58.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Status: No, score=-5.3 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: >>>>> "Simon" == Simon Marchi via Gdb-patches writes: Simon> Do you know what could have changed? New improved DWARF info from a Simon> newer compiler? Possibly, but I don't really know, and I actually don't remember all that much about how tagged types work under the hood. Simon> In any case, your change LGTM, since it will still cause a fail if we do Simon> have debug info but see the bad output. Thanks, I'm going to check it in. Tom