From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id 246B4388DD59 for ; Thu, 15 Dec 2022 13:10:24 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 246B4388DD59 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1671109823; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=0Vnjgtn26G5h21HLeKiQAtofDCHxZdUFk88FTqWq92s=; b=cqxTMEkmxUKGaAwxg6iR6hvK39wJBDfHEONUgShuvPJEi59rS4/OLAznuYgNSTE/mgPwEL 39xtVgYv8uxwT1d9y5m82jn2rjKoa1qvcFi9ZtSGsE9yQBirdEClJlKbkvuKuociutmzlt tFAUvs0gt5FCnGnP4pndz2Ej3BJzUXc= Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-271-QjoTRuYfOd2ZyTbfUJVOsQ-1; Thu, 15 Dec 2022 08:10:22 -0500 X-MC-Unique: QjoTRuYfOd2ZyTbfUJVOsQ-1 Received: by mail-wm1-f70.google.com with SMTP id f20-20020a7bc8d4000000b003d1cda5bd6fso751042wml.9 for ; Thu, 15 Dec 2022 05:10:22 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=mime-version:message-id:date:references:in-reply-to:subject:to:from :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=0Vnjgtn26G5h21HLeKiQAtofDCHxZdUFk88FTqWq92s=; b=XPPF8vSdK89NXbSonhExGD8vrB6pyBdv8eagjjvY8gYgQ1oUXjSivx586a6zJxYnJk 1T+0w97+d1lnssQMvzEsRZ3FRiJLnMvPK1X08XyR+BbOng9nkVn+XGW7zrp43VQgL6r/ ymZYN5U0kcMaNzozpQFEnK+fva+xbgrz1eW+u5tY8hbq85HAS3cRkZ9OTDjgf1uh0NUF HamhckprJAK5vmselTNLbdo/9BrItC9/VgZPHEnvCYJ1178fKbwfNQg228WGX2nPopUL bAQYWP1VZ1SMHt/rPef+bFebxJH5ypN+rl+zDrlaUAic7wjPhkk0B+HutVdi0l03dILJ 9DXg== X-Gm-Message-State: ANoB5pmqAO4lwz3aOE1qqekVUXHpNAwyLMWCbFEbKxLIn+8Y/EzweJ4s qVorb+IEm9CFRJOcCaB8vQEprav3pjBGKvaO25ghza0IfYqscfjHc2f78Cnm0v/RA+GpDE2uRW7 r8yyI+j/riQJdX/fY/ebE9Q== X-Received: by 2002:a05:600c:13c8:b0:3c6:e83a:922d with SMTP id e8-20020a05600c13c800b003c6e83a922dmr22009418wmg.8.1671109821343; Thu, 15 Dec 2022 05:10:21 -0800 (PST) X-Google-Smtp-Source: AA0mqf7Y+1uV4gCI+xh3n3CbPGywlZafbJRMJULIeG7K0HSZ5ejxbkN99JXzUKllYaJqyaJYrdYgmQ== X-Received: by 2002:a05:600c:13c8:b0:3c6:e83a:922d with SMTP id e8-20020a05600c13c800b003c6e83a922dmr22009405wmg.8.1671109821119; Thu, 15 Dec 2022 05:10:21 -0800 (PST) Received: from localhost ([31.111.84.238]) by smtp.gmail.com with ESMTPSA id p16-20020a1c5450000000b003d07de1698asm6122257wmi.46.2022.12.15.05.10.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 15 Dec 2022 05:10:20 -0800 (PST) From: Andrew Burgess To: Tom Tromey , Andrew Burgess via Gdb-patches Subject: Re: [PATCH 1/2] gdb: use gdb_assert not internal_error In-Reply-To: <87h6xydl4h.fsf@tromey.com> References: <7de91e1876385d0b1d025f3ef4c7cd10bc3f1a2e.1671013621.git.aburgess@redhat.com> <87h6xydl4h.fsf@tromey.com> Date: Thu, 15 Dec 2022 13:10:19 +0000 Message-ID: <874jtw24p0.fsf@redhat.com> MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain X-Spam-Status: No, score=-5.6 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Tom Tromey writes: >>>>>> "Andrew" == Andrew Burgess via Gdb-patches writes: > > Andrew> Spotted a couple of places in findvar.c where we use: > Andrew> if ( ! CONDITION ) > Andrew> internal_error ("..."); > > Andrew> this commit changes these to be: > > Andrew> gdb_assert ( CONDITION ); > > Andrew> which I think is better. > > Looks good. From my perspective this is generally desirable and I'd > support considering it obvious. Thanks, pushed. Andrew