From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gproxy4-pub.mail.unifiedlayer.com (gproxy4-pub.mail.unifiedlayer.com [69.89.23.142]) by sourceware.org (Postfix) with ESMTPS id 5BD19383817B for ; Wed, 14 Dec 2022 17:19:45 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 5BD19383817B Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey.com Received: from cmgw14.mail.unifiedlayer.com (unknown [10.0.90.129]) by progateway6.mail.pro1.eigbox.com (Postfix) with ESMTP id C34AA10049315 for ; Wed, 14 Dec 2022 17:19:34 +0000 (UTC) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with ESMTP id 5VPqpgK36XEB25VPqpp1vp; Wed, 14 Dec 2022 17:19:34 +0000 X-Authority-Reason: nr=8 X-Authority-Analysis: v=2.4 cv=Ab50o1bG c=1 sm=1 tr=0 ts=639a05a6 a=ApxJNpeYhEAb1aAlGBBbmA==:117 a=ApxJNpeYhEAb1aAlGBBbmA==:17 a=dLZJa+xiwSxG16/P+YVxDGlgEgI=:19 a=sHyYjHe8cH0A:10:nop_rcvd_month_year a=Qbun_eYptAEA:10:endurance_base64_authed_username_1 a=CCpqsmhAAAAA:8 a=CzfwmFnjSBUSuPFfwzMA:9 a=B5BZ-4F52LRt7zzc:21 a=ul9cdbp4aOFLsgKbc677:22 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date:References :Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=cALddN2DjgIcPSIXX/P2WlikYEgbq6yzzIqbuQLQ1pU=; b=Y9ngKPFLI4d4Hhc1sGX13I5nmY OzEASfkVheJDISoW/yogAgtdIhA5M3g4rOw/rOpWpAZ+flu1rOhFKxSaR49cl3LAbkDcF9nqVrTKu pTGRZurTgN95GhjpihSDUKG2f; Received: from 97-122-76-186.hlrn.qwest.net ([97.122.76.186]:56982 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1p5VPq-003wMM-6B; Wed, 14 Dec 2022 10:19:34 -0700 From: Tom Tromey To: Enze Li via Gdb-patches Cc: Tom Tromey , Enze Li , enze.li@gmx.com Subject: Re: [PATCH] gdb/testsuite: add untested message to skip_debuginfod_tests References: <87zgbre0w8.fsf@tromey.com> X-Attribution: Tom Date: Wed, 14 Dec 2022 10:19:30 -0700 In-Reply-To: (Enze Li via Gdb-patches's message of "Wed, 14 Dec 2022 15:43:24 +0800") Message-ID: <874jtxewd9.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 97.122.76.186 X-Source-L: No X-Exim-ID: 1p5VPq-003wMM-6B X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 97-122-76-186.hlrn.qwest.net (murgatroyd) [97.122.76.186]:56982 X-Source-Auth: tom+tromey.com X-Email-Count: 1 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-Spam-Status: No, score=-3022.2 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,JMQ_SPF_NEUTRAL,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: >>>>> "Enze" == Enze Li via Gdb-patches writes: Enze> Hmmm...Not many. Actually, from the skip_debuginfod_tests, I see an Enze> untested message "cannot find curl". It provides detailed information Enze> when running the testcase. Then I thought other spots in the same Enze> procedure may benifit from it. Personally I think these predicates should just return the result. If a message would be helpful, they can use 'verbose'. Enze> If the way of my previous patch is unconventional, how about this? I think it's kind of overkill. "verbose" in the proc would work just as well, and I suppose my feeling (unsupported by fact really) is that normally an "untested" is just ignored anyway, and if you want to find out what's happening you would have to dig a bit anyway. Also I question if "untested" is correct due to what the dejagnu manual says: UNTESTED A test was not run. This is a placeholder used when there is no real test case yet. I think "unsupported" is what we ought to be using. If you want to see how I think it should generally work, look at my branch "rewrite-require". This changes "require" to be simpler and then tests can express their static requirements very simply: require dwarf2 !isnative mumble bleah Then the main difficulty is converting all the code to use this. I made a stab at it there. Tom