From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-il1-x134.google.com (mail-il1-x134.google.com [IPv6:2607:f8b0:4864:20::134]) by sourceware.org (Postfix) with ESMTPS id 7DF69385062D for ; Mon, 12 Dec 2022 17:27:36 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 7DF69385062D Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=adacore.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=adacore.com Received: by mail-il1-x134.google.com with SMTP id z18so3705915ils.3 for ; Mon, 12 Dec 2022 09:27:36 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=adacore.com; s=google; h=mime-version:user-agent:message-id:in-reply-to:date:references :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=opersoLxOI8LfKtVwX/JoSPaBYvUChTkRW1Au+EOVBM=; b=DDQiGg4icRM98fNmWzNDlwTJz+mGbN16sSdq6n+wa6nGBcfvo3i3Qrd60FmugmFgd/ Ux+y1x1WvRvWvY/ST3bis3DQGY0OTrg0GpbMnp0Tcb8NUYFjaXDvXsCGoDAAsBuTXloL eids7yEYh1617B5uZsqkyzoK98gVch6R4mDh9vRQ5ORFBANaXZZxbvGtl7YO2hNlMPa3 e3LGoH4408Xq5JPO1fEvWdPjOZiYGEucI6SjtCOIlVD5JonVYA4OACFvOtwJSG7zgQrS DMvkhmnS6Aa6sd3YuP0a59MQv+jMbLX6J+Y8wKqXI7k1mvvanUbfK0YoZ6nvOWErPwAF COhg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=mime-version:user-agent:message-id:in-reply-to:date:references :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=opersoLxOI8LfKtVwX/JoSPaBYvUChTkRW1Au+EOVBM=; b=4aj40RyWutmGZ7xjpk6uKn0lkY28pwfL+Gk4Xh82bXfKjPxoEHJied6nRjFlB1MrE7 8ZBLsGQyNZQmE8l083uuL3rJvhEemI1sgBbB9/pSOazhhxGKvrpMsHr+mj7PmHPCkzi6 EXn3YonUl1JUNaLyQvHon3FDBfT5m2vhhK6XGwPQyqxVIkD2tCd7lMgmfWdzIfmeFk9A rMylt+4XXxyVn2fsy1BqcgZ5X8nuqSt8iIUrG8HHVXaYW52NxfIz8gAHXkHFQI6QjKUa 2bNtFv2LuaKHLskld4FYk/+iS8ipx27ZwOd9Vzro49PrWiKquZVak5la1s9EGJmzC8m9 Q9zQ== X-Gm-Message-State: ANoB5pnlyHwYRskvSllwfM5ShC0m8dgkTlryEuE82FabzVQr76LmEgfG YFiLqN2TvrM1CrAFgFhM0CWh6ZjnmJtVJ7p0 X-Google-Smtp-Source: AA0mqf4PcX6mYGv9fDqU8ToUte+beDKlNFerVD4MLCs5OBfeulsVsupOMKLgtiG7d4I6hR44/FQ6ng== X-Received: by 2002:a05:6e02:e12:b0:304:af35:a464 with SMTP id a18-20020a056e020e1200b00304af35a464mr4140804ilk.8.1670866055747; Mon, 12 Dec 2022 09:27:35 -0800 (PST) Received: from murgatroyd (97-122-76-186.hlrn.qwest.net. [97.122.76.186]) by smtp.gmail.com with ESMTPSA id o26-20020a02a1da000000b0038a360671adsm114298jah.27.2022.12.12.09.27.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 12 Dec 2022 09:27:35 -0800 (PST) From: Tom Tromey To: Eli Zaretskii Cc: Tom Tromey , gdb-patches@sourceware.org Subject: Re: [PATCH 2/3] Refactor code to check for terminal sharing References: <20221205185651.2704492-1-tromey@adacore.com> <20221205185651.2704492-3-tromey@adacore.com> <83359t8wai.fsf@gnu.org> X-Attribution: Tom Date: Mon, 12 Dec 2022 10:27:34 -0700 In-Reply-To: <83359t8wai.fsf@gnu.org> (Eli Zaretskii's message of "Mon, 05 Dec 2022 21:50:29 +0200") Message-ID: <874ju0h6rd.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Status: No, score=-5.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: >> Cc: Tom Tromey >> Date: Mon, 5 Dec 2022 11:56:50 -0700 >> From: Tom Tromey via Gdb-patches >> >> One thing I'm not sure of here is how GetConsoleProcessList will work >> in all situations. MSDN has a warning about it: >> >> This API is not recommended and does not have a virtual terminal >> equivalent. [...] Applications remoting via cross-platform >> utilities and transports like SSH may not work as expected if >> using this API. Eli> AFAIU the warning, we have no reasons to be afraid of using this API. Thanks. I've updated the commit message to reflect this. Tom