From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from outbound-ss-820.bluehost.com (outbound-ss-820.bluehost.com [69.89.24.241]) by sourceware.org (Postfix) with ESMTPS id A5013385B193 for ; Wed, 30 Nov 2022 15:44:21 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org A5013385B193 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey.com Received: from cmgw12.mail.unifiedlayer.com (unknown [10.0.90.127]) by progateway2.mail.pro1.eigbox.com (Postfix) with ESMTP id ABD4E1004816C for ; Wed, 30 Nov 2022 15:44:10 +0000 (UTC) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with ESMTP id 0PFqpZhzigVgv0PFqpPMHT; Wed, 30 Nov 2022 15:44:10 +0000 X-Authority-Reason: nr=8 X-Authority-Analysis: v=2.4 cv=L7fY/8f8 c=1 sm=1 tr=0 ts=63877a4a a=ApxJNpeYhEAb1aAlGBBbmA==:117 a=ApxJNpeYhEAb1aAlGBBbmA==:17 a=dLZJa+xiwSxG16/P+YVxDGlgEgI=:19 a=9xFQ1JgjjksA:10:nop_rcvd_month_year a=Qbun_eYptAEA:10:endurance_base64_authed_username_1 a=CCpqsmhAAAAA:8 a=a5cDwTE3A8Hfa5ywwJwA:9 a=ul9cdbp4aOFLsgKbc677:22 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date:References :Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=UrR/axTYwzAbXuctKmkZtmW7XNoF4E8XF7SZnJ9Zx4A=; b=pyME8XB4MWldvCvxrJilj2XcH9 NdkOw6QovAxz6TzcAYjUIW0cRsUQbXSpPBTukDhH7dziaurS0KrlBGESzfU+ET51Q6O2aAqYKo3Mx HyHAqMV9vySfbYhKvcNGwuan/; Received: from 97-122-76-186.hlrn.qwest.net ([97.122.76.186]:56906 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1p0PFq-001EDo-5d; Wed, 30 Nov 2022 08:44:10 -0700 From: Tom Tromey To: Simon Marchi via Gdb-patches Cc: Simon Marchi Subject: Re: [PATCH 1/3] gdb: add inferior_target_stack_changed observer, use it to clear auxv cache References: <20221129025048.44490-1-simon.marchi@polymtl.ca> X-Attribution: Tom Date: Wed, 30 Nov 2022 08:44:08 -0700 In-Reply-To: <20221129025048.44490-1-simon.marchi@polymtl.ca> (Simon Marchi via Gdb-patches's message of "Mon, 28 Nov 2022 21:50:46 -0500") Message-ID: <874jugo3av.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 97.122.76.186 X-Source-L: No X-Exim-ID: 1p0PFq-001EDo-5d X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 97-122-76-186.hlrn.qwest.net (murgatroyd) [97.122.76.186]:56906 X-Source-Auth: tom+tromey.com X-Email-Count: 1 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-Spam-Status: No, score=-3022.2 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,JMQ_SPF_NEUTRAL,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: >>>>> "Simon" == Simon Marchi via Gdb-patches writes: Simon> Add an inferior_target_stack_changed observable, and attach Simon> invalidate_auxv_cache_inf to it. Notify this observable in the Simon> push_target and unpush_target methods of inferior. This looks good to me, thanks. It seems like overall it would be better to have the auxv cache just be some member of 'inferior'. Then these indirections and observers wouldn't be needed -- the inferior could just manage it directly. Tom