From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-io1-xd30.google.com (mail-io1-xd30.google.com [IPv6:2607:f8b0:4864:20::d30]) by sourceware.org (Postfix) with ESMTPS id A54A33858D39 for ; Wed, 31 Aug 2022 16:51:46 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org A54A33858D39 Received: by mail-io1-xd30.google.com with SMTP id n202so12385270iod.6 for ; Wed, 31 Aug 2022 09:51:46 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=mime-version:user-agent:message-id:in-reply-to:date:references :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date; bh=WH9dX5T+PZcVvdaHRe3skO8vDTaQPo51gvU8yqiBhpI=; b=NRcl+ss/5qUSqDr3AqHwP+NJrr/BhB4LqmbQlHDC2Gp4ntsA2cAA3KioHTCa3RJtxX JM8yjfys2JNunNkpcE0SGL5LRLnX4ROPP64zflMW26CxxbWSnJMKsDLFZvTkpJOB8Pnh 1EL9M3xOX0pz1re4HxF9fw8ujp5xczD+AA5sWzmne5zplwN3A9dsFc/en7vQ9xzaF2YY 3/4iTIfEGwTtgXfxgGozIGYgkiiRq4xb7anUMsB2+P2YeO8ycUSsyA2CAXBxbD/Pe32A 02k8pYbsn7zBWr33xdgQisIzjqszZr2RpZ6mNJrd3b7H0XPdosPVZbtxeNWytFbVmp4G UWkQ== X-Gm-Message-State: ACgBeo1PNvYIKcxSpGQbdy5dVQ5p9blvbngIyzKZwZx11kRySUhiAvUF dqTKhAvoHoHgPx/BmIL/p58Pcw== X-Google-Smtp-Source: AA6agR4AJXD4/wCVxPKv73BOJ7ikd1ocruLBT4Bl0HAgdkShJerWjI7PO5yt5R7cbpomP3jQh+rIHg== X-Received: by 2002:a05:6638:2652:b0:34a:f85:6684 with SMTP id n18-20020a056638265200b0034a0f856684mr15469974jat.258.1661964705909; Wed, 31 Aug 2022 09:51:45 -0700 (PDT) Received: from murgatroyd (97-122-83-53.hlrn.qwest.net. [97.122.83.53]) by smtp.gmail.com with ESMTPSA id s7-20020a025107000000b00339e158bd3esm6811352jaa.38.2022.08.31.09.51.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 31 Aug 2022 09:51:45 -0700 (PDT) From: Tom Tromey To: Patrick Monnerat Cc: Tom Tromey , Patrick Monnerat via Gdb-patches Subject: Re: [PATCH] gdb: add a file event mask parameter to add_file_handler References: <20220819174601.144876-1-patrick@monnerat.net> <874jy2dbf6.fsf@tromey.com> <1f5cd3c2-9552-c75a-1add-e3ceebc63e3e@monnerat.net> <877d2xtuxh.fsf@tromey.com> <87a67lbpof.fsf@tromey.com> <693da8b0-9f7d-2a62-8e99-7e64a8dc5593@monnerat.net> X-Attribution: Tom Date: Wed, 31 Aug 2022 10:51:44 -0600 In-Reply-To: <693da8b0-9f7d-2a62-8e99-7e64a8dc5593@monnerat.net> (Patrick Monnerat's message of "Wed, 31 Aug 2022 12:47:10 +0200") Message-ID: <874jxs9x0f.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Status: No, score=-4.8 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 31 Aug 2022 16:51:52 -0000 Patrick> This is great! I applied your changes to Insight and dropped the fd<0 Patrick> test in add_file_handler with total success. Patrick> I'll soon submit version 2 of my patch with the fd<0 test removed, and Patrick> an updated test for mask==0 (this case should call Patrick> delete_file_handler). Patrick> This would have to be pushed after your patch, of course! Patrick> Thanks a lot. No problem, and thanks for trying it out. I'm going to check it in now. Tom