From: Andrew Burgess <aburgess@redhat.com>
To: "Willgerodt, Felix" <felix.willgerodt@intel.com>,
Tom Tromey <tom@tromey.com>,
Felix Willgerodt via Gdb-patches <gdb-patches@sourceware.org>
Subject: RE: [PATCH 1/1] gdb, testsuite: Adapt gdb.base/callfuncs.exp for new clang warnings.
Date: Mon, 18 Jul 2022 14:28:00 +0100 [thread overview]
Message-ID: <874jzesg7z.fsf@redhat.com> (raw)
In-Reply-To: <MN2PR11MB45660907478621A6BCDAC42C8E8C9@MN2PR11MB4566.namprd11.prod.outlook.com>
"Willgerodt, Felix via Gdb-patches" <gdb-patches@sourceware.org> writes:
>> -----Original Message-----
>> From: Tom Tromey <tom@tromey.com>
>> Sent: Freitag, 15. Juli 2022 20:40
>> To: Felix Willgerodt via Gdb-patches <gdb-patches@sourceware.org>
>> Cc: Willgerodt, Felix <felix.willgerodt@intel.com>
>> Subject: Re: [PATCH 1/1] gdb, testsuite: Adapt gdb.base/callfuncs.exp for
>> new clang warnings.
>>
>> >>>>> "Felix" == Felix Willgerodt via Gdb-patches <gdb-
>> patches@sourceware.org> writes:
>>
>> Felix> This patch disables those warnings with -Wno-deprecated-non-
>> prototype.
>>
>> What happens when running the test against gcc?
>>
>
> The test continues to pass.
> I ran it with gcc 9.4, 10.3.1 and 11.3.1 on somewhat latest Ubuntu/Fedora.
> There is also this comment in gdb.exp already:
>
> # Some C/C++ testcases unconditionally pass -Wno-foo as additional
> # options to disable some warning. That is OK with GCC, because
> # by design, GCC accepts any -Wno-foo option, even if it doesn't
> # support -Wfoo. Clang however warns about unknown -Wno-foo by
> # default, unless you pass -Wno-unknown-warning-option as well.
> # We do that here, so that individual testcases don't have to
> # worry about it.
>
> That said, I just tested it again with the latest Intel compilers. And GDB only
> adds the "additional_flags=-Wno-unknown-warning-option" for clang, not
> for icx/icc. I will write a new patch for that soon. But that is a separate
> issue.
Doesn't that mean adding this patch will can cause a test to regress
with the Intel compiler? Shouldn't adding -Wno-unknown-warning-option
for Intel be a prerequisite for this patch?
Thanks,
Andrew
next prev parent reply other threads:[~2022-07-18 13:28 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-08 7:17 Felix Willgerodt
2022-06-08 12:58 ` Bruno Larsen
2022-06-08 15:11 ` Willgerodt, Felix
2022-07-18 13:37 ` Andrew Burgess
2022-07-19 9:06 ` Willgerodt, Felix
2022-07-19 9:14 ` Andrew Burgess
2022-07-19 9:20 ` Willgerodt, Felix
2022-07-19 10:15 ` Andrew Burgess
2022-07-25 11:17 ` Willgerodt, Felix
2022-07-15 18:40 ` Tom Tromey
2022-07-18 9:41 ` Willgerodt, Felix
2022-07-18 13:28 ` Andrew Burgess [this message]
2022-07-18 13:42 ` Willgerodt, Felix
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=874jzesg7z.fsf@redhat.com \
--to=aburgess@redhat.com \
--cc=felix.willgerodt@intel.com \
--cc=gdb-patches@sourceware.org \
--cc=tom@tromey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).