From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id 4D1243842AFD for ; Thu, 30 Jun 2022 14:45:40 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 4D1243842AFD Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-669-fi76fzYoN-C1Gmtfe0Hitw-1; Thu, 30 Jun 2022 10:45:38 -0400 X-MC-Unique: fi76fzYoN-C1Gmtfe0Hitw-1 Received: by mail-wm1-f69.google.com with SMTP id n35-20020a05600c3ba300b003a02d7bd5caso1599584wms.2 for ; Thu, 30 Jun 2022 07:45:38 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:subject:in-reply-to:references:date :message-id:mime-version; bh=1HXq/CeCoqFwPoPXjm8+KGFgsSUBhLP30CqDxecjito=; b=sgG2Nma4oEIBDUB/Aqi0DUhCBazkqd63eeEzJUclUm8p+W3gg7xZphK+ufirgWlEtb 2gSRuF4hYt6wmFfhgwiiaxcCopaGHAew4W7GVEdxIW4pC7TRPAUI7K2CeCgAS2zSW/C5 rGiGIPXMjTUrnlh741Fw1Zvqt7XqcRvyheAYr4iyWtoQFQEq81jIjYyDyPtC0nRkzmkD cOikcwiUPdDbPVCkfpFIqjiC6usRLfoHVtJBFcBD2Uy+BdzpmE+OmRbsFLsg0CV/JNYI 7maxrBjYRlJPfxwJkAcgztHEYO10PH2cCH6JwoDrEOgHDsuk+Es2LhNvF8D8aqak4caQ ajdw== X-Gm-Message-State: AJIora9KPqNxVdCw/H61k7zUuJCpcsTZfLUqfrAJ4W1L5bwk0UtwheVp IxuYluq5bWINxSWaPnSztOmv2KK2y46Zf7yrCNeb7dHm3NhA5FsnCreHQoLlXk+4DngnfMmcXYi Up97pevNZtPAJmqmEcud1hA== X-Received: by 2002:a5d:67cf:0:b0:21b:9fb8:e6d6 with SMTP id n15-20020a5d67cf000000b0021b9fb8e6d6mr8615157wrw.205.1656600336859; Thu, 30 Jun 2022 07:45:36 -0700 (PDT) X-Google-Smtp-Source: AGRyM1uo/61ui2/VQF4qLcuVze+zE5UfFXalmeBmbrTV+yZjxhBPWWHb0LlpJCaVClz1G66eLDN7sw== X-Received: by 2002:a5d:67cf:0:b0:21b:9fb8:e6d6 with SMTP id n15-20020a5d67cf000000b0021b9fb8e6d6mr8615142wrw.205.1656600336694; Thu, 30 Jun 2022 07:45:36 -0700 (PDT) Received: from localhost (15.72.115.87.dyn.plus.net. [87.115.72.15]) by smtp.gmail.com with ESMTPSA id x11-20020adff0cb000000b0021b92171d28sm24232022wro.54.2022.06.30.07.45.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 30 Jun 2022 07:45:36 -0700 (PDT) From: Andrew Burgess To: Bruno Larsen , gdb-patches@sourceware.org Subject: Re: [PATCH v3 05/14] update gdb.base/info-program.exp to not fail with clang In-Reply-To: <20220526151041.23223-6-blarsen@redhat.com> References: <20220526151041.23223-1-blarsen@redhat.com> <20220526151041.23223-6-blarsen@redhat.com> Date: Thu, 30 Jun 2022 15:45:35 +0100 Message-ID: <874k02cir4.fsf@redhat.com> MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain X-Spam-Status: No, score=-10.7 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_BARRACUDACENTRAL, RCVD_IN_DNSWL_LOW, SPF_HELO_NONE, SPF_NONE, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 30 Jun 2022 14:45:41 -0000 Bruno Larsen via Gdb-patches writes: > The updated test specifically mentions that it doesn't care where the > program stops, however it was still testing for something. With this > correction, the test works even if the compiler doesn't add epilogue > information to functions. Considering Pedro's feedback on an earlier patch about "epilogue information" being potentially confusing, maybe this should be replaced with something like: "... if the compiler doesn't emit line table entries for the function epilogue." Or something similar. This patch is OK with that change. Thanks, Andrew > --- > > No change in v3. > > No change in v2. > > --- > gdb/testsuite/gdb.base/info-program.exp | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/gdb/testsuite/gdb.base/info-program.exp b/gdb/testsuite/gdb.base/info-program.exp > index facc13efa2f..f652cfbf426 100644 > --- a/gdb/testsuite/gdb.base/info-program.exp > +++ b/gdb/testsuite/gdb.base/info-program.exp > @@ -28,7 +28,7 @@ gdb_test "info program" "Program stopped at $hex\.\r\nIt stopped at breakpoint $ > > # We don't really care where this step lands, so long as it gets > # the inferior pushed off the breakpoint it's currently on... > -gdb_test "next" "$decimal\t.*" "step before info program" > +gdb_test "next" ".*" "step before info program" > > gdb_test "info program" "Program stopped at $hex\.\r\nIt stopped after being stepped\.\r\nType \"info stack\" or \"info registers\" for more information\." \ > "info program after next" > -- > 2.31.1