From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id 60821386F0CB for ; Fri, 24 Jun 2022 15:08:21 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 60821386F0CB Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-197-4K9Cd07WN_KYed0Ch7mmMA-1; Fri, 24 Jun 2022 11:08:19 -0400 X-MC-Unique: 4K9Cd07WN_KYed0Ch7mmMA-1 Received: by mail-wm1-f69.google.com with SMTP id j20-20020a05600c1c1400b0039c747a1e5aso1579664wms.9 for ; Fri, 24 Jun 2022 08:08:19 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:in-reply-to:references:date :message-id:mime-version; bh=sh2sE/wxd+ZEChZT9dbqgDtEMgqs16uV99eZ96rTeKM=; b=vcbmCzgBnBR68NRBVeeIwTGK3NLheqfARhUJTAxgFvLKDEqb1w2ncDn33E75g9WR/5 ldHEtc1yGAepqiFRuwjPxnNysO71HLdpYNqDrT2sg7O+Wn6MVozEZ6Pahe1DOa8eXR7j UxDEMytQa1cEiemwvYY2NViu5Slsi18Ftv5CzH348r8UT49lc3jMABnDVgCVnK92iYYc Cku4Kga6VtZ3O8YAYwf1b5vorxEpC3e4oQn9HnJhZrpMSYg4DaJMfNgvmT3OGoQgHezj OHq7JFjxboIc9EWnVchU+AE/gy7QS7bQoNuHsVC75VcAACDX5krCESnCfQpteQp77eOD A/fg== X-Gm-Message-State: AJIora/6QCR2Ah6VD4mGZSwW8VFNb84a+v5Tu6t0I5eWnAzs/59DSMDA JU2owlnvJMZhkAKb5ZnprjEUrMz1YJAO1lf6ke8GI+S95I6wU2B0bez8NttY4eU/3iKRsQHI5RE l8j/II/EaZO/AmHDT2Y2ErA== X-Received: by 2002:a05:600c:4f4f:b0:39c:6fb7:ee5e with SMTP id m15-20020a05600c4f4f00b0039c6fb7ee5emr4428346wmq.109.1656083298630; Fri, 24 Jun 2022 08:08:18 -0700 (PDT) X-Google-Smtp-Source: AGRyM1s1QYO94OdLgdldDWQiSRy5rSYQMrFlouQNP5K/95k8ganRXTfsXm7WuVY6xejbchyoXYZxsA== X-Received: by 2002:a05:600c:4f4f:b0:39c:6fb7:ee5e with SMTP id m15-20020a05600c4f4f00b0039c6fb7ee5emr4428320wmq.109.1656083298421; Fri, 24 Jun 2022 08:08:18 -0700 (PDT) Received: from localhost ([195.213.152.79]) by smtp.gmail.com with ESMTPSA id j20-20020a05600c2b9400b00397623ff335sm3077327wmc.10.2022.06.24.08.08.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 24 Jun 2022 08:08:17 -0700 (PDT) From: Andrew Burgess To: "Maciej W. Rozycki" , gdb-patches@sourceware.org Cc: Simon Sobisch , Tom Tromey Subject: Re: [PATCH v5 3/8] GDB: Add `NUMBER' completion to `set' integer commands In-Reply-To: References: Date: Fri, 24 Jun 2022 16:08:16 +0100 Message-ID: <874k0aaylb.fsf@redhat.com> MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain X-Spam-Status: No, score=-6.2 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, KAM_ASCII_DIVIDERS, RCVD_IN_DNSWL_LOW, SPF_HELO_NONE, SPF_NONE, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 24 Jun 2022 15:08:22 -0000 "Maciej W. Rozycki" writes: > Fix a completion consistency issue with `set' commands accepting integer > values and the special `unlimited' keyword: > > (gdb) complete print -elements > print -elements NUMBER > print -elements unlimited > (gdb) > > vs: > > (gdb) complete set print elements > set print elements unlimited > (gdb) > > (there is a space entered at the end of both commands, not shown here) > which also means if you strike with `set print elements ' input, > it will, annoyingly, complete to `set print elements unlimited' right > away rather than showing a choice between `NUMBER' and `unlimited'. > > Add `NUMBER' then as an available completion for such `set' commands: > > (gdb) complete set print elements > set print elements NUMBER > set print elements unlimited > (gdb) > > Adjust the testsuite accordingly. I like this change, but I think we should add some documentation in `@node Completion` that describes this new behaviour. We should probably add a NEWS entry too. Thanks, Andrew > --- > No change from v4. > > New change in v4. > --- > gdb/cli/cli-decode.c | 2 ++ > gdb/testsuite/gdb.base/settings.exp | 8 +++++++- > 2 files changed, 9 insertions(+), 1 deletion(-) > > gdb-integer-complete-number.diff > Index: src/gdb/cli/cli-decode.c > =================================================================== > --- src.orig/gdb/cli/cli-decode.c > +++ src/gdb/cli/cli-decode.c > @@ -989,6 +989,8 @@ integer_unlimited_completer (struct cmd_ > NULL, > }; > > + if (*text == '\0') > + tracker.add_completion (make_unique_xstrdup ("NUMBER")); > complete_on_enum (tracker, keywords, text, word); > } > > Index: src/gdb/testsuite/gdb.base/settings.exp > =================================================================== > --- src.orig/gdb/testsuite/gdb.base/settings.exp > +++ src/gdb/testsuite/gdb.base/settings.exp > @@ -215,8 +215,14 @@ proc test-integer {variant} { > test_gdb_complete_none \ > "$set_cmd " > } else { > + test_gdb_complete_multiple "$set_cmd " "" "" { > + "NUMBER" > + "unlimited" > + } > + test_gdb_complete_none \ > + "$set_cmd 1" > test_gdb_complete_unique \ > - "$set_cmd " \ > + "$set_cmd u" \ > "$set_cmd unlimited" > } >