From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id 7383B3858C50 for ; Mon, 21 Mar 2022 11:10:20 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 7383B3858C50 Received: from mail-wr1-f69.google.com (mail-wr1-f69.google.com [209.85.221.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-630-lbENWWunNSG0JvMWL9tdVg-1; Mon, 21 Mar 2022 07:09:17 -0400 X-MC-Unique: lbENWWunNSG0JvMWL9tdVg-1 Received: by mail-wr1-f69.google.com with SMTP id k20-20020adfc714000000b001e305cd1597so2965947wrg.19 for ; Mon, 21 Mar 2022 04:09:17 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:subject:in-reply-to:references:date :message-id:mime-version; bh=0hufRxe55GkekGvdFCHV4uIQPMDf5HxccLKUrBiqDPw=; b=IbQRDgODh4Fdopiu4mQjanbheKYf50zWl1XEZEOFRJtnGtBJEjuOboaQksVVUWFqCq iIxt+bWWz3quIZpdqs0HCOH39m4s9Y/wgoXAE4k90wR8HJh/bZbo0Vyt1a41T6IeXfr8 mM5jgmwjx6hRF5vyl+qZvrUyx4lJW+AQ/Fyai1mPPK2vW2vGVleKEWq4Ms0PW+akSq4x elBqdCaN0TrMqH4DxINvXdXp/bnbyWKXIdOnsaO6FMyYyvZeQ5HlG4xEJLhQ0lyITsO6 XRcHCGYtGkyrKJQUYKFV8mziZgUrz5aPN2xOW0mNJsNuMJFeKdkTPMIz/VsUbKb93xag zRMg== X-Gm-Message-State: AOAM532zxSiV7XVYrO0nVcSJDrf/PUTxpop2Jnr4BK0xI70Bef9OaQ4z sBdM/ldXQv2GKISefQ8rbdIkIiq/Z/nqCj/KPh2herwPKZh/p7EvChw/e4uMmgxiCjetyU2vxpf N2oKmdl8VaJEHlPmcdDC0uQ== X-Received: by 2002:a05:600c:4f47:b0:381:6c3e:19dc with SMTP id m7-20020a05600c4f4700b003816c3e19dcmr18706751wmq.155.1647860955582; Mon, 21 Mar 2022 04:09:15 -0700 (PDT) X-Google-Smtp-Source: ABdhPJza0jz61HdYf26GFwhTZAbart7cVRWxYlNxBkNZ/z4VnvRir92bCOtqXKb8dP0H+9EOZrA+qA== X-Received: by 2002:a05:600c:4f47:b0:381:6c3e:19dc with SMTP id m7-20020a05600c4f4700b003816c3e19dcmr18706732wmq.155.1647860955307; Mon, 21 Mar 2022 04:09:15 -0700 (PDT) Received: from localhost (host109-158-45-15.range109-158.btcentralplus.com. [109.158.45.15]) by smtp.gmail.com with ESMTPSA id c11-20020a05600c0a4b00b0037c91e085ddsm19773265wmq.40.2022.03.21.04.09.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 21 Mar 2022 04:09:14 -0700 (PDT) From: Andrew Burgess To: Andreas Schwab , gdb-patches@sourceware.org Subject: Re: [PATCH] Add support for readline 8.2 In-Reply-To: <87ils8ojkd.fsf@igel.home> References: <87ils8ojkd.fsf@igel.home> Date: Mon, 21 Mar 2022 11:09:13 +0000 Message-ID: <874k3rtvdy.fsf@redhat.com> MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain X-Spam-Status: No, score=-12.4 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, KAM_NUMSUBJECT, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H5, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_NONE, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 21 Mar 2022 11:10:21 -0000 Andreas Schwab writes: > In readline 8.2 the type of rl_completer_word_break_characters changed to > include const. LGTM. Thanks, Andrew > --- > gdb/completer.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/gdb/completer.c b/gdb/completer.c > index d3900ae2014..a51c16ac7f8 100644 > --- a/gdb/completer.c > +++ b/gdb/completer.c > @@ -36,7 +36,7 @@ > calling a hook instead so we eliminate the CLI dependency. */ > #include "gdbcmd.h" > > -/* Needed for rl_completer_word_break_characters() and for > +/* Needed for rl_completer_word_break_characters and for > rl_filename_completion_function. */ > #include "readline/readline.h" > > @@ -2011,7 +2011,7 @@ gdb_completion_word_break_characters_throw () > rl_basic_quote_characters = NULL; > } > > - return rl_completer_word_break_characters; > + return (char *) rl_completer_word_break_characters; > } > > char * > -- > 2.35.0 > > > -- > Andreas Schwab, schwab@linux-m68k.org > GPG Key fingerprint = 7578 EB47 D4E5 4D69 2510 2552 DF73 E780 A9DA AEC1 > "And now for something completely different."