From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id 442623858D39 for ; Wed, 2 Mar 2022 12:34:44 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 442623858D39 Received: from mail-wr1-f69.google.com (mail-wr1-f69.google.com [209.85.221.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-182-90O3LfHsMXCI1LIDa8LaVA-1; Wed, 02 Mar 2022 07:34:42 -0500 X-MC-Unique: 90O3LfHsMXCI1LIDa8LaVA-1 Received: by mail-wr1-f69.google.com with SMTP id x15-20020a5d6b4f000000b001ee6c0aa287so591292wrw.9 for ; Wed, 02 Mar 2022 04:34:42 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:subject:in-reply-to:references:date :message-id:mime-version; bh=LTfOj1/H5eLSfOeNeSqaARtIlyia0ixt0lnyWq6F9Ms=; b=QsL2l0kiyhsniLXHbbbBL2H2Y+g3m6wby33Tiu1hQLwImeSnEbPQ3REPCBBl+TH2Nx 43oUQplyTV7yNx4C9CkCL42gGGTIoQC9hCTqv/xcckYUIF+RnQ6/mkiUtJANbe2JUSPH gPGJauDUqzMekzIwth3tEbpCnT+vgbzw6mmIZ0tXfL6atw+1PUopAGN0Se/nQEDsfZcN tw4F2BZtS2ahxcqp3qJq/Ce3Q8r/fCV6OX33CLXTFIb55OjbybDkNQdc4vm+3mzq64bo F37vdk5WSHHZZKHjN9pp2NhUrTqH9Zu/C9qHs0KVBwBcNjeQlSgKYD4mnW7n+s4XH7he WVDQ== X-Gm-Message-State: AOAM531AXyumkEwNNuoV1BdodpzNqUlaN6ZZiFz6JtjNbh/u/eQOLkNo TALRzod7qmoPYxf3+4MyLvf6FtX1F8VohyXQ2m9PSnuJY0Vt7yr/UZ0h8NnF+FkMXeR5NkKXel4 5+3jZKwa5VX6v8cmq1qOW+g== X-Received: by 2002:a1c:a54f:0:b0:380:4f49:624a with SMTP id o76-20020a1ca54f000000b003804f49624amr20219531wme.164.1646224481532; Wed, 02 Mar 2022 04:34:41 -0800 (PST) X-Google-Smtp-Source: ABdhPJwrEo7Ta3fWuECNaUnx2nZ/HDM+FIVKGNuGeShx69Gd8lOGTqV604ibRwm4Dum15rIOBoC03Q== X-Received: by 2002:a1c:a54f:0:b0:380:4f49:624a with SMTP id o76-20020a1ca54f000000b003804f49624amr20219516wme.164.1646224481295; Wed, 02 Mar 2022 04:34:41 -0800 (PST) Received: from localhost (host86-169-131-29.range86-169.btcentralplus.com. [86.169.131.29]) by smtp.gmail.com with ESMTPSA id f22-20020a1cc916000000b00380d3e49e89sm5295336wmb.22.2022.03.02.04.34.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 02 Mar 2022 04:34:40 -0800 (PST) From: Andrew Burgess To: Tiezhu Yang , gdb-patches@sourceware.org Subject: Re: [PATCH] gdb: testsuite: fix failed testcases in gdb.base/gdb-caching-proc.exp In-Reply-To: <1646211529-10120-1-git-send-email-yangtiezhu@loongson.cn> References: <1646211529-10120-1-git-send-email-yangtiezhu@loongson.cn> Date: Wed, 02 Mar 2022 12:34:39 +0000 Message-ID: <874k4gzg68.fsf@redhat.com> MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain X-Spam-Status: No, score=-12.2 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H5, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_NONE, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 02 Mar 2022 12:34:45 -0000 Tiezhu Yang writes: > When execute the following command: > > make check-gdb TESTS="gdb.base/gdb-caching-proc.exp" > > we can see there exists some failed testcases: > > FAIL: gdb.base/gdb-caching-proc.exp: can_spawn_for_attach: 0: can spawn for attach (got interactive prompt) > FAIL: gdb.base/gdb-caching-proc.exp: can_spawn_for_attach: 1: can spawn for attach (got interactive prompt) > FAIL: gdb.base/gdb-caching-proc.exp: can_spawn_for_attach: 2: can spawn for attach (got interactive prompt) > FAIL: gdb.base/gdb-caching-proc.exp: can_spawn_for_attach: 3: can spawn for attach (got interactive prompt) > FAIL: gdb.base/gdb-caching-proc.exp: can_spawn_for_attach: 4: can spawn for attach (got interactive prompt) > FAIL: gdb.base/gdb-caching-proc.exp: can_spawn_for_attach: 5: can spawn for attach (got interactive prompt) > FAIL: gdb.base/gdb-caching-proc.exp: can_spawn_for_attach: 6: can spawn for attach (got interactive prompt) > FAIL: gdb.base/gdb-caching-proc.exp: can_spawn_for_attach: 7: can spawn for attach (got interactive prompt) > FAIL: gdb.base/gdb-caching-proc.exp: can_spawn_for_attach: 8: can spawn for attach (got interactive prompt) > FAIL: gdb.base/gdb-caching-proc.exp: can_spawn_for_attach: 9: can spawn for attach (got interactive prompt) > > here are the detailed messages in gdb/testsuite/gdb.log: > > attach 873776^M > A program is being debugged already. Kill it? (y or n) n^M > Not killed.^M > (gdb) FAIL: gdb.base/gdb-caching-proc.exp: can_spawn_for_attach: 0: can spawn for attach (got interactive prompt) > > so handle the case "A program is being debugged already. Kill it" in > can_spawn_for_attach to fix the failed testcases. LGTM. Thanks for fixing this. Andrew > > Signed-off-by: Tiezhu Yang > --- > gdb/testsuite/lib/gdb.exp | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/gdb/testsuite/lib/gdb.exp b/gdb/testsuite/lib/gdb.exp > index 848cd08..a35d08a 100644 > --- a/gdb/testsuite/lib/gdb.exp > +++ b/gdb/testsuite/lib/gdb.exp > @@ -5130,6 +5130,10 @@ gdb_caching_proc can_spawn_for_attach { > kill_wait_spawned_process $test_spawn_id > return 1 > } > + -re "A program is being debugged already. Kill it. .y or n. " { > + send_gdb "y\n" > + exp_continue > + } > } > > kill_wait_spawned_process $test_spawn_id > -- > 2.1.0