From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from userp2120.oracle.com (userp2120.oracle.com [156.151.31.85]) by sourceware.org (Postfix) with ESMTPS id 150883858C27 for ; Mon, 10 May 2021 18:49:32 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 150883858C27 Received: from pps.filterd (userp2120.oracle.com [127.0.0.1]) by userp2120.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 14AIYqLd107303; Mon, 10 May 2021 18:49:28 GMT Received: from userp3030.oracle.com (userp3030.oracle.com [156.151.31.80]) by userp2120.oracle.com with ESMTP id 38dk9nc9ce-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 10 May 2021 18:49:28 +0000 Received: from pps.filterd (userp3030.oracle.com [127.0.0.1]) by userp3030.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 14AITZcB185146; Mon, 10 May 2021 18:49:27 GMT Received: from nam04-bn8-obe.outbound.protection.outlook.com (mail-bn8nam08lp2047.outbound.protection.outlook.com [104.47.74.47]) by userp3030.oracle.com with ESMTP id 38dfrvxx6j-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 10 May 2021 18:49:27 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=QkVjCZY2Xl7AwJOejXn6lLRNDqqF3cBXe9+Z/HNfcRDvR8ytK2nyO4v9ecuNjTZgkhyrujAfiBHylsDRg9NysKJCizUDeI8lTtCBuVXO952ij+DqrHIic5LnARIMcMLjVYgvY1+9w0T+Z8Mg/e/cfH7imkYyISqwrlkYkxHOBjY1MPK17xD6SaqAWxSOhzraBoCXt93dD+7MHVwB/hxJfobCHj/TAjzZCGpfuedRof+kGDgjSR06Bz7OrVaAvQWjfDHdr9F92/4oMQ3iZBRGaE2fYrGHjqcpMEs05jSn4GSuS2Z+uMYmJ7PlgSntzhXu4OYQbV2fo0Pfjuopg1EsOQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=LZDkBcb+WncW70d5jOn9T8hAhI0Eqefliu41/b4Xw+U=; b=SMPJ8rRIcvwVEzJQ7ER4gEVjR4pBcPwj80kYwqHIK9pBm2fDMSnVcb0Lvjev336nUl8Mgd2gf/mD0ZxDdJZ1YSwxKelekx/+cdIwaRFNe9TnjegvIUHBDBS4T8G1GTVoP7yIvdLg6fNt2vWqGmnNHVt2dbbG9WQt6WZTT4cmPKgA8HSGw2+VpVb09d5QfCSZStj08RDm3nQx/T5wImlFFjzLVWl694wuR7sP64oEmHUX/QSR1KqBsIFO+vJcbgQhS6NZEntqoIdXX7QD8QemFLXOM/KGbf/IcMqsBunwP0IqWnl4LIRZ9QiiRqzWnWz/yMMlZ1fXPpAvlsOXL31Ofw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none Received: from DM5PR10MB2041.namprd10.prod.outlook.com (2603:10b6:3:111::16) by DS7PR10MB5375.namprd10.prod.outlook.com (2603:10b6:5:3ab::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4108.29; Mon, 10 May 2021 18:49:25 +0000 Received: from DM5PR10MB2041.namprd10.prod.outlook.com ([fe80::14a9:31e9:48af:5e4f]) by DM5PR10MB2041.namprd10.prod.outlook.com ([fe80::14a9:31e9:48af:5e4f%8]) with mapi id 15.20.4108.031; Mon, 10 May 2021 18:49:25 +0000 From: "Jose E. Marchesi" To: Eli Zaretskii Cc: gdb-patches@sourceware.org Subject: Re: [PATCH 1/1] Integrate GNU poke in GDB References: <20210510151044.20829-1-jose.marchesi@oracle.com> <20210510151044.20829-2-jose.marchesi@oracle.com> <83pmxy5xz6.fsf@gnu.org> Date: Mon, 10 May 2021 20:49:20 +0200 In-Reply-To: <83pmxy5xz6.fsf@gnu.org> (Eli Zaretskii's message of "Mon, 10 May 2021 19:56:29 +0300") Message-ID: <874kfawhjj.fsf@oracle.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Content-Type: text/plain X-Originating-IP: [141.143.193.76] X-ClientProxiedBy: LO4P123CA0404.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:189::13) To DM5PR10MB2041.namprd10.prod.outlook.com (2603:10b6:3:111::16) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from termi.oracle.com (141.143.193.76) by LO4P123CA0404.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:189::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4108.25 via Frontend Transport; Mon, 10 May 2021 18:49:24 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: c158db58-4ec3-4329-20e3-08d913e45561 X-MS-TrafficTypeDiagnostic: DS7PR10MB5375: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:8273; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: zxdqS8XqM3jy1yYJ8qVtxhC0LzLnXSAFvgnobBmr84pzxMRgWRNzRrmvZThxkTXzjGmPGOy3q2R7S1HtW99iEGyQHesjgPOIqJEApMonoIOoE4CdXMukfqd1tguyzB/dhSn64b554llRGoaEeRGJtpNmE9Za8VrdSrb4cIpTkCtkON8DlYYSvbpnBjGbOA7f+KAf4rEtGWnj1oAA5/tcseH3M2gXeloiHSsRIsiv1AZ+rYbSTMHrPEod3kQuCj2k2EyH9XzphEYHBIXX3kNVGU3oilMfphHQSDeiSbp+QVUo0YwaIcJsZ6o5+gYUh78BO2cnEVhz/OUaRi19+xCwB/y9JZwLsymWvzMMm+abB7Ri8X5IlNLL14qvr8y3F9YecIuLez9SGwItXC3PTXo8j9CUVqGz6lAlt5BNfck/aEhtZDlEjg3rrFMn6vc/faanIQu7YGUOEWIAJn+PJ+ZY3UvhreEn/iomNs2pnufcvbbNIw/GmqckxhpvZzBd1skpwj8WQ7jpf6MEctJWPgQlNrwzQYVX1NgvQq0EMDEqiVqXYr/BbnVqp/AY56HXLLgPh6lqpNiZ4hjN+wE/OAUuMlX14vWCusbS6etqUKC8DlZ/JCISczOPJlINMMp1FqmxSGqi5uyJkYlpPyEkmkXz4A== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM5PR10MB2041.namprd10.prod.outlook.com; PTR:; CAT:NONE; SFS:(39860400002)(136003)(396003)(346002)(376002)(366004)(52116002)(4326008)(2616005)(66946007)(956004)(7696005)(8676002)(5660300002)(26005)(6666004)(6486002)(86362001)(66556008)(6916009)(2906002)(186003)(8936002)(16526019)(38100700002)(38350700002)(36756003)(4744005)(66476007)(316002)(478600001); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData: =?us-ascii?Q?KZIkN1ToTohBT7oLRcpdY4G+YnTYZlAKaQ6xUXw/xCG38QUgOhhZPOn/NSli?= =?us-ascii?Q?vxRVU0CP9LKWLZnwMg+edKjffD35Kg+20pXTUXpyHQRfVvipr5L2LLNcvIj/?= =?us-ascii?Q?e37pZmeRaPMe/erWVeKJgYt44jiewnZgX2vOWnbcgHE2n4IscieYLnQCJ+R2?= =?us-ascii?Q?XMAoVqryw5M9v49C9RXCVc8NEMGSVQnj5lnaoNKKm+3BeY1FXiEhmwAwsEm6?= =?us-ascii?Q?JmQjCvMe55tQdZfcB0ZaPb14gzJhSH+7geHZXcdSkd/cAFKhMt6LbQb461m7?= =?us-ascii?Q?OFRr85JLz9MD3NJGYbFCebzqrxm3zM4yHrxUVNcCQw0goKm3jVrp9UC0ikaX?= =?us-ascii?Q?WKqAtWUnEcqrtby5y1X6BYflYA5QtMXkWk2idomsuka+0k/xtzqtmhSf1i4e?= =?us-ascii?Q?mGGOICXOkd34ruG9uw4TQOARNPdOBIMeoCiCwRHFt7WkG7e9fHnTddPJXuB1?= =?us-ascii?Q?CYy/pgNVzqPjj6fq0D8m9IA9V+6mP1nS9QNW3+lfqWsB9eai/lyhCAGkrM3+?= =?us-ascii?Q?O+Y7aVQcjUCnXDV8jw2VWTocvmRlCJ4oHjDlUUAAZWuFMX/dbbh4lRQUXVr7?= =?us-ascii?Q?UPKrEvoZrkRo2sSYpngb5OwJ6h9+ixyAFtgChg1K1iuYF1bVW07bEQfVp87c?= =?us-ascii?Q?/HSC4Z2sIqoKvx5IND6UNQlBczssgkqZnSdvlCvj3EIAvfU/l6A9dQMmjyyn?= =?us-ascii?Q?d3ovRRrs5OG8ZWuWkSMcWN2N3udDRDC5PWSUgLoMgtX+Au2TKUSzQ6Y3KDlh?= =?us-ascii?Q?jMXJdjsZFWXHWTQxDLEoySfk0m4SKb4la8HterSBw5nqZ9y25/1/O2TWsZEq?= =?us-ascii?Q?GR3N1xgkBIiPF0QDjTITsxKpXT7IIIenrZln0VbQz3OU0FP84nb9rEu4Hx2H?= =?us-ascii?Q?HpUH52soK318aFT7fmQk5W9ujWW7DFRU+WQkCOe97cnm1nMzV1YP9tpC8rDC?= =?us-ascii?Q?56P0MOGkKlOkYM8EcFXxfN5LW4xbvjPrldk05fiZmdVrGdcCDT22/UjAeG+Z?= =?us-ascii?Q?FDNvsZa1ia8xeGSwbRHDufhe2y0eKW/EA75mJb1w5Sa+HtIovO4YyFi/WJ/h?= =?us-ascii?Q?AU7Jyo01q9uqjX6Gqbk3jb4KWnRRN7IKUMCnIpy2fhQw7KFyU3Q/60pk9138?= =?us-ascii?Q?jIiBUgamjvB9qK4S/sWpOCT6ElPBkACk9GV+Hrr8Gb2funRWjOwRqBziTNLV?= =?us-ascii?Q?9kjFsOMc3QjCpSpQKgydpjfPyYSiIZvvNzNbyQWn3Y4+8n/NUw7QTNb5UB8M?= =?us-ascii?Q?1/wdBZOd1bVZIW5IGlSFsnErqvapJeh1J2r8X3U7RTe2shg1NDj96xVQY85P?= =?us-ascii?Q?JizS65P8FLLPjiJMsTgFMgq8?= X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-Network-Message-Id: c158db58-4ec3-4329-20e3-08d913e45561 X-MS-Exchange-CrossTenant-AuthSource: DM5PR10MB2041.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 May 2021 18:49:25.6795 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: JZb9md/e5jxQuhaRtd240BKaJDri8vM1rcbN+jIWIjrW7l1e/A0SIx0VDT7qJ8bAZL1WFgTQRzMAapY3GDedSc9OeyLliuKbUYh8K6B3I64= X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS7PR10MB5375 X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=9980 signatures=668683 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxlogscore=999 phishscore=0 adultscore=0 bulkscore=0 mlxscore=0 suspectscore=0 malwarescore=0 spamscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2104190000 definitions=main-2105100125 X-Proofpoint-ORIG-GUID: wkwfsCZHegSOGzQZn0ZSsvGtsXJY71LN X-Proofpoint-GUID: wkwfsCZHegSOGzQZn0ZSsvGtsXJY71LN X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=9980 signatures=668683 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 phishscore=0 adultscore=0 mlxscore=0 impostorscore=0 mlxlogscore=999 lowpriorityscore=0 malwarescore=0 priorityscore=1501 clxscore=1011 bulkscore=0 spamscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2104190000 definitions=main-2105100125 X-Spam-Status: No, score=-5.5 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, MSGID_FROM_MTA_HEADER, RCVD_IN_MSPIKE_H2, SPF_HELO_PASS, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 10 May 2021 18:49:33 -0000 Hi Eli. Thanks for your feedback. I will fix all the points you raise in the next version for the patch. But I have got one question: >> +(@value{GDBP}) type Packet = struct @{ byte magic == 0x4a; byte sz; byte[sz] payload; @} > > This line is too long, it will typeset badly in the printed version. > Please break it into two or more lines. What is the convention to denote one logical line in two physical lines in verbatim/example sections? Something like this? (@value{GDBP}) type Packet = struct @{ byte magic == 0x4a; \ byte sz; byte[sz] payload; @}