From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from rock.gnat.com (rock.gnat.com [205.232.38.15]) by sourceware.org (Postfix) with ESMTP id 780873947438 for ; Tue, 13 Apr 2021 19:29:08 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 780873947438 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=adacore.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey@adacore.com Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id 2D6A056207; Tue, 13 Apr 2021 15:29:08 -0400 (EDT) X-Virus-Scanned: Debian amavisd-new at gnat.com Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id kC-adp2QiqfF; Tue, 13 Apr 2021 15:29:08 -0400 (EDT) Received: from murgatroyd (71-211-182-15.hlrn.qwest.net [71.211.182.15]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by rock.gnat.com (Postfix) with ESMTPSA id D06F256206; Tue, 13 Apr 2021 15:29:07 -0400 (EDT) From: Tom Tromey To: Simon Marchi via Gdb-patches Subject: Re: [PATCH] gdb, gdbserver: remove WinCE support code References: <20210410231021.1232451-1-simon.marchi@polymtl.ca> X-Attribution: Tom Date: Tue, 13 Apr 2021 13:29:07 -0600 In-Reply-To: <20210410231021.1232451-1-simon.marchi@polymtl.ca> (Simon Marchi via Gdb-patches's message of "Sat, 10 Apr 2021 19:10:21 -0400") Message-ID: <874kgahtks.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Status: No, score=-9.4 required=5.0 tests=BAYES_00, GIT_PATCH_0, KAM_DMARC_STATUS, RCVD_IN_BARRACUDACENTRAL, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 13 Apr 2021 19:29:09 -0000 >>>>> "Simon" == Simon Marchi via Gdb-patches writes: Simon> The support for WinCE was removed with commit 84b300de3666 ("gdbserver: Simon> remove support for ARM/WinCE"). There is some leftover code for WinCE Simon> support, guarded by the _WIN32_WCE macro, which I didn't know of at the Simon> time. I found one more spot, let me know what you think of the appended. Tom commit 765c5c546656b1a8012cf78d75aab644451d6d3e Author: Tom Tromey Date: Tue Apr 13 13:25:53 2021 -0600 Remove use of _WIN32_WCE This removes the one last use of _WIN32_WCE from gdbserver. gdbserver/ChangeLog 2021-04-13 Tom Tromey * win32-low.cc (windows_nat::handle_load_dll): Don't check _WIN32_WCE. diff --git a/gdbserver/ChangeLog b/gdbserver/ChangeLog index ff008151421..e85fa775d7a 100644 --- a/gdbserver/ChangeLog +++ b/gdbserver/ChangeLog @@ -1,3 +1,8 @@ +2021-04-13 Tom Tromey + + * win32-low.cc (windows_nat::handle_load_dll): Don't check + _WIN32_WCE. + 2021-04-13 Tom Tromey * win32-low.cc (winapi_CreateToolhelp32Snapshot) diff --git a/gdbserver/win32-low.cc b/gdbserver/win32-low.cc index 6502d857732..39a6848307a 100644 --- a/gdbserver/win32-low.cc +++ b/gdbserver/win32-low.cc @@ -1221,11 +1221,9 @@ windows_nat::handle_load_dll () dll_name = get_image_name (current_process_handle, event->lpImageName, event->fUnicode); -#ifndef _WIN32_WCE if (dll_name == nullptr && event->lpBaseOfDll != nullptr) dll_name = win32_add_dll (event->lpBaseOfDll); -#endif if (dll_name == nullptr) return;