From: Tom Tromey <tom@tromey.com>
To: Felix Willgerodt via Gdb-patches <gdb-patches@sourceware.org>
Subject: Re: [PATCH 2/2] gdb: Fix reduce/reduce conflicts for qualifier_seq_noopt in the C parser.
Date: Thu, 01 Apr 2021 12:20:28 -0600 [thread overview]
Message-ID: <874kgpooib.fsf@tromey.com> (raw)
In-Reply-To: <20210326142609.245016-3-felix.willgerodt@intel.com> (Felix Willgerodt via Gdb-patches's message of "Fri, 26 Mar 2021 15:26:09 +0100")
>>>>> "Felix" == Felix Willgerodt via Gdb-patches <gdb-patches@sourceware.org> writes:
Felix> Note that how the binding of this qualifier is interpreted and resolved for an
Felix> address/pointer is target specific. Hence only the prepended qualifier works
Felix> for AVR, even if it seems syntactically incorrect. I won't change this for
Felix> AVR, as I am not familiar with that target.
Probably we should follow whatever GCC does here.
Felix> * c-exp.y (qualifier_seq_noopt): Replace qualifier_seq with
Felix> qualifier_seq_noopt.
This seems fine to me. Thanks again.
Tom
next prev parent reply other threads:[~2021-04-01 18:20 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-26 14:26 [PATCH 0/2] Expression parser fixes for address space qualifiers Felix Willgerodt
2021-03-26 14:26 ` [PATCH 1/2] gdb: Allow address space qualifier parsing in C++ Felix Willgerodt
2021-04-01 18:16 ` Tom Tromey
2021-04-02 12:33 ` Willgerodt, Felix
2021-04-02 12:47 ` Luis Machado
2021-04-02 16:48 ` Simon Marchi
2021-04-02 16:51 ` Simon Marchi
2021-04-05 2:32 ` Simon Marchi
2021-04-06 9:30 ` Willgerodt, Felix
2021-03-26 14:26 ` [PATCH 2/2] gdb: Fix reduce/reduce conflicts for qualifier_seq_noopt in the C parser Felix Willgerodt
2021-04-01 18:20 ` Tom Tromey [this message]
2021-04-02 12:33 ` Willgerodt, Felix
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=874kgpooib.fsf@tromey.com \
--to=tom@tromey.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).