From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gateway20.websitewelcome.com (gateway20.websitewelcome.com [192.185.64.36]) by sourceware.org (Postfix) with ESMTPS id 96C8B386F009 for ; Fri, 5 Feb 2021 15:42:48 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 96C8B386F009 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=fail smtp.mailfrom=tom@tromey.com Received: from cm11.websitewelcome.com (cm11.websitewelcome.com [100.42.49.5]) by gateway20.websitewelcome.com (Postfix) with ESMTP id AF24B400F7551 for ; Fri, 5 Feb 2021 09:35:30 -0600 (CST) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id 83FslY60HSrGM83FslBeyG; Fri, 05 Feb 2021 09:42:44 -0600 X-Authority-Reason: nr=8 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=eMjDtYdkBCMguWROLYjbS1LhfOYGC5cTcw/Xd2sDLTY=; b=OG5ngbcLchkV4twGKox3w6RTaf HPt/diCXWmRVTRX3tk1Ajyh9cZzOX2IbhNX9W8WaPDYiuAg4dZvrc2JyNYHgU55/bdFa6UmYQEPLu gyg7pE1uWu+PoJSJxZzxJf/Y+; Received: from 97-122-91-54.hlrn.qwest.net ([97.122.91.54]:42284 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.93) (envelope-from ) id 1l83Fr-003AYA-Uu; Fri, 05 Feb 2021 08:42:44 -0700 From: Tom Tromey To: Weimin Pan via Gdb-patches Cc: Weimin Pan Subject: Re: [PATCH 3/5] CTF: handle forward reference type References: <1612230528-25905-1-git-send-email-weimin.pan@oracle.com> <1612230528-25905-2-git-send-email-weimin.pan@oracle.com> <1612230528-25905-3-git-send-email-weimin.pan@oracle.com> <1612230528-25905-4-git-send-email-weimin.pan@oracle.com> X-Attribution: Tom Date: Fri, 05 Feb 2021 08:42:43 -0700 In-Reply-To: <1612230528-25905-4-git-send-email-weimin.pan@oracle.com> (Weimin Pan via Gdb-patches's message of "Mon, 1 Feb 2021 20:48:46 -0500") Message-ID: <874kiq5xn0.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 97.122.91.54 X-Source-L: No X-Exim-ID: 1l83Fr-003AYA-Uu X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 97-122-91-54.hlrn.qwest.net (murgatroyd) [97.122.91.54]:42284 X-Source-Auth: tom+tromey.com X-Email-Count: 11 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-Spam-Status: No, score=-3029.3 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, JMQ_SPF_NEUTRAL, RCVD_IN_DNSWL_NONE, SPF_HELO_PASS, SPF_NEUTRAL, TXREP autolearn=no autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 05 Feb 2021 15:42:49 -0000 >>>>> "Weimin" == Weimin Pan via Gdb-patches writes: Weimin> Added function fetch_tid_type which calls get_tid_type and will set up Weimin> the type, associated with a tid, if it is not read in yet. Also implement Weimin> function read_forward_type which handles the CTF_K_FORWARD kind. Weimin> Expanded gdb.base/ctf-ptype.exp to add cases with forward references. I don't really know the CTF code, but I didn't see any problems from a generic gdb point of view. Weimin> + gdb::unique_xmalloc_ptr name (ctf_type_aname_raw (fp, tid)); Weimin> + if (name != NULL && strlen (name.get() ) != 0) Weimin> + type->set_name (obstack_strdup (&of->objfile_obstack, name.get ())); If CTF is address-space-independent (suspect so) you may wish to consider changing it someday to store the psymbols on the per-BFD object. This would speed up some multi-inferior scenarios. Tom