Re: [PATCH 1/2] guile: Add support for Guile 2.2.

["Ludovic Courtès" <ludo@gnu.org>]

Hello,

Eli Zaretskii <eliz@gnu.org> skribis:

>> From: Ludovic Courtès <ludo@gnu.org>
>> Date: Fri, 12 Jun 2020 15:27:09 +0200
>> Cc: Ludovic Courtès <ludo@gnu.org>
>> 
>> This primarily updates code that uses the I/O port API of Guile.
>> 
>> 	* doc/guile.texi (Memory Ports in Guile): Remove
>> 	documentation of 'memory-port-read-buffer-size',
>> 	'set-memory-port-read-buffer-size!',
>> 	'memory-port-write-buffer-size',
>> 	'set-memory-port-read-buffer-size!', which are no longer
>> 	supported with Guile 2.2/3.0 and superseded by 'setvbuf'.
>> 	* doc/guile.texi (Guile Introduction): Clarify which Guile
>> 	versions are supported.
>
> gdb/doc/ has a separate ChangeLog file; please use that to describe
> changes in the manual.

Oops, will do.

> More importantly, I don't understand why we'd want to remove the
> documentation of these functions.  Are we removing the functions as
> well (I don't think I saw the code being removed)?  If we are not
> removing the functions, why remove their docs?  You say that the
> corresponding Guile functionality is superseded by setvbuf, but
> doesn't it mean the GDB-specific capability based on that will be
> rewritten using the new Guile features, and we can continue supporting
> them?

These four functions are not used in tests, in documented examples, nor
in Guile’s own GDB plugin.

‘setvbuf’ is not entirely a drop-in replacement because: (1) it doesn’t
allow you to query a port’s buffer size, only to change it, and (2) it
doesn’t distinguish between the read and write buffers.  Consequently,
these functions cannot be implemented on 2.2/3.0, or at least not
easily.

Since they are unused, and I can’t see a valid use case for those over
‘setvbuf’, I chose to remove them from the manual as a way to deprecate
them.

WDYT?

> Also, does any of this need to be called out in NEWS?

Oh sure.  Should that go in a separate commit or in the same?

I’ll wait for additional feedback and send a v2 afterwards, if that’s
fine with you.

Thanks for the quick reply,
Ludo’.

PS: I lost Git access to sourceware.org some years ago because my
    registered SSH key was DSA, IIRC.  Should I apply to restore it?
    What’s the procedure?