From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from eggs.gnu.org (eggs.gnu.org [IPv6:2001:470:142:3::10]) by sourceware.org (Postfix) with ESMTPS id 643F1395A825 for ; Fri, 12 Jun 2020 14:04:32 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 643F1395A825 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=gnu.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=ludo@gnu.org Received: from fencepost.gnu.org ([2001:470:142:3::e]:36248) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jjkII-0000yt-PP for gdb-patches@sourceware.org; Fri, 12 Jun 2020 10:04:31 -0400 Received: from [2a01:e0a:1d:7270:6a6c:dc17:fc02:cfda] (port=54374 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1jjkID-0001hp-Bl; Fri, 12 Jun 2020 10:04:29 -0400 From: =?utf-8?Q?Ludovic_Court=C3=A8s?= To: Eli Zaretskii Cc: gdb-patches@sourceware.org Subject: Re: [PATCH 1/2] guile: Add support for Guile 2.2. References: <20200612132710.14364-1-ludo@gnu.org> <20200612132710.14364-2-ludo@gnu.org> <83sgf04clq.fsf@gnu.org> X-URL: http://www.fdn.fr/~lcourtes/ X-Revolutionary-Date: 25 Prairial an 228 de la =?utf-8?Q?R=C3=A9volution?= X-PGP-Key-ID: 0x090B11993D9AEBB5 X-PGP-Key: http://www.fdn.fr/~lcourtes/ludovic.asc X-PGP-Fingerprint: 3CE4 6455 8A84 FDC6 9DB4 0CFB 090B 1199 3D9A EBB5 X-OS: x86_64-pc-linux-gnu Date: Fri, 12 Jun 2020 16:04:22 +0200 In-Reply-To: <83sgf04clq.fsf@gnu.org> (Eli Zaretskii's message of "Fri, 12 Jun 2020 16:50:41 +0300") Message-ID: <874krg8jo9.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-4.7 required=5.0 tests=BAYES_00, KAM_DMARC_STATUS, RCVD_IN_DNSWL_LOW, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 12 Jun 2020 14:04:33 -0000 Hello, Eli Zaretskii skribis: >> From: Ludovic Court=C3=A8s >> Date: Fri, 12 Jun 2020 15:27:09 +0200 >> Cc: Ludovic Court=C3=A8s >>=20 >> This primarily updates code that uses the I/O port API of Guile. >>=20 >> * doc/guile.texi (Memory Ports in Guile): Remove >> documentation of 'memory-port-read-buffer-size', >> 'set-memory-port-read-buffer-size!', >> 'memory-port-write-buffer-size', >> 'set-memory-port-read-buffer-size!', which are no longer >> supported with Guile 2.2/3.0 and superseded by 'setvbuf'. >> * doc/guile.texi (Guile Introduction): Clarify which Guile >> versions are supported. > > gdb/doc/ has a separate ChangeLog file; please use that to describe > changes in the manual. Oops, will do. > More importantly, I don't understand why we'd want to remove the > documentation of these functions. Are we removing the functions as > well (I don't think I saw the code being removed)? If we are not > removing the functions, why remove their docs? You say that the > corresponding Guile functionality is superseded by setvbuf, but > doesn't it mean the GDB-specific capability based on that will be > rewritten using the new Guile features, and we can continue supporting > them? These four functions are not used in tests, in documented examples, nor in Guile=E2=80=99s own GDB plugin. =E2=80=98setvbuf=E2=80=99 is not entirely a drop-in replacement because: (1= ) it doesn=E2=80=99t allow you to query a port=E2=80=99s buffer size, only to change it, and (2)= it doesn=E2=80=99t distinguish between the read and write buffers. Consequent= ly, these functions cannot be implemented on 2.2/3.0, or at least not easily. Since they are unused, and I can=E2=80=99t see a valid use case for those o= ver =E2=80=98setvbuf=E2=80=99, I chose to remove them from the manual as a way = to deprecate them. WDYT? > Also, does any of this need to be called out in NEWS? Oh sure. Should that go in a separate commit or in the same? I=E2=80=99ll wait for additional feedback and send a v2 afterwards, if that= =E2=80=99s fine with you. Thanks for the quick reply, Ludo=E2=80=99. PS: I lost Git access to sourceware.org some years ago because my registered SSH key was DSA, IIRC. Should I apply to restore it? What=E2=80=99s the procedure?