From: Tom Tromey <tom@tromey.com>
To: Philippe Waroquiers via Gdb-patches <gdb-patches@sourceware.org>
Subject: Re: [RFA 04/10] command-def-selftests.c: detect missing or wrong prefix cmd in subcommands.
Date: Thu, 14 May 2020 09:54:58 -0600 [thread overview]
Message-ID: <874ksi3419.fsf@tromey.com> (raw)
In-Reply-To: <20200510205530.21923-5-philippe.waroquiers@skynet.be> (Philippe Waroquiers via Gdb-patches's message of "Sun, 10 May 2020 22:55:24 +0200")
>>>>> "Philippe" == Philippe Waroquiers via Gdb-patches <gdb-patches@sourceware.org> writes:
Thank you for the patch.
Philippe> This test reveals a number of problems fixed in the next commit.
It's best (IME) to develop in this order, but then to either combine the
test and the fix, or to put the fix before the test when submitting.
The reason for this is that it helps avoid failures when bisecting.
Philippe> + SELF_CHECK (nr_invalid_prefixcmd == 0);
This code should reset nr_invalid_prefixcmd as well.
Tom
next prev parent reply other threads:[~2020-05-14 15:55 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-10 20:55 [RFA 00/10] fix/improve cmd structure, class_alias, help, apropos Philippe Waroquiers
2020-05-10 20:55 ` [RFA 01/10] Add a selftest that detects a 'corrupted' command tree structure in GDB Philippe Waroquiers
2020-05-14 15:51 ` Tom Tromey
2020-05-10 20:55 ` [RFA 02/10] Fix the only incorrect case found by command_structure_invariants selftest Philippe Waroquiers
2020-05-14 15:52 ` Tom Tromey
2020-05-10 20:55 ` [RFA 03/10] Fix problem that alias can be defined or not depending on the order Philippe Waroquiers
2020-05-14 16:00 ` Tom Tromey
2020-05-10 20:55 ` [RFA 04/10] command-def-selftests.c: detect missing or wrong prefix cmd in subcommands Philippe Waroquiers
2020-05-14 15:54 ` Tom Tromey [this message]
2020-05-10 20:55 ` [RFA 05/10] Fix the problems reported by prefix check of command-def-selftests.c Philippe Waroquiers
2020-05-14 16:07 ` Tom Tromey
2020-05-10 20:55 ` [RFA 06/10] Fix inconsistent output of prefix and bugs in 'show' command Philippe Waroquiers
2020-05-14 16:16 ` Tom Tromey
2020-05-10 20:55 ` [RFA 07/10] Fix/improve 'help CLASS' output Philippe Waroquiers
2020-05-14 16:26 ` Tom Tromey
2020-05-10 20:55 ` [RFA 08/10] Fix/improve 'apropos' output Philippe Waroquiers
2020-05-14 16:30 ` Tom Tromey
2020-05-10 20:55 ` [RFA 09/10] Ensure class_alias is only used for user-defined aliases Philippe Waroquiers
2020-05-14 17:33 ` Tom Tromey
2020-05-14 21:12 ` Philippe Waroquiers
2020-05-10 20:55 ` [RFA 10/10] Update NEWS and documentation for help and apropos changes Philippe Waroquiers
2020-05-11 14:34 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=874ksi3419.fsf@tromey.com \
--to=tom@tromey.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).