From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gateway36.websitewelcome.com (gateway36.websitewelcome.com [192.185.187.5]) by sourceware.org (Postfix) with ESMTPS id 39D10396DC1A for ; Thu, 14 May 2020 15:55:00 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 39D10396DC1A Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=fail smtp.mailfrom=tom@tromey.com Received: from cm13.websitewelcome.com (cm13.websitewelcome.com [100.42.49.6]) by gateway36.websitewelcome.com (Postfix) with ESMTP id 5DA00401F8F43 for ; Thu, 14 May 2020 10:14:10 -0500 (CDT) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id ZGCJjrdJqVQh0ZGCJjwFzH; Thu, 14 May 2020 10:54:59 -0500 X-Authority-Reason: nr=8 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=OGuDdgQQB3VA+DvA8UpfzyQa9q87J9BGKZhYN4BdrWw=; b=m4S1cUrF8xmss0e1VuxyPI4IMv 0IpUyXg0XlN5ov2Iquv8z0cSWPShT2PgOXKv4KBsNQLm+XzHBKFvdIZwRMUzCBI2BWAvSSJ29qs3h 3KKxAug9PeKSrO2dytr05bZj6; Received: from 174-16-104-48.hlrn.qwest.net ([174.16.104.48]:36608 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.92) (envelope-from ) id 1jZGCJ-003QnP-IM; Thu, 14 May 2020 09:54:59 -0600 From: Tom Tromey To: Philippe Waroquiers via Gdb-patches Subject: Re: [RFA 04/10] command-def-selftests.c: detect missing or wrong prefix cmd in subcommands. References: <20200510205530.21923-1-philippe.waroquiers@skynet.be> <20200510205530.21923-5-philippe.waroquiers@skynet.be> X-Attribution: Tom Date: Thu, 14 May 2020 09:54:58 -0600 In-Reply-To: <20200510205530.21923-5-philippe.waroquiers@skynet.be> (Philippe Waroquiers via Gdb-patches's message of "Sun, 10 May 2020 22:55:24 +0200") Message-ID: <874ksi3419.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 174.16.104.48 X-Source-L: No X-Exim-ID: 1jZGCJ-003QnP-IM X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 174-16-104-48.hlrn.qwest.net (murgatroyd) [174.16.104.48]:36608 X-Source-Auth: tom+tromey.com X-Email-Count: 7 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-Spam-Status: No, score=-1.4 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, JMQ_SPF_NEUTRAL, RCVD_IN_BARRACUDACENTRAL, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, SPF_HELO_PASS, SPF_NEUTRAL, TXREP autolearn=no autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 14 May 2020 15:55:10 -0000 >>>>> "Philippe" == Philippe Waroquiers via Gdb-patches writes: Thank you for the patch. Philippe> This test reveals a number of problems fixed in the next commit. It's best (IME) to develop in this order, but then to either combine the test and the fix, or to put the fix before the test when submitting. The reason for this is that it helps avoid failures when bisecting. Philippe> + SELF_CHECK (nr_invalid_prefixcmd == 0); This code should reset nr_invalid_prefixcmd as well. Tom