From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gateway33.websitewelcome.com (gateway33.websitewelcome.com [192.185.145.9]) by sourceware.org (Postfix) with ESMTPS id DA7B039450D5 for ; Wed, 11 Mar 2020 18:05:53 +0000 (GMT) Received: from cm13.websitewelcome.com (cm13.websitewelcome.com [100.42.49.6]) by gateway33.websitewelcome.com (Postfix) with ESMTP id 83E0B2B7CE for ; Wed, 11 Mar 2020 13:05:53 -0500 (CDT) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id C5jtjHAi3RP4zC5jtjdIHU; Wed, 11 Mar 2020 13:05:53 -0500 X-Authority-Reason: nr=8 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=5VQpkCgmVP16Ph0rGh81BtOkZvc98qarDO1KZhJjEos=; b=phYzivDRrHCKUTSx5wSRds/m/B 3olkd05+84O5W2/58ei5gYbJAYvxiGAxT6Dg1iGUPQyQ8TTm29B9jjzoGth6jnrdB96W2bIbro3CQ 99ph+9W9luuoIVtrkP6mG//C+; Received: from 184-96-250-69.hlrn.qwest.net ([184.96.250.69]:54192 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.92) (envelope-from ) id 1jC5jt-002I58-8W; Wed, 11 Mar 2020 12:05:53 -0600 From: Tom Tromey To: Simon Marchi Cc: Tom Tromey , gdb-patches@sourceware.org Subject: Re: [PATCH 20/24] Allow TUI windows in Python References: <20200104183410.17114-1-tom@tromey.com> <20200104183410.17114-21-tom@tromey.com> <4f60dcb3-1d6c-8660-12e0-fceea911bc10@simark.ca> <87zhcn68om.fsf@tromey.com> <8864df4e-a5fa-9c67-29c3-1a25887d0fce@simark.ca> X-Attribution: Tom Date: Wed, 11 Mar 2020 12:05:52 -0600 In-Reply-To: <8864df4e-a5fa-9c67-29c3-1a25887d0fce@simark.ca> (Simon Marchi's message of "Wed, 11 Mar 2020 00:47:51 -0400") Message-ID: <874kuuojgf.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 184.96.250.69 X-Source-L: No X-Exim-ID: 1jC5jt-002I58-8W X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 184-96-250-69.hlrn.qwest.net (murgatroyd) [184.96.250.69]:54192 X-Source-Auth: tom+tromey.com X-Email-Count: 6 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-Spam-Status: No, score=-1.1 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, RCVD_IN_DNSWL_NONE, SPF_HELO_PASS, SPF_NEUTRAL autolearn=no autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 11 Mar 2020 18:05:54 -0000 >>>>> "Simon" == Simon Marchi writes: Simon> This file tells us Python was built with ncurses, which doesn't mean the Simon> ncurses development headers are installed and available to GDB. I find it Simon> very odd that Python exposes these very generically-named macros in the global Simon> namespace. Almost any of these HAVE_FOO macros from Python could clash with Simon> our own macros. Yes, it's a bad practice. Unfortunately autoconf never really provided an easy-enough way to do the right thing here, so I think plenty of packages have bad hygiene this way. Simon> One way to fix it is to make sure "python-internal.h" is included after Simon> "gdb_curses.h", in py-tui.c. Feel free to put that in, I guess with a comment. Another option might be to check whether HAVE_NCURSES_H is undefined before including the Python headers, but defined afterward and #error in this case. That way we could perhaps give a less confusing error message. Tom