From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 112184 invoked by alias); 4 Oct 2019 22:08:49 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 112174 invoked by uid 89); 4 Oct 2019 22:08:49 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-8.8 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS autolearn=ham version=3.3.1 spammy=timer X-HELO: gateway33.websitewelcome.com Received: from gateway33.websitewelcome.com (HELO gateway33.websitewelcome.com) (192.185.145.87) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 04 Oct 2019 22:08:48 +0000 Received: from cm10.websitewelcome.com (cm10.websitewelcome.com [100.42.49.4]) by gateway33.websitewelcome.com (Postfix) with ESMTP id F05398673BB for ; Fri, 4 Oct 2019 17:08:45 -0500 (CDT) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id GVkjiG2ASHunhGVkjixAmh; Fri, 04 Oct 2019 17:08:45 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=D1xpAQYB5aaNJx2b3z4tgufvi7rGs6uvWtiKc5/yWyA=; b=yotgPSSC41mUBGN02goMySTQ7G Pp21BvCTbz8qRHizDX9oLqboS0p2AFaEq+W+GADcTGEP9nhkyUHKyilnWq818YGcvkhsdUsqiks1u /cvezVr0m5d8HTmpiZq4u5LAh; Received: from 75-166-72-156.hlrn.qwest.net ([75.166.72.156]:43496 helo=bapiya) by box5379.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.92) (envelope-from ) id 1iGVkj-000rIp-LB; Fri, 04 Oct 2019 16:08:45 -0600 From: Tom Tromey To: Pedro Alves Cc: Tom Tromey , gdb-patches@sourceware.org Subject: Re: [RFC 17/17] Simplify gdbserver's serial event handling References: <20190224165153.5062-1-tom@tromey.com> <20190224165153.5062-18-tom@tromey.com> Date: Fri, 04 Oct 2019 22:08:00 -0000 In-Reply-To: (Pedro Alves's message of "Thu, 26 Sep 2019 18:36:36 +0100") Message-ID: <874l0orwnq.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1.91 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SW-Source: 2019-10/txt/msg00160.txt.bz2 >>>>> "Pedro" == Pedro Alves writes: Pedro> On 2/24/19 4:51 PM, Tom Tromey wrote: >> Currently, when gdbserver handles a serial event, it also calls >> 'reschedule' to install a timer that is then used to process any data >> that remains after the previous packet was processed. >> >> It seemed better to me to simply have the file descriptor callback >> loop, processing packets until complete. Pedro> I would rather not do this change, because it potentially starves other Pedro> event sources. I've had to fix starvation issues like that in several Pedro> places in gdb throughout the years -- see url I pointed that justifying Pedro> need for async serial events, random_pending_event_thread in Pedro> infrun.c, etc. I have dropped it. Tom