From: Tom Tromey <tromey@redhat.com>
To: Joel Brobecker <brobecker@adacore.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH] constify to_attach
Date: Wed, 21 May 2014 21:36:00 -0000 [thread overview]
Message-ID: <874n0ihl1c.fsf@fleche.redhat.com> (raw)
In-Reply-To: <20140521212227.GN22822@adacore.com> (Joel Brobecker's message of "Wed, 21 May 2014 14:22:27 -0700")
Joel> For this sort of search, it would be helpful to have a convention
Joel> that we either use var->method to set the field, or else put the name
Joel> of the field in comment next to the assignment like we do with
Joel> the language vector. That really makes it easier to find them;
Joel> otherwise, one has to use code analyzers, which sometimes don't
Joel> work when you can't compile the file first.
Yeah. C99 designated initializers are really nice for this reason.
Tom
next prev parent reply other threads:[~2014-05-21 21:36 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-21 18:21 Tom Tromey
2014-05-21 18:58 ` Tom Tromey
2014-05-21 21:22 ` Joel Brobecker
2014-05-21 21:36 ` Tom Tromey [this message]
2014-05-21 22:05 ` Joel Brobecker
2014-05-21 22:55 ` Tom Tromey
2014-05-21 19:45 ` Pedro Alves
2014-06-04 17:09 ` Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=874n0ihl1c.fsf@fleche.redhat.com \
--to=tromey@redhat.com \
--cc=brobecker@adacore.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).