From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 29333 invoked by alias); 21 May 2014 21:36:05 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 29323 invoked by uid 89); 21 May 2014 21:36:04 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-3.2 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 21 May 2014 21:36:03 +0000 Received: from int-mx14.intmail.prod.int.phx2.redhat.com (int-mx14.intmail.prod.int.phx2.redhat.com [10.5.11.27]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s4LLa0uV026779 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 21 May 2014 17:36:01 -0400 Received: from barimba (ovpn-113-182.phx2.redhat.com [10.3.113.182]) by int-mx14.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id s4LLZx8i031570 (version=TLSv1/SSLv3 cipher=AES128-GCM-SHA256 bits=128 verify=NO); Wed, 21 May 2014 17:36:00 -0400 From: Tom Tromey To: Joel Brobecker Cc: gdb-patches@sourceware.org Subject: Re: [PATCH] constify to_attach References: <1400696455-29563-1-git-send-email-tromey@redhat.com> <87mwebhsc2.fsf@fleche.redhat.com> <20140521212227.GN22822@adacore.com> Date: Wed, 21 May 2014 21:36:00 -0000 In-Reply-To: <20140521212227.GN22822@adacore.com> (Joel Brobecker's message of "Wed, 21 May 2014 14:22:27 -0700") Message-ID: <874n0ihl1c.fsf@fleche.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SW-Source: 2014-05/txt/msg00519.txt.bz2 Joel> For this sort of search, it would be helpful to have a convention Joel> that we either use var->method to set the field, or else put the name Joel> of the field in comment next to the assignment like we do with Joel> the language vector. That really makes it easier to find them; Joel> otherwise, one has to use code analyzers, which sometimes don't Joel> work when you can't compile the file first. Yeah. C99 designated initializers are really nice for this reason. Tom