From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 1272 invoked by alias); 5 Aug 2013 14:06:37 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 1255 invoked by uid 89); 5 Aug 2013 14:06:36 -0000 X-Spam-SWARE-Status: No, score=-5.2 required=5.0 tests=AWL,BAYES_00,RCVD_IN_HOSTKARMA_W,RCVD_IN_HOSTKARMA_WL,RDNS_NONE,SPF_HELO_PASS,SPF_PASS autolearn=no version=3.3.1 Received: from Unknown (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.84/v0.84-167-ge50287c) with ESMTP; Mon, 05 Aug 2013 14:06:36 +0000 Received: from int-mx12.intmail.prod.int.phx2.redhat.com (int-mx12.intmail.prod.int.phx2.redhat.com [10.5.11.25]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r75E6Qto025019 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Mon, 5 Aug 2013 10:06:27 -0400 Received: from barimba (ovpn-113-128.phx2.redhat.com [10.3.113.128]) by int-mx12.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id r75E6PRq011015 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NO); Mon, 5 Aug 2013 10:06:25 -0400 From: Tom Tromey To: Yao Qi Cc: Subject: Re: [PATCH] Set entryval_error to NULL if entryval is set References: <1375690566-7417-1-git-send-email-yao@codesourcery.com> Date: Mon, 05 Aug 2013 14:06:00 -0000 In-Reply-To: <1375690566-7417-1-git-send-email-yao@codesourcery.com> (Yao Qi's message of "Mon, 5 Aug 2013 16:16:06 +0800") Message-ID: <874nb4b5b3.fsf@fleche.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SW-Source: 2013-08/txt/msg00139.txt.bz2 >>>>> "Yao" == Yao Qi writes: Yao> 2013-08-05 Yao Qi Yao> * stack.c (read_frame_arg): Set 'entryval_error' to NULL if Yao> 'entryval' is set. Yao> 2013-08-05 Yao Qi Yao> * gdb.trace/collection.exp (gdb_collect_args_test): Set Yao> "only" and "both" to 'print entry-values' before selecting Yao> trace frame. The bug fix part looks ok to me, but I think you need a special test case in order to really test entry values. Or to put it another way, what happens if this test is run with a compiler that doesn't emit entry value information? Tom