From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from omta038.useast.a.cloudfilter.net (omta038.useast.a.cloudfilter.net [44.202.169.37]) by sourceware.org (Postfix) with ESMTPS id E88833858422 for ; Fri, 23 Feb 2024 01:39:15 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org E88833858422 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org E88833858422 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=44.202.169.37 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1708652359; cv=none; b=rBjACeoWXmLwFOvsd3Shi3lILVyA+ZATTfykOkUUSBFH6c4qXZVV9ObEqQsYyPkzdd7VxCsEIIzeiOkB22ux81F7gGv6eECWzOG7MhUMD4IUuhBMqHpeF9Q1+xbUBNXFuKhsYTV3tdOiW/6tnQP7bcG0alYBdUtTmv1pE6nJdME= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1708652359; c=relaxed/simple; bh=Vn9jr4K0myGXt5tzZol1ikM8nc35uIK21wDB2aYIdvM=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=lohyEVEYhD5uSHnqOtCKFkMFnStoi48mlcRz4nUP/XKKNY2O8+NGtXz+Ohn9ZZzFIVth90D9i0gmuUtw2giUZMuPl2YFX1vV+O3xKR2bge1OWa0EDLfMzhBVBwXihxjhxBu95PqOD012ddnubo6KF4Bpnqusfj0WjVFsUxNrb+c= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from eig-obgw-5007a.ext.cloudfilter.net ([10.0.29.141]) by cmsmtp with ESMTPS id dEolrWRen9gG6dKWwrzgty; Fri, 23 Feb 2024 01:39:14 +0000 Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with ESMTPS id dKWvrAtQTbV6YdKWwryvrA; Fri, 23 Feb 2024 01:39:14 +0000 X-Authority-Analysis: v=2.4 cv=BZ7e0Kt2 c=1 sm=1 tr=0 ts=65d7f742 a=ApxJNpeYhEAb1aAlGBBbmA==:117 a=ApxJNpeYhEAb1aAlGBBbmA==:17 a=k7vzHIieQBIA:10 a=Qbun_eYptAEA:10 a=SG1ZB3sHjho3LxTiXr8A:9 a=QYH75iMubAgA:10 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date:References :Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=+hV0rZFht403/Lj761pDRSsdaI2IvcWYlmW5KwspHec=; b=NwHgwEgwGSeImI8Q6CZssN2qCU r/Q5XAyQGgTxsv3v7qBhbpxTHERzdSdPlIpm5gUynAunDr6ct3jF0bluccbMc9vzk5CIBhtOhYoq7 95yX03AlzAtZtaODyfde4b0MG; Received: from 71-211-170-195.hlrn.qwest.net ([71.211.170.195]:36716 helo=prentzel) by box5379.bluehost.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96.2) (envelope-from ) id 1rdKWv-004BvE-1L; Thu, 22 Feb 2024 18:39:13 -0700 From: Tom Tromey To: Tom de Vries Cc: Tom Tromey , Simon Marchi , gdb-patches@sourceware.org Subject: Re: [PATCH] [gdb/tui] Factor out tui_noscroll_window et al References: <20231112150601.25484-1-tdevries@suse.de> <87r0kttwba.fsf@tromey.com> <24af4ea8-5426-4ce4-b1c5-12858b38a952@simark.ca> <549c2044-4ec2-4072-a554-6a66e7ddee1d@suse.de> <668e8103-04e8-4ae1-934a-e64f6fd4dc40@suse.de> <87h6i0zgf3.fsf@tromey.com> <115c705a-978c-4855-84cc-2b8aa8fda113@suse.de> X-Attribution: Tom Date: Thu, 22 Feb 2024 18:39:12 -0700 In-Reply-To: <115c705a-978c-4855-84cc-2b8aa8fda113@suse.de> (Tom de Vries's message of "Thu, 22 Feb 2024 16:26:49 +0100") Message-ID: <875xygc62n.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 71.211.170.195 X-Source-L: No X-Exim-ID: 1rdKWv-004BvE-1L X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 71-211-170-195.hlrn.qwest.net (prentzel) [71.211.170.195]:36716 X-Source-Auth: tom+tromey.com X-Email-Count: 6 X-Org: HG=bhshared;ORG=bluehost; X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-CMAE-Envelope: MS4xfNm8WLKvnKHp+p65mpBysUQFkzYSvHBJZXkxg5oUMluyEHIjNg4tuGw6vgpeIhsAdQ56Gahc9Yz41I6aHZFlcnxt+eV/8Eui4Qq/MS0DgzSpeDTYpWC0 4fvtHcVhO6BOJX2LQIhuX9OZZ4wZg4nsHGUYBrE0z3coeKp3Dd9gCj+Rle8D4C7aWvkDHCmmcKw2INUa+GtujQVwiMrUFZ+M4k4= X-Spam-Status: No, score=-3016.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,JMQ_SPF_NEUTRAL,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Tom> Sorry, you're right. I see I confused virtual base with abstract base. No worries, IMO it's a confusing term since 'virtual' also means something more normal for methods. It probably would be somewhat more future-proof to just use dynamic_cast in all of these macros. Old-school OO programming would say all these casts are bad and we should instead work toward expressing these requirements via new methods. Tom