From: Tom Tromey <tom@tromey.com>
To: Simon Marchi <simon.marchi@efficios.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH 2/2] gdb: use put_frame_register instead of put_frame_register_bytes in pseudo_to_concat_raw
Date: Tue, 19 Dec 2023 08:06:25 -0700 [thread overview]
Message-ID: <875y0u44ge.fsf@tromey.com> (raw)
In-Reply-To: <20231218200256.28489-2-simon.marchi@efficios.com> (Simon Marchi's message of "Mon, 18 Dec 2023 15:02:47 -0500")
>>>>> "Simon" == Simon Marchi <simon.marchi@efficios.com> writes:
Simon> Here, we write single complete registers, we don't need the
Simon> functionality of put_frame_register_bytes, use put_frame_register
Simon> instead.
FWIW this makes sense to me.
Approved-By: Tom Tromey <tom@tromey.com>
Tom
next prev parent reply other threads:[~2023-12-19 15:06 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-18 20:02 [PATCH 1/2] gdb: remove stale comment in value_assign Simon Marchi
2023-12-18 20:02 ` [PATCH 2/2] gdb: use put_frame_register instead of put_frame_register_bytes in pseudo_to_concat_raw Simon Marchi
2023-12-19 15:06 ` Tom Tromey [this message]
2023-12-19 16:12 ` Simon Marchi
2023-12-19 15:05 ` [PATCH 1/2] gdb: remove stale comment in value_assign Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=875y0u44ge.fsf@tromey.com \
--to=tom@tromey.com \
--cc=gdb-patches@sourceware.org \
--cc=simon.marchi@efficios.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).