From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from omta36.uswest2.a.cloudfilter.net (omta36.uswest2.a.cloudfilter.net [35.89.44.35]) by sourceware.org (Postfix) with ESMTPS id C3DB23858298 for ; Mon, 18 Dec 2023 23:33:08 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org C3DB23858298 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org C3DB23858298 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=35.89.44.35 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1702942399; cv=none; b=r4MR73PW/NMQa9G80j7lzYWR4GhkFluoWXwbZ/CeTgMld2FGTYR0f7Mmaa6cO8BIKKdceu7VywvHkFRNOmo4MBmZEqWVYFFpd0SmX6oEwakjh5rd6aTEtX6BFakdqBOY2qkmpUxUPfEk3nHKxEraeRiXQMfwqZlzVfroGv+KPaM= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1702942399; c=relaxed/simple; bh=hs8ETX66PRQwgA0SA2xnwDtwxc5gevleCk+8/zng/lA=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=b1fdy9W2a7u1qUvce0tRAxi2RrrMwdAL+6OeGTQIQ49ET98eYv7EZf9mFil4QkcCdXjLd2Slrd9tkEjo65CG2zYfuoaGHYyExR0wpOmXCcjWe73iqMjWUXv+1/+OXvsPxuBaUiFie32Ln5hlN9k8t3uns7hKPNs7EFVZwygserA= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from eig-obgw-5003a.ext.cloudfilter.net ([10.0.29.159]) by cmsmtp with ESMTPS id FHuPrt7kohqFdFN6hreb2n; Mon, 18 Dec 2023 23:33:07 +0000 Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with ESMTPS id FN6grfS67nCfvFN6hrfB82; Mon, 18 Dec 2023 23:33:07 +0000 X-Authority-Analysis: v=2.4 cv=KKpJsXJo c=1 sm=1 tr=0 ts=6580d6b3 a=ApxJNpeYhEAb1aAlGBBbmA==:117 a=ApxJNpeYhEAb1aAlGBBbmA==:17 a=OWjo9vPv0XrRhIrVQ50Ab3nP57M=:19 a=dLZJa+xiwSxG16/P+YVxDGlgEgI=:19 a=e2cXIFwxEfEA:10 a=Qbun_eYptAEA:10 a=20KFwNOVAAAA:8 a=zstS-IiYAAAA:8 a=C5jP5dNwfI6aoKpG8LYA:9 a=S_HVFEA2qnQA:10 a=4G6NA9xxw8l3yy4pmD5M:22 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date:References :Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=5AHUXzTPpWj655DTH9Wx2H2ACl/RpdaFJIcEW6quTL8=; b=siJYoLg/3+8w7ymhc3Luz64mcw CcAqb1H7qha+7UQLREnXHiWcEY/warRNltEJY3/YRev2F8rEobsMi0J/+eiuVB1Wh1hrp8UOBdgMA PfNwg8du3S/Z+WyCgA1z5/WDZ; Received: from [161.98.8.3] (port=46586 helo=prentzel) by box5379.bluehost.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96.2) (envelope-from ) id 1rFN6g-0018HQ-11; Mon, 18 Dec 2023 16:33:06 -0700 From: Tom Tromey To: Andrew Burgess Cc: Tom Tromey , gdb-patches@sourceware.org Subject: Re: [PATCH 06/14] Move scrollok call in register window References: <20231217-tui-regs-cleanup-v1-0-67bd0ea1e8be@tromey.com> <20231217-tui-regs-cleanup-v1-6-67bd0ea1e8be@tromey.com> <874jgf1fap.fsf@redhat.com> X-Attribution: Tom Date: Mon, 18 Dec 2023 16:33:04 -0700 In-Reply-To: <874jgf1fap.fsf@redhat.com> (Andrew Burgess's message of "Mon, 18 Dec 2023 19:28:14 +0000") Message-ID: <875y0v5bnz.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 161.98.8.3 X-Source-L: No X-Exim-ID: 1rFN6g-0018HQ-11 X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: (prentzel) [161.98.8.3]:46586 X-Source-Auth: tom+tromey.com X-Email-Count: 2 X-Org: HG=bhshared;ORG=bluehost; X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-CMAE-Envelope: MS4xfFiki838Fks5chRtlG1CTLdLLMpcYY1uCfJgEaOHpYKDWViKnpXXP4CkStaoSwoF2kGEF/hACRJpojFJ5AlMk2loSDiM7uPrzbGyAwpnP0n4lA9k5fT5 qKrwhBdeYUkKIXYkO1OctBVGQPZW6xpMctn5a0iJ8xxSjRF+PBziZlB7B7WMHK+5OIYz0PTo2dBKv92/+QWCD6GWLpYEGWmWYe0= X-Spam-Status: No, score=-3016.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,JMQ_SPF_NEUTRAL,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: >>>>> "Andrew" == Andrew Burgess writes: Andrew> Tom Tromey writes: >> The register window calls scrollok each time a register is written to >> the window. However, we only need to call this once, at the start of >> display. (We could actually call it just once when the window is >> made, but that would involve making another method virtual Andrew> Did you consider overriding make_window in the tui_data_window class? Andrew> Like this: I did, but there aren't any other overrides of make_window, and it seems like a mistake that it is virtual at all. Tom