From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from omta034.useast.a.cloudfilter.net (omta034.useast.a.cloudfilter.net [44.202.169.33]) by sourceware.org (Postfix) with ESMTPS id 6FA093858C78 for ; Tue, 12 Dec 2023 20:21:25 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 6FA093858C78 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 6FA093858C78 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=44.202.169.33 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1702412486; cv=none; b=ND26z/8X1zgu+aFZ8QMcQVbWf1nHtHDRf1gTP0xqdhP3uqAlpqLFcRyopUgg0TaANx+Ql0pRWtN70kFh+zZHUiuHdK/hfazBhNQLqPIlEaak0EOQ/Mq779HgrVweluxzSv3b0e5Oc9D5aMp59to9PRQy2HeWsj8AsPF+GfR2q6c= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1702412486; c=relaxed/simple; bh=WpL93XuX+hDm05TvR+yVRAXNe2sUOyTuIhpDjeIaW9c=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=H30i9g7rZxLnXLDnEMZrQt5Rw0T395Pjrd54SHcbJUojytoMuM+ogSXYAEXqihCTJDplWPpq4Z6XyIFW5B4Tu0jPFfIf2U4wk7S52vxrSau4luXePFe4xAaL0sT4173vaYkpF7HlNJoCTe5moXJZr47i0N+jwjUp/cILt9f5rhE= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from eig-obgw-6010a.ext.cloudfilter.net ([10.0.30.248]) by cmsmtp with ESMTPS id D1NDrFV1UjtZ3D9G1ridnv; Tue, 12 Dec 2023 20:21:34 +0000 Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with ESMTPS id D9FsrLipJ8vT0D9FsrRNAw; Tue, 12 Dec 2023 20:21:25 +0000 X-Authority-Analysis: v=2.4 cv=ffi+dmcF c=1 sm=1 tr=0 ts=6578c0c5 a=ApxJNpeYhEAb1aAlGBBbmA==:117 a=ApxJNpeYhEAb1aAlGBBbmA==:17 a=OWjo9vPv0XrRhIrVQ50Ab3nP57M=:19 a=dLZJa+xiwSxG16/P+YVxDGlgEgI=:19 a=e2cXIFwxEfEA:10 a=Qbun_eYptAEA:10 a=20KFwNOVAAAA:8 a=zstS-IiYAAAA:8 a=zwqQLjBbvNxNuEi0DKAA:9 a=zZCYzV9kfG8A:10 a=4G6NA9xxw8l3yy4pmD5M:22 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date:References :Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=u59+zyWCM8uGna2Q5OM1kKJVWrOnU0QzmivPy7+rdO4=; b=LdUSxkBd9p3K1CRyTuJyb/wqGX qYSSfRqmxcgp2M5qaJ+7vgq1wjg/HPT7jj9DCWTuWFwjfaYSW1BX8wJdrn28wdUjUWZSvM+jy3olU 70u6StvCzjXfGa570bGq6NopB; Received: from 71-211-161-25.hlrn.qwest.net ([71.211.161.25]:59064 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96.2) (envelope-from ) id 1rD9Fs-002Vhe-0m; Tue, 12 Dec 2023 13:21:24 -0700 From: Tom Tromey To: Andrew Burgess Cc: gdb-patches@sourceware.org, Tom Tromey , Tom de Vries Subject: Re: [PATCHv3] gdb: improve error reporting for 'save gdb-index' References: <77f7dfc0615d0734db1a1bca2691170f6f7e5cfe.1702051454.git.aburgess@redhat.com> <66529240edc82ef99a43aff95817e0133649ae13.1702392863.git.aburgess@redhat.com> X-Attribution: Tom Date: Tue, 12 Dec 2023 13:21:23 -0700 In-Reply-To: <66529240edc82ef99a43aff95817e0133649ae13.1702392863.git.aburgess@redhat.com> (Andrew Burgess's message of "Tue, 12 Dec 2023 14:56:51 +0000") Message-ID: <875y13b29o.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 71.211.161.25 X-Source-L: No X-Exim-ID: 1rD9Fs-002Vhe-0m X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 71-211-161-25.hlrn.qwest.net (murgatroyd) [71.211.161.25]:59064 X-Source-Auth: tom+tromey.com X-Email-Count: 12 X-Org: HG=bhshared;ORG=bluehost; X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-CMAE-Envelope: MS4xfGHc03iu/IlS/RTSI3h7hq7GDgCDkbc8WjhSkHHIDH+G2ocqbL9GhKPc6Uhdw9jNVj56lbaYQBm3zV3mBlSf7qHK/iivOQFt35+DAjfd+n97ir9Jz1xA e3GdkzfeNlN+suGp77EXhLsqaKDno+HCxjgGCkaDTckkzvkuFVO3uwa98y9Y5lR4YXxd75aiEdczCQClxdknrtST+3ZiKa16V2A= X-Spam-Status: No, score=-3016.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,JMQ_SPF_NEUTRAL,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: >>>>> "Andrew" == Andrew Burgess writes: Andrew> Changes in V3: Andrew> - Have updated the existing have_index testsuite proc to call the Andrew> new get_index_type proc to avoid duplication that Tom (Tromey) Andrew> pointed out. Thank you. FWIW this looks good to me now. Approved-By: Tom Tromey Tom