From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from omta036.useast.a.cloudfilter.net (omta036.useast.a.cloudfilter.net [44.202.169.35]) by sourceware.org (Postfix) with ESMTPS id 1CABC3858C5F for ; Fri, 8 Dec 2023 16:26:26 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 1CABC3858C5F Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 1CABC3858C5F Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=44.202.169.35 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1702052787; cv=none; b=uP8GGSVTvspLGDnYWMTznliVBfvxfrtyjCwOJfiC4FCTRqqB6K31UoXs3GYfgL/ucyygle9G/jEWCjtsyI0rh4CPRmivD81iGAxupsckl4bBVaAnbOAkeMJKr6pp7rAuXTUX1urPNR+/8JCfFmrHTWCnpWEj2MFz8PKV+/cODUA= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1702052787; c=relaxed/simple; bh=xryUBS0RWuX+/u3WvxbaXqQiP2JPzKWnkgZb+Dj32o0=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=G7caDEXB9Sz58dgrqphwhrTNxA3qa4WTMU1pKhAc10qt2OUvPCxi4CsOXGvp5ekztNlX/5JIDZogXvl5jXcg7IQZyjt1ccRR911BhYvSnuG8WmbiDbejTHhz4VggLBtp6ue9E71Mr8mWh/vJfpWanbHPKZqSPdztB5EICiUdSvQ= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from eig-obgw-6001a.ext.cloudfilter.net ([10.0.30.140]) by cmsmtp with ESMTPS id BL4yrkp6jgpyEBdgHrwgxl; Fri, 08 Dec 2023 16:26:25 +0000 Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with ESMTPS id BdgHrknDzb8QnBdgHrFi0E; Fri, 08 Dec 2023 16:26:25 +0000 X-Authority-Analysis: v=2.4 cv=IuQNzZzg c=1 sm=1 tr=0 ts=657343b1 a=ApxJNpeYhEAb1aAlGBBbmA==:117 a=ApxJNpeYhEAb1aAlGBBbmA==:17 a=OWjo9vPv0XrRhIrVQ50Ab3nP57M=:19 a=dLZJa+xiwSxG16/P+YVxDGlgEgI=:19 a=e2cXIFwxEfEA:10 a=Qbun_eYptAEA:10 a=20KFwNOVAAAA:8 a=eCWU6RC9iueTDeBiB8IA:9 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date:References :Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=TWGLSB514crzBf9CTbq0KAymVfqT7t5UFELsVbsXg98=; b=ZZoj2clOFfcYGgSxzuUdve7RUC GYdS5y5GiqmjwVGUNpAFAr2wkK8Sci1HFXmQL8DvvXuEC9j3FlyKOpytHjFqoSaUYrWpa1d+tV7if lUH1IKOMcY9C8wV+UwV5v5t1m; Received: from 71-211-161-25.hlrn.qwest.net ([71.211.161.25]:58970 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96.2) (envelope-from ) id 1rBdgG-001Ln7-2U; Fri, 08 Dec 2023 09:26:24 -0700 From: Tom Tromey To: Andrew Burgess Cc: gdb-patches@sourceware.org, Tom de Vries Subject: Re: [PATCHv2] gdb: improve error reporting for 'save gdb-index' References: <3182b7a3eb3764cf62a8bbff1318808188fdf261.1701718143.git.aburgess@redhat.com> <77f7dfc0615d0734db1a1bca2691170f6f7e5cfe.1702051454.git.aburgess@redhat.com> X-Attribution: Tom Date: Fri, 08 Dec 2023 09:26:23 -0700 In-Reply-To: <77f7dfc0615d0734db1a1bca2691170f6f7e5cfe.1702051454.git.aburgess@redhat.com> (Andrew Burgess's message of "Fri, 8 Dec 2023 16:06:55 +0000") Message-ID: <875y18hd8w.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 71.211.161.25 X-Source-L: No X-Exim-ID: 1rBdgG-001Ln7-2U X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 71-211-161-25.hlrn.qwest.net (murgatroyd) [71.211.161.25]:58970 X-Source-Auth: tom+tromey.com X-Email-Count: 8 X-Org: HG=bhshared;ORG=bluehost; X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-CMAE-Envelope: MS4xfByT2m+phqi2UcODpSEyWysWnGRqbHhJqc940JQGbdL659DesI4f4ZUXRLLKNG57FbEozA8q36N3qVRp14Cyst7XtxwFaq55yKdyjmrjNlT2B4b2njx/ KOCTjbUD3t/TCNHkZtqyhgDCbipXsa3Ip6LO5erzsHmOnF/8mplJ6fOeRFIMsa+3UYG43HuaJ5AifNqoBh6jWz1d96ceF5PFRRc= X-Spam-Status: No, score=-3016.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,JMQ_SPF_NEUTRAL,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: >>>>> "Andrew" == Andrew Burgess writes: Andrew> --- a/gdb/testsuite/lib/gdb.exp Andrew> +++ b/gdb/testsuite/lib/gdb.exp Andrew> +proc get_index_type { objfile { testname "" } } { Andrew> + if { $testname eq "" } { Andrew> + set testname "find index type" Andrew> + } ... This seems to overlap with proc have_index. I wonder if they can be combined. Tom