From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id 539753857B80 for ; Tue, 28 Nov 2023 10:34:19 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 539753857B80 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 539753857B80 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=170.10.129.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1701167661; cv=none; b=SjzqAzybMm+bbgXeQfb8uiYU7CNSzxxmsjqh92RzN+W24nJk0fFN0IA5ZZMa5v4Llnoum6PSw32+D0k+i4uZMnDcUZTxVFng960HaK7nsHl1wiO8gl0QlgCQ9hMRU2AeTfLzB9cIdf+n8bjr0bJ6eLZVJAGkVcEdBE8ckwa06Xo= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1701167661; c=relaxed/simple; bh=AUzX6akAJSO9lUJ58/73QD1j0Xpe9wZQR/KI8rbb268=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=m0G8LA+iiw+57RCt2V+8OBQxGedxyPCjanHIp+nKM19jKq8ZCvduHg4YdBc2BS10Q+eGOethDaAlTevFuv9G1xI2u9KtXLldgaGijDzgeEoN5+YCvw0Kx/+GKMmqn1FplsDiiVHOVARNobwlb+Ff+moz5MHZQg9eVwQDmGFW3Nw= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1701167657; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Uxd7yjxamauuC/mkiuAjvLNb3kn7RO5shHj/LzlLBoE=; b=Za9yMziv5o+59Yg0LFkvzIgoRBSCOeU1+LHV/jbDuZ0Hun87hfAgZUzNrMfIl2HA+A6Nya X9AsdMIdKmzAi28TseaWsoWU0eEp+Bnj9eXDi5BS6PK48DRNQAER5ht8aJx7lY0x7n6L4t hYt79LnOz2WpB1B7kmCE5KObjU2gab8= Received: from mail-wr1-f70.google.com (mail-wr1-f70.google.com [209.85.221.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-253-DH_5g_BSN1isxTG_1pvVog-1; Tue, 28 Nov 2023 05:34:15 -0500 X-MC-Unique: DH_5g_BSN1isxTG_1pvVog-1 Received: by mail-wr1-f70.google.com with SMTP id ffacd0b85a97d-332e2e0b98bso3866590f8f.1 for ; Tue, 28 Nov 2023 02:34:14 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1701167653; x=1701772453; h=mime-version:message-id:date:references:in-reply-to:subject:cc:to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=Uxd7yjxamauuC/mkiuAjvLNb3kn7RO5shHj/LzlLBoE=; b=bvlgpo0F8xBinA2yotmImGSzVLfXP+ZQ3wvPQUXr+h97QLr+sizbl1mtNhT5ZFLZCG WGt4pbpSa00TIaZgWd/2XAiDDdeRCiYzgedI4lY1XVbX6deeF3vYd+1NwGyh/+1AtKbk LopbgZn3Bs0Rt7gKbmNjkgs19WXOyTIoWYt2JpAB0e8vF8Vo7K1fB7fjB5RThFSvskYW w2UzJT252vHfvSvjms4aTNraQwafyTg0MZ98T+kLA/gXPK5oPsxKoT22ho0TPB4S70U5 iABQqUgxraY8U3qfryZOhuagBKiihygJYkY0+fJUSO0l8MVIumnNat5w6rdPaiGKr5mn zg0A== X-Gm-Message-State: AOJu0YzStgMq6gBh50QhBLeJ8uhEP8hMW8MHwCBt+uAF3p7+x28x4cJl iDjS1lg1exT524o+bo4dM9okaHD2tzPqja8Ye5AR+f7502ZC3YqqeaGiMj21tardXMrTGnvuPj/ llCbP5d/rGoLgZil1CfusRYs6oRII4A== X-Received: by 2002:a5d:688e:0:b0:332:ca0b:5793 with SMTP id h14-20020a5d688e000000b00332ca0b5793mr10999990wru.19.1701167653777; Tue, 28 Nov 2023 02:34:13 -0800 (PST) X-Google-Smtp-Source: AGHT+IF+q5MOB6OzdpsH7/CdObBt2kTAiyRv1bPoO1LrN4PZLDe9h7d6NUNvVkPdCHiNRZnLT6Ld1w== X-Received: by 2002:a5d:688e:0:b0:332:ca0b:5793 with SMTP id h14-20020a5d688e000000b00332ca0b5793mr10999974wru.19.1701167653456; Tue, 28 Nov 2023 02:34:13 -0800 (PST) Received: from localhost (105.226.159.143.dyn.plus.net. [143.159.226.105]) by smtp.gmail.com with ESMTPSA id u7-20020adfeb47000000b003330a1d35b6sm1921730wrn.115.2023.11.28.02.34.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 28 Nov 2023 02:34:13 -0800 (PST) From: Andrew Burgess To: Tom Tromey Cc: gdb-patches@sourceware.org Subject: Re: [PATCH 0/7] Changes to gdb-index creation In-Reply-To: <87y1ejdm0e.fsf@tromey.com> References: <87y1ejdm0e.fsf@tromey.com> Date: Tue, 28 Nov 2023 10:34:12 +0000 Message-ID: <875y1mp3ob.fsf@redhat.com> MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain X-Spam-Status: No, score=-5.7 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H4,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Tom Tromey writes: >>>>>> "Andrew" == Andrew Burgess writes: > > Andrew> Patches #1 and #2 are pretty straight forward improvements; don't > Andrew> think they will be controversial. > > Andrew> Patch #4 is an interesting bug fix. > > Andrew> Patches #6 and #7 are what this series is really all about. Making > Andrew> the indexes created by 'save gdb-index' be determenistic as the number > Andrew> of worker-threads that GDB uses changes. > > I read through this. I was a bit worried about new gdb.gdb tests (I > feel those are often more trouble than they're worth), but this one > avoids the problem stuff and anyway there doesn't seem to be a better > way to do it. > > Anyway, I sent a nit or two, everything looks good to me. > Thanks for doing this, and nice find on the hash table bug. > > Approved-By: Tom Tromey I pushed this series. Thanks, Andrew