From: Tom Tromey <tromey@adacore.com>
To: "Kévin Le Gouguec" <legouguec@adacore.com>
Cc: Tom Tromey <tromey@adacore.com>, gdb-patches@sourceware.org
Subject: Re: [PATCH 3/3] Implement the notStopped DAP response
Date: Fri, 10 Nov 2023 08:08:38 -0700 [thread overview]
Message-ID: <875y29ve6h.fsf@tromey.com> (raw)
In-Reply-To: <878r78bqlk.fsf@adacore.com> (=?utf-8?Q?=22K=C3=A9vin?= Le Gouguec"'s message of "Wed, 08 Nov 2023 09:23:51 +0100")
>>>>> "Kévin" == Kévin Le Gouguec <legouguec@adacore.com> writes:
>> @@ -178,6 +199,11 @@ def request(name: str, *, response: bool = True, server: bool = False):
>>
>> If SERVER is True, the function will be invoked in the DAP thread.
>> When SERVER is True, RESPONSE may not be False.
>> +
>> + If MUST_BE_STOPPED is True (the default), then the request will
>> + fail with the 'notStopped' reason if it is processed while the
>> + inferior is running. When MUST_BE_STOPPED is False, the request
>> + will proceed regardless of the inferior's state.
>> """
>>
>> # Validate the parameters.
Kévin> (Feeling like EXPECT_STOPPED might better convey that parameter's role
Kévin> as a precondition, rather than as a "call to action" for request(); tiny
Kévin> nit though, the doc clarifies the intent anyway)
I made this change.
Tom
prev parent reply other threads:[~2023-11-10 15:08 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-07 18:29 [PATCH 0/3] Implement the DAP notStopped response Tom Tromey
2023-11-07 18:29 ` [PATCH 1/3] Automatically run (most) DAP requests in gdb thread Tom Tromey
2023-11-13 12:59 ` Alexandra Petlanova Hajkova
2023-11-07 18:29 ` [PATCH 2/3] Remove ExecutionInvoker Tom Tromey
2023-11-13 13:57 ` Alexandra Petlanova Hajkova
2023-11-07 18:29 ` [PATCH 3/3] Implement the notStopped DAP response Tom Tromey
2023-11-08 8:23 ` Kévin Le Gouguec
2023-11-10 14:52 ` Tom Tromey
2023-11-10 15:14 ` Kévin Le Gouguec
2023-11-10 15:18 ` Tom Tromey
2023-11-10 15:08 ` Tom Tromey [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=875y29ve6h.fsf@tromey.com \
--to=tromey@adacore.com \
--cc=gdb-patches@sourceware.org \
--cc=legouguec@adacore.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).