From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-io1-xd36.google.com (mail-io1-xd36.google.com [IPv6:2607:f8b0:4864:20::d36]) by sourceware.org (Postfix) with ESMTPS id 5F2093858CDB for ; Fri, 10 Nov 2023 15:08:40 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 5F2093858CDB Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=adacore.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=adacore.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 5F2093858CDB Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2607:f8b0:4864:20::d36 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1699628921; cv=none; b=bb2Ac0Qoalboa0GefxMaWXqHOgVEZXaEyGP9vJOwD++nGTId7ioUlzrvFQY4dO8Oyxyv4aGznbaZd9yVlf8VGxIc3qsvaEvPQVvJAthMZFhTTtg+7fq9zpntcH7hT/kY6ekWLlIMobJ+ADjtZMtsle3qbqRQgEIm+JZcANTeoGc= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1699628921; c=relaxed/simple; bh=EoCOVn5JS97HffGDM86QB4yLlT6TfU9GnLzYi93x9yM=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=P20aS9tKhWQMG75Jc9bofvOlzEGh8HiKJcA184zQi6i7Kh2bpavlfjd6WVXhHaTyK2PMwl29PvrHzZb1Rog1/2IQtRju99zt/yhk//A4AtLY/pYFPkskvvDjcSoMtNCd6anUvoj662k/ffPNqUuasUOksKa5v5y2T8uHG3QtObE= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-io1-xd36.google.com with SMTP id ca18e2360f4ac-7affff20d38so34592639f.0 for ; Fri, 10 Nov 2023 07:08:40 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=adacore.com; s=google; t=1699628919; x=1700233719; darn=sourceware.org; h=content-transfer-encoding:mime-version:user-agent:message-id :in-reply-to:date:references:subject:cc:to:from:from:to:cc:subject :date:message-id:reply-to; bh=k2gCxYZhDNzgClr51b9GqG2tWrswUlEIlyv/+GDL9uM=; b=dGmHxBpImkpdsTXsGBWBM9XzQs+f8J6JZSM2Fuwy1Zh0JjgEQgICdKhdArVkhkjqs5 HBMEwJ82ra7cjyW1n0Wgg5Hr2jI1zwKQTpOLb/i4HSZ7tbBc2PAl4exEPjxA1b3teQs/ TLkj0LJuzI9zMDHUWP9Pv/JpCMk+sgfKW2JBV6hxgXEvjILyJYOw5VVb9CKkEQTiasEH ViFKev3aqHMnY1vgqWbIeFBYgrAeNChaIgFDT3bN15Thqdgtf3Y8zYB+a+VSA/ttEkDb Zgx9cHWp52hXCPiPQqRIk/x+TzDi/k9SbQM4nXd6VS1QOEi+vPOrze7LLwxck9ypbmgb +LrA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1699628919; x=1700233719; h=content-transfer-encoding:mime-version:user-agent:message-id :in-reply-to:date:references:subject:cc:to:from:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=k2gCxYZhDNzgClr51b9GqG2tWrswUlEIlyv/+GDL9uM=; b=EHZlxZaJcIAyGAO8MrWhMO+Lkqeyu3BPRkyfSX662JpOWGhITnE/NSobCxiO22HXkO b8ToO/wXkj38RaW+UVTULzq7dodStyj5VxuAsuXFmiF2c2ZTwV5XeGpLgL/Zl4EJ0sE5 LIlcV0i8YjEEHv/zejdghEKde9FlU3JwvEwZSFWG5AqGJ91HHAlJP9zmD73i3gaVMMiK oerMTWkuRp2B0geE/XOiJ1v1n+P5mETCfJkN0C3cyIP2Ja1qfNdrzbX0877oyQvcTFiz 5/w9CUjrwg46O55P7MU1ROjNFbe+CiTOvT9Z1hGBnTVNrrzL7sBVZZlgEIL5qY/nh85x 1rcg== X-Gm-Message-State: AOJu0Yzf5QEKuSNLTkmmanbEzOmoGnds7Lcc4yNTFO/FZlHtHdfqBmn2 bxDfXwKLAMczRrLC0dQDhyzNZQ== X-Google-Smtp-Source: AGHT+IFvU0g68jfigJZZsAQEKHX8DP6KajDQBx1IAIrLoJBujm6JuC4qBiEp1XHCVBzyZwJcS9CB6Q== X-Received: by 2002:a05:6602:c85:b0:787:8cf:fe8a with SMTP id fp5-20020a0566020c8500b0078708cffe8amr6343601iob.2.1699628919611; Fri, 10 Nov 2023 07:08:39 -0800 (PST) Received: from murgatroyd (97-122-77-73.hlrn.qwest.net. [97.122.77.73]) by smtp.gmail.com with ESMTPSA id dp25-20020a0566381c9900b0043193e32c78sm4472396jab.152.2023.11.10.07.08.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 10 Nov 2023 07:08:39 -0800 (PST) From: Tom Tromey To: =?utf-8?Q?K=C3=A9vin?= Le Gouguec Cc: Tom Tromey , gdb-patches@sourceware.org Subject: Re: [PATCH 3/3] Implement the notStopped DAP response References: <20231107-dap-not-stopped-v1-0-3d91c935255d@adacore.com> <20231107-dap-not-stopped-v1-3-3d91c935255d@adacore.com> <878r78bqlk.fsf@adacore.com> X-Attribution: Tom Date: Fri, 10 Nov 2023 08:08:38 -0700 In-Reply-To: <878r78bqlk.fsf@adacore.com> (=?utf-8?Q?=22K=C3=A9vin?= Le Gouguec"'s message of "Wed, 08 Nov 2023 09:23:51 +0100") Message-ID: <875y29ve6h.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-5.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: >>>>> "K=C3=A9vin" =3D=3D K=C3=A9vin Le Gouguec wri= tes: >> @@ -178,6 +199,11 @@ def request(name: str, *, response: bool =3D True, = server: bool =3D False): >>=20 >> If SERVER is True, the function will be invoked in the DAP thread. >> When SERVER is True, RESPONSE may not be False. >> + >> + If MUST_BE_STOPPED is True (the default), then the request will >> + fail with the 'notStopped' reason if it is processed while the >> + inferior is running. When MUST_BE_STOPPED is False, the request >> + will proceed regardless of the inferior's state. >> """ >>=20 >> # Validate the parameters. K=C3=A9vin> (Feeling like EXPECT_STOPPED might better convey that parameter= 's role K=C3=A9vin> as a precondition, rather than as a "call to action" for reques= t(); tiny K=C3=A9vin> nit though, the doc clarifies the intent anyway) I made this change. Tom