From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from omta036.useast.a.cloudfilter.net (omta036.useast.a.cloudfilter.net [44.202.169.35]) by sourceware.org (Postfix) with ESMTPS id 68F483857354 for ; Sun, 5 Nov 2023 16:35:39 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 68F483857354 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 68F483857354 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=44.202.169.35 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1699202140; cv=none; b=Zk/oacGLMktNkgu35VK0gC/eesYisD/2XZr9XgxczyPQoGIwCnQGJD4MwuB3LnOgOnHSbRgKEMKaB6UMcaZjFjFc+fmfeIJeNHqeBAMHfbxCMaBOv23yGMzWdVDE7+VWY1Qi6GkvY448hMIxWYhOTJJ9LXPDXySMOEcd3NhUWZg= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1699202140; c=relaxed/simple; bh=+2UFETejZUSPXnNxJqHVXKK6mOj5Exq6qHOf/py4ETg=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=XheXY4mmCS//3FwtmTVoZpPFjkxAD+YK4x/4UhNRcIzNdVyYcYHYB/FexQ7hrtljSeDPvzQlb/VWgcD+itVyFmwz2+kOo0UVeA1E1DZU/8+6mc+ZsokzIVOQCMN5UrMZ/61UVIwOzqvs11yng49/VOmxq0jDoedBe6fWNBJxwC0= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from eig-obgw-6008a.ext.cloudfilter.net ([10.0.30.227]) by cmsmtp with ESMTPS id zarMq9hdSgpyEzg67q7zUg; Sun, 05 Nov 2023 16:35:39 +0000 Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with ESMTPS id zg65qcAJS79UBzg66q0nsl; Sun, 05 Nov 2023 16:35:38 +0000 X-Authority-Analysis: v=2.4 cv=YqEc+qUX c=1 sm=1 tr=0 ts=6547c45a a=ApxJNpeYhEAb1aAlGBBbmA==:117 a=ApxJNpeYhEAb1aAlGBBbmA==:17 a=OWjo9vPv0XrRhIrVQ50Ab3nP57M=:19 a=dLZJa+xiwSxG16/P+YVxDGlgEgI=:19 a=BNY50KLci1gA:10 a=Qbun_eYptAEA:10 a=dzWzf_mpAAAA:8 a=0Hg9CXDZQzeZdJCDl1IA:9 a=b4DR9a7p2ZdsqdHBznES:22 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date:References :Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=Coo5Fg0guJb11Xmfyb/z9xIMVeQA7jHZpUAOq6ExjFY=; b=WvN7MS8TvFzTXuI1Jsd4rdHe8j oyFxvUfdx+NBhT32jFPNQFWuwGhBLof+QfVsRYV1D0IIPGwS/GDncW5gB1/vyNTxSA524faukTO04 vrgsU2qapZZKv/d+KeJyCNELm; Received: from 97-122-77-73.hlrn.qwest.net ([97.122.77.73]:46064 helo=prentzel) by box5379.bluehost.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96.2) (envelope-from ) id 1qzg65-002RME-1u; Sun, 05 Nov 2023 09:35:37 -0700 From: Tom Tromey To: Simon Marchi Cc: Tom Tromey , gdb-patches@sourceware.org Subject: Re: [PATCH 05/30] Use block_symbol::address in printcmd.c References: <20231029-split-objfile-2023-bound-sym-october-v1-0-612531df2734@tromey.com> <20231029-split-objfile-2023-bound-sym-october-v1-5-612531df2734@tromey.com> X-Attribution: Tom Date: Sun, 05 Nov 2023 09:35:57 -0700 In-Reply-To: (Simon Marchi's message of "Thu, 2 Nov 2023 23:42:57 -0400") Message-ID: <875y2gtaxe.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 97.122.77.73 X-Source-L: No X-Exim-ID: 1qzg65-002RME-1u X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 97-122-77-73.hlrn.qwest.net (prentzel) [97.122.77.73]:46064 X-Source-Auth: tom+tromey.com X-Email-Count: 4 X-Org: HG=bhshared;ORG=bluehost; X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-CMAE-Envelope: MS4xfN2ZYcxSksGvZ0Ym5B4e0VQ/SyUHDFqaW/pHNo5PTT657gBfKH5naSD9veY/2Cg/zhFtPV9wpX9pMcvyd/QATM/V/8Edk+HGpLIuZxvBEyJ0oHIR5oMW c9+sed/deVu+bcsXQEzwy/MztAMcQB09bsustt4qBvzWSTpKffsIsDBzf/e45kEjUIbFRVaHizAfQoRSh7LPS1ylbGs9WNPV3e0= X-Spam-Status: No, score=-3018.3 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,JMQ_SPF_NEUTRAL,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: >>>>> "Simon" == Simon Marchi writes: >> - sym = lookup_symbol (exp, get_selected_block (&context_pc), VAR_DOMAIN, >> - &is_a_field_of_this).symbol; >> + block_symbol bsym = lookup_symbol (exp, get_selected_block (&context_pc), >> + VAR_DOMAIN, >> + &is_a_field_of_this); >> + sym = bsym.symbol; Simon> I would suggest moving the declaration of sym there. I did this. Tom