From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id E1445386180D for ; Tue, 26 Sep 2023 13:48:54 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org E1445386180D Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1695736134; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=/Aa+mW9yD8oFju3g11+xw7Utm7g7PVJjurRi5cmF3s4=; b=YLV50NvAYhPYfkYkaZO8KQI/kh9UYD+Gfxsgi9rvVmnc2W2k2zd8x8bh2IQ+cqFnu58a6y UCK/Lf1d4N724tphL/SYiR8FsF6DCYj3sX83w/YgtS5l+5mQdFkPXOvUnBCq7o5F+XHfLC KQzrGwxKLZtJ5FStSb4wASa+JBPrnOI= Received: from mail-ej1-f69.google.com (mail-ej1-f69.google.com [209.85.218.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-323-wm3atKeXMTGGIGQATUS4QQ-1; Tue, 26 Sep 2023 09:48:53 -0400 X-MC-Unique: wm3atKeXMTGGIGQATUS4QQ-1 Received: by mail-ej1-f69.google.com with SMTP id a640c23a62f3a-9a9e12a3093so498941466b.0 for ; Tue, 26 Sep 2023 06:48:53 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1695736132; x=1696340932; h=mime-version:message-id:date:references:in-reply-to:subject:cc:to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=/Aa+mW9yD8oFju3g11+xw7Utm7g7PVJjurRi5cmF3s4=; b=CbZLxDNMUtx0GUpDfciSF2tRVej249oD18vr8vcpceykxhoGG2wMORy/D7CN5FkgLF CpaQuE0XZPIiY1YiPlWWGtUvhNqYYnDXu2cs/C7W+ZzueYRIYSnSaOPo8uTmCW+BLT2W fPLF65rdgy4xdVV4mtpfmEcoOInIfLJI3fXDOE1bJvzhk1lmT5tlS+6fQytx4h59Dqd5 x8rpq1YiaeMxtNEbT0aslS5xD9f7rpd22mZlBRqLk6BoNZL3AH7K4zhGHlARkMFwx6V8 ViCkHpAjSmA5xT20aEvIemjKtOpeRm8NWSrXs+ZYjwlZkwvTRvZUxYEfwcjJ4AcVAEZr Q+Gw== X-Gm-Message-State: AOJu0Yxg85dmK4PT7/FZwlxkRfJJxnK58Lg8ZF3CFRnswYqzT//4pNyd Epw9elYywS4jZMqWPDYygFIkEOG+kMKzlo3JBRYquZJeEkcpUCTgZhtIXaQRD5KEdOC7w4BZw1t DS0sGUe3z9td/pxMW3D2NSHQxJN/CPw== X-Received: by 2002:a17:906:19b:b0:9ae:659f:4d2f with SMTP id 27-20020a170906019b00b009ae659f4d2fmr4625951ejb.26.1695736131916; Tue, 26 Sep 2023 06:48:51 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHzooVLSDm/tKv9afPzLsqbZ3gv17azSbr3cGQTR6gpGeAtwXdz9Bdhfgg+W6zTs+9mxNW7ww== X-Received: by 2002:a17:906:19b:b0:9ae:659f:4d2f with SMTP id 27-20020a170906019b00b009ae659f4d2fmr4625906ejb.26.1695736131304; Tue, 26 Sep 2023 06:48:51 -0700 (PDT) Received: from localhost ([31.111.84.209]) by smtp.gmail.com with ESMTPSA id s2-20020a170906354200b0098ec690e6d7sm7818413eja.73.2023.09.26.06.48.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 26 Sep 2023 06:48:50 -0700 (PDT) From: Andrew Burgess To: Tom Tromey , Andrew Burgess via Gdb-patches Cc: Tom Tromey Subject: Re: [PATCH] Support the NO_COLOR environment variable In-Reply-To: <87a5ti8d4y.fsf@tromey.com> References: <20230916000908.110459-1-tom@tromey.com> <87h6nrztkl.fsf@redhat.com> <87a5ti8d4y.fsf@tromey.com> Date: Tue, 26 Sep 2023 14:48:49 +0100 Message-ID: <875y3xxcxq.fsf@redhat.com> MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain X-Spam-Status: No, score=-5.6 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H4,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Tom Tromey writes: >>>>>> "Andrew" == Andrew Burgess via Gdb-patches writes: > > Andrew> Tom Tromey writes: >>> I ran across this site: >>> >>> https://no-color.org/ >>> >>> ... which lobbies for tools to recognize the NO_COLOR environment >>> variable and disable any terminal styling when it is seen. > > Andrew> I've never understood the passionate hatred some folk have for coloured > Andrew> output! But NO_COLOR sounds like a fairly reasonable request, so I'm in > Andrew> favour of adding this. I did have some thoughts on the testing... > > Me neither but it seems pretty simple to accommodate them. > >>> - if {$dumb_terminal} { >>> - clean_restart $binfile >>> - } else { >>> - Term::clean_restart 24 80 $binfile >>> - if {![Term::prepare_for_tui]} { >>> - unsupported "TUI not supported" >>> - return >>> + global env >>> + save_vars { env(TERM) } { >>> + setenv TERM $terminal >>> + if {$dumb_terminal} { >>> + clean_restart $binfile >>> + } else { >>> + Term::clean_restart 24 80 $binfile >>> + if {![Term::prepare_for_tui]} { >>> + unsupported "TUI not supported" >>> + return >>> + } > > Andrew> I'm not sure that this change is needed. > > Something is needed here, because without this there are regressions. OK, yeah, I see what I missed now. Thanks, Andrew