From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx0b-00069f02.pphosted.com (mx0b-00069f02.pphosted.com [205.220.177.32]) by sourceware.org (Postfix) with ESMTPS id 918E73830B67 for ; Mon, 21 Aug 2023 17:05:49 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 918E73830B67 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=oracle.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=oracle.com Received: from pps.filterd (m0246631.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 37LFxOHx027365 for ; Mon, 21 Aug 2023 17:05:49 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=from : to : cc : subject : in-reply-to : references : date : message-id : content-type : mime-version; s=corp-2023-03-30; bh=tQ814F1tkg9NpfWVJ/s/195YzKuHqc3vgcjOP7KMZ1M=; b=MVw71opr5ph15cB+hfgZ5TfJj2y3LY/v6VrW9hEMjxLvgA/eZvzDaugR41vNYo0REuc/ bOSEwrJKmpzUOn+ekPswg0XLtqzMQM8Okd7Ze223EzkDmq6A4+vgP3B0F6IoEb3uhOof X1pYVXy71XwpYvAYJbwmX1LPTbe9ZOWjy3xFjTNWBr+8DDAq9oJY9J/w38Z+pmt/Zjrg 02+qc3lWg11a9NcnCgZ89/PtMs1/UYgTuUnNMZtks0TFK9uePd9Mos6fhF0KsPW4lLbE /LY0kNiCL9oZZMcI36WW8ujXCdA4ZsP4gXK2zF6yvpO+gPE0LtoImFVHaBv4rxVFbTK/ Yg== Received: from phxpaimrmta02.imrmtpd1.prodappphxaev1.oraclevcn.com (phxpaimrmta02.appoci.oracle.com [147.154.114.232]) by mx0b-00069f02.pphosted.com (PPS) with ESMTPS id 3sjmh3bdec-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Mon, 21 Aug 2023 17:05:49 +0000 Received: from pps.filterd (phxpaimrmta02.imrmtpd1.prodappphxaev1.oraclevcn.com [127.0.0.1]) by phxpaimrmta02.imrmtpd1.prodappphxaev1.oraclevcn.com (8.17.1.19/8.17.1.19) with ESMTP id 37LH4Suw026729 for ; Mon, 21 Aug 2023 17:05:48 GMT Received: from nam11-bn8-obe.outbound.protection.outlook.com (mail-bn8nam11lp2169.outbound.protection.outlook.com [104.47.58.169]) by phxpaimrmta02.imrmtpd1.prodappphxaev1.oraclevcn.com (PPS) with ESMTPS id 3sjm63yc29-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Mon, 21 Aug 2023 17:05:47 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=VT6GZ6XxDJs2Zqupo3dqB2m7gNQx4XwdgiO1t2X96u1Cw03jRYMywLj68/QgwTEhExolMJPBZVD97+HOeGu5Bd81RImgVUQYEn5cuVSTWd+iPWv4+r/VtPOAKqz4eUDF6higABbe06XZbyqyfgfp5RLnLtqaMVt72OP4dfGYadM6KsKAUYUufXnoCT3B2cG4JVqk4Ml9kE77vY275F4UpebKWUqpYzYk1jCXRo/hvqS4RFdr0WyMnk1CyUoX+PHkPinwQJSIn2lKefN3571LrwJ87wxghgMOXhfqnVOakHASJuyb2JbSxlQDlkhjoaDEUqKrOUSfodSGOrhLfyLMvA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=tQ814F1tkg9NpfWVJ/s/195YzKuHqc3vgcjOP7KMZ1M=; b=k2fCzRxt0sP/DepKKpJO7Asz45Xbnx/1ujuB1FowLNxKiQQ+F03YLKgbb30SgNBhYtb4QWQ9xNa6C99S9mX3n3yXM6oyWDF1kE0yeMSNZHPPrP1ih2ZriVUie0DiTF9VVIoJAJtqwQuyM52uKLAYny59UNWgrUqPwhFIQcpd9dU/Learp1PgPF7TqcP0QGepoVe1Jh80bHmPTa270p44vO5WyN4sZH8CmLOT1P2rXTFpZhH6MbLO8TZT2yG+qw0GCtelkFiwL5jWKImjb+RT4HDdzDP5yeWWBv0Y9VkPZ2UdvSgGiwfl2tI677i8Cr1qrEaDxZQ+VKuKCjEQTEEwxw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=tQ814F1tkg9NpfWVJ/s/195YzKuHqc3vgcjOP7KMZ1M=; b=GDUrtXVdlHmlhknFqfcpqV1wSBhLvbzATmRIkayRyGHAQu6MHZscl9kb26YL65guy3h9W/ryjOTq1nL9PoXLzJL7y3FY1CG1WSb6Ux2sQsvuhrZxZZ2x1rQeAAmc0nez80VlTrHyVxsSpdQb2fgsC2TmNn0DILuS0K+mU8yvHvI= Received: from BYAPR10MB2888.namprd10.prod.outlook.com (2603:10b6:a03:88::32) by PH0PR10MB5561.namprd10.prod.outlook.com (2603:10b6:510:f0::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6699.24; Mon, 21 Aug 2023 17:05:45 +0000 Received: from BYAPR10MB2888.namprd10.prod.outlook.com ([fe80::fd36:b9b2:19f5:6f74]) by BYAPR10MB2888.namprd10.prod.outlook.com ([fe80::fd36:b9b2:19f5:6f74%5]) with mapi id 15.20.6699.022; Mon, 21 Aug 2023 17:05:45 +0000 From: "Jose E. Marchesi" To: David Faust Cc: gdb-patches@sourceware.org Subject: Re: [PATCH] sim: bpf: remove negi, neg32i insns In-Reply-To: <20230821170250.6457-1-david.faust@oracle.com> (David Faust's message of "Mon, 21 Aug 2023 10:02:50 -0700") References: <20230821170250.6457-1-david.faust@oracle.com> Date: Mon, 21 Aug 2023 19:05:38 +0200 Message-ID: <875y58l40t.fsf@oracle.com> User-Agent: Gnus/5.13 (Gnus v5.13) Content-Type: text/plain X-ClientProxiedBy: LO4P302CA0031.GBRP302.PROD.OUTLOOK.COM (2603:10a6:600:317::18) To BYAPR10MB2888.namprd10.prod.outlook.com (2603:10b6:a03:88::32) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BYAPR10MB2888:EE_|PH0PR10MB5561:EE_ X-MS-Office365-Filtering-Correlation-Id: a88cfeb3-a74b-4e0c-9e07-08dba268dbeb X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 5QZvVEGl3oaNt2Wf+pGv8JyHErG6BYooulO206jEvT2lICwCEG6Po3DjuzUqfRVRAjjxcvMDn3UCiIzGue41gwTHJwccr+X5ugKy23vSnhP1l50MkMYWfgOJtstGCBMnLS8Niei3tN4qcq97yN1Gj6bcYlah+06qob06p0YqjiD2k9jChVPERPD3UeJU5tBt87/7BK0GbHCzilnHEhwHV+tLxTNQNEMHIwKvRyfUM4lrD78f9WEGhlEOyGxqLsdlFAlv41M3KYqAcZdfO6yRcR3VLY9Y9tpQzpTWaKanHoR0bMacxErleFg4ewn818yEVB+Xru2MYoVmQGVBlvSWjAwnQw8WRziHkVvWcxd1PpWu+/qUJnz/dIVvN+CurfoNnk55GbqD3yc+9M8HCEw4hRcwbfauqQsk4xmBvP9mCG7wTPhyO1vhghROmmbh2efxYhs9kruEvMqOr7CCGGogKAi5a7kWSYMvPLqP6+PB/2jwOTBt1E2HQ7AF90vDFMpbXWQ/0oQYczEhET5is31Wb3GhQ/kP//o6/0QGkse+/14= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR10MB2888.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230031)(376002)(366004)(346002)(136003)(39860400002)(396003)(451199024)(1800799009)(186009)(2906002)(83380400001)(6506007)(38100700002)(6486002)(5660300002)(26005)(86362001)(8676002)(8936002)(2616005)(6862004)(4326008)(6512007)(316002)(66476007)(6636002)(66556008)(66946007)(37006003)(966005)(478600001)(6666004)(36756003)(41300700001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?0zxV/MiiWvNxQjHMFE4EtE9ZcJ0tvbTnyhVBlI8yDijlg4cYWpHr8qzY/sqa?= =?us-ascii?Q?agSGuyUQEBC1Tsc0c7Dkt6jeJpXR0dJPJcIYK+eTsT9p4FM/F/ApigUvuCD5?= =?us-ascii?Q?U8hs7v/Wm2C4oWA4e2r8SWSlhipRhwh9bPbkr4rIa1cLDBTliEBsHcV350Du?= =?us-ascii?Q?OaQVojmae6mSP+hDWFahSxho0bcSyLgx/EkNKdwlKlKI7/fLBJr1gT2rVE1E?= =?us-ascii?Q?LPVrAT5hbBoE+p9t2TY6/SGUckcWysXrM01Xw7tFs6kmt2EkOxL+pQuXT9RL?= =?us-ascii?Q?Bpih8PDSeSP/g36sq6K67GnFGxV+x8yGq4P6qse6Y4OwyJFjuCOspnSh/Jzq?= =?us-ascii?Q?3S9VBvP4DuZU47/2n8WH5iKzPi/5lMzvrVSCtaQvatDZt4cg7kO79Wnax4JY?= =?us-ascii?Q?gp5zEIzgFIPVDcgnZQWxOu5F8pmRt6FGsfGxdGSiNNBXOvK3K2vBUqgSAnTM?= =?us-ascii?Q?67s11MX2pWpgk/H7JrhCZJPES64iureK7CoQBJnuKRhDSHGtKoGZSqa5+qah?= =?us-ascii?Q?gHFyWKMb1DvVBLdA/eqoiC5nxKaIsACyyRmbe+4v4kz7ONnOxVT1N4kQw9zo?= =?us-ascii?Q?T+XPk3PKEvucZKqUvznrwG2Sxuv8CAfiuQiXb93rBu57S44oy2pBdb2yS9zE?= =?us-ascii?Q?AZNHNI+lBit4IFJ/QZreuu1mHxUHoVJz6jqWKpyosLkwLtYN8X8YhG+2wz57?= =?us-ascii?Q?bqw1o4tCq/jNi6VZ5gO3FKxsAzyZHTVi8r3h+mQ7st6CAMR687FuEG5qVZ40?= =?us-ascii?Q?Cv7vDVnRFA4prl7wCfQam01EdFUh4rK7Mo7bqWZIHNCuiHirx/v463cOKr+/?= =?us-ascii?Q?4PpZsVMXjrx6+ZvBPqGorpTorUgWdCA8TFsSqEuQAG9+Sc9GsqYb1y0Txo5f?= =?us-ascii?Q?/yPbIczgvhEt3HzKbxXE4UkgdlH6N2/k3BVOGjuL9BS6N3rJcgvcqWMM0vKS?= =?us-ascii?Q?wge2ZhyKwXw4uavWpfEzMbVSEyHp1lrwPPe8Psyqv7HTZ6tkaxojyQCgEibT?= =?us-ascii?Q?/qknF2a6RmrUxkp9v7FlBcRIytJ95goRzpcBwLmX0gcjt43hbuEftPMthQi9?= =?us-ascii?Q?Si2onO/c8pRFGfTNfAGhTPyIWVUPFal4K2tHoFnvm7VqrPJyaShop+acKPHY?= =?us-ascii?Q?agt0q6aWwjDzojKer8YXKFD6sPPj9l4kSux7du02ODR11RbFOnyBY4XO3wjs?= =?us-ascii?Q?bi0H537ON2CuJ81DNjd8UKAzhaZ+U72QAGGxb4ZFtR5/+h3GZ9EtQ7TfNzVB?= =?us-ascii?Q?RNyK3ToOMBZmUzW5yPv4i3cnjq9ddK2PX8urt4DtgI1XzkvNCHeGfb7VusCb?= =?us-ascii?Q?W5PM4kaPxUHolF4RAEcPNuZvM9/gA1QuQQ0SVoFE8NeJ6DjVdrvD9Z1BdVKQ?= =?us-ascii?Q?V60TcpPeZJ5W/akhMC7giH4r3UPqqWgtu+ymHnzSrGNnY+5bfyyaFoa4t3SK?= =?us-ascii?Q?pzr0Qn6NY/3sOucKI8EeaqDyRcaXkM5JHobEXY/+ei2rSYVN7TJzw3Kigg58?= =?us-ascii?Q?3GWEFiK3FGc9LMoKuNPI6u68jwX6DuZlE7VCMLjMY3Mp4/bp55s6wUaBhkrq?= =?us-ascii?Q?OAdM0JXVcoSW/Bh5ewWlQQuUPUVjMhHVku36hAsPRJej1DIYnbMTByxPzD5w?= =?us-ascii?Q?qA=3D=3D?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: ZwsghYZRh5kUAAE8sPiNkLODgWYKr0LBaJvrQE9C0Xk4uDwN/8bFKG/n9IiSvdDItyImp3y/yTctEe8q72CdvyLfouAEyCRWbP3/ShSCokRX8ImngrQnjFOxu40BgtLj55eT03WqPFEGigmfWUylGuVcAPbdnVWSV/RVDfIqwwBau5BRm6Ba2TedK6YSN//qu0q0ioKj3IfJqRmcx6lHO1lDF/ESIOFGFJQnnU/E1TVDsow7oXEsmOunV7P2ZQHwPDmP43Hu32bGXmAWQIsvaGatHOJWirSoAEp0Jf2mwCnOK/1f1xHZ0eVwaqJ87dcpfMgkutkXRlfLGJdKsOtI//p3z5V6Q0v2nfT/KV+qCxnPptvLBQOEDdp62jC+bXccU6fxPdOdOfGSpNymrHvyN7YYUNTnuKVuGChCQ/8HXLaazSzUeslq1u34/ugTeBBi7sr2R+u+iS5ITCIUxZ6umz1/KtQPWV/2Kya1Tsrz30KPUqQGzNOpEBPgQzB7moQSrWbgCLH2aBr+TVhr2/cvfuiUVDhsi1qvWpp9w5YZOS+N7/4S4euFXyOoywjEzh9sunxoCRmzGSkipP6XCnaENJC375w/QRZTlXgRfHC0WE/mzQyvWXmC+if4TLuaLOT79M3VcLxGUkiVDV6ye1i7ujVkavhU8Pa+WbbF0kMghlfjVz5RAXur0kZmfofVDwvnwzquMpGlTn3CMhcwIDS76if8duq0d8RRxDThcV25UPpwyf/qScrXT1/hzQr95iIP X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-Network-Message-Id: a88cfeb3-a74b-4e0c-9e07-08dba268dbeb X-MS-Exchange-CrossTenant-AuthSource: BYAPR10MB2888.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Aug 2023 17:05:45.5571 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: +hMC2LIOCZgjO8Su9FIBUN+Wtl+fA+WVeeWSPtSMECV0Lmxfe+duEdhRBEY9wZ5pV0+8pO+t3GbuA6UMDddxn3E6D04sfAWyWRnn6VbeWhQ= X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR10MB5561 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.267,Aquarius:18.0.957,Hydra:6.0.601,FMLib:17.11.176.26 definitions=2023-08-21_05,2023-08-18_01,2023-05-22_02 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 phishscore=0 bulkscore=0 mlxlogscore=581 adultscore=0 spamscore=0 malwarescore=0 mlxscore=0 suspectscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2306200000 definitions=main-2308210159 X-Proofpoint-ORIG-GUID: bZHFIgOZsYtOWR92bm-7i3Aew9g6GNfk X-Proofpoint-GUID: bZHFIgOZsYtOWR92bm-7i3Aew9g6GNfk X-Spam-Status: No, score=-12.6 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,RCVD_IN_DNSWL_LOW,RCVD_IN_MSPIKE_H5,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Hi Faust. OK. Thanks. > The BPF virtual machine does not support neg instructions operating on > immediates, and these erroneous instructions were recently removed from > gas. Remove them from the simulator as well. > > binutils patch: > [PATCH] bpf: correct neg and neg32 instruction encoding > https://sourceware.org/pipermail/binutils/2023-August/129135.html > > --- > sim/bpf/bpf-sim.c | 8 -------- > 1 file changed, 8 deletions(-) > > diff --git a/sim/bpf/bpf-sim.c b/sim/bpf/bpf-sim.c > index 5e01ddeca9f..a4af22b2308 100644 > --- a/sim/bpf/bpf-sim.c > +++ b/sim/bpf/bpf-sim.c > @@ -730,10 +730,6 @@ execute (SIM_CPU *cpu, struct bpf_insn *insn) > BPF_TRACE ("BPF_INSN_NEGR\n"); > bpf_regs[insn->dst] = - (int64_t) bpf_regs[insn->dst]; > break; > - case BPF_INSN_NEGI: > - BPF_TRACE ("BPF_INSN_NEGI\n"); > - bpf_regs[insn->dst] = - (int64_t) insn->imm32; > - break; > case BPF_INSN_LSHR: > BPF_TRACE ("BPF_INSN_LSHR\n"); > bpf_regs[insn->dst] <<= bpf_regs[insn->src]; > @@ -867,10 +863,6 @@ execute (SIM_CPU *cpu, struct bpf_insn *insn) > BPF_TRACE ("BPF_INSN_NEG32R\n"); > bpf_regs[insn->dst] = (uint32_t) (- (int32_t) bpf_regs[insn->dst]); > break; > - case BPF_INSN_NEG32I: > - BPF_TRACE ("BPF_INSN_NEG32I\n"); > - bpf_regs[insn->dst] = (uint32_t) - (int32_t) insn->imm32; > - break; > case BPF_INSN_LSH32R: > BPF_TRACE ("BPF_INSN_LSH32R\n"); > bpf_regs[insn->dst] = (uint32_t) bpf_regs[insn->dst] << bpf_regs[insn->src];