From: Tom Tromey <tom@tromey.com>
To: John Baldwin <jhb@FreeBSD.org>
Cc: Tom Tromey <tom@tromey.com>, gdb-patches@sourceware.org
Subject: Re: [PATCH] C++-ify minidebug.c
Date: Thu, 17 Aug 2023 17:41:17 -0600 [thread overview]
Message-ID: <875y5dw82q.fsf@tromey.com> (raw)
In-Reply-To: <0dd247cb-a963-d061-fbf3-338d64f0b493@FreeBSD.org> (John Baldwin's message of "Mon, 14 Aug 2023 13:38:05 -0700")
>>>>> "John" == John Baldwin <jhb@FreeBSD.org> writes:
John> On 8/14/23 12:48 PM, Tom Tromey wrote:
>> I noticed minidebug.c was still using explicit malloc and free, where
>> a vector would be more automatic.
>> ---
>> gdb/minidebug.c | 71 +++++++++++++++++++------------------------------
>> 1 file changed, 28 insertions(+), 43 deletions(-)
John> Reviewed-by: John Baldwin <jhb@FreeBSD.org>
Thanks, I'm checking it in.
Tom
prev parent reply other threads:[~2023-08-17 23:41 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-14 19:48 Tom Tromey
2023-08-14 20:38 ` John Baldwin
2023-08-17 23:41 ` Tom Tromey [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=875y5dw82q.fsf@tromey.com \
--to=tom@tromey.com \
--cc=gdb-patches@sourceware.org \
--cc=jhb@FreeBSD.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).