From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gproxy1-pub.mail.unifiedlayer.com (gproxy1-pub.mail.unifiedlayer.com [69.89.25.95]) by sourceware.org (Postfix) with ESMTPS id D27E03858C5E for ; Wed, 14 Jun 2023 15:05:37 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org D27E03858C5E Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey.com Received: from cmgw13.mail.unifiedlayer.com (unknown [10.0.90.128]) by progateway3.mail.pro1.eigbox.com (Postfix) with ESMTP id 7EBC710040C0C for ; Wed, 14 Jun 2023 15:05:36 +0000 (UTC) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with ESMTP id 9S40qu3SuNX2a9S40qP8Zd; Wed, 14 Jun 2023 15:05:36 +0000 X-Authority-Reason: nr=8 X-Authority-Analysis: v=2.4 cv=NMAQR22g c=1 sm=1 tr=0 ts=6489d740 a=ApxJNpeYhEAb1aAlGBBbmA==:117 a=ApxJNpeYhEAb1aAlGBBbmA==:17 a=dLZJa+xiwSxG16/P+YVxDGlgEgI=:19 a=of4jigFt-DYA:10:nop_rcvd_month_year a=Qbun_eYptAEA:10:endurance_base64_authed_username_1 a=CCpqsmhAAAAA:8 a=zstS-IiYAAAA:8 a=alx_0jyUUcW-hxfLXYMA:9 a=ul9cdbp4aOFLsgKbc677:22 a=4G6NA9xxw8l3yy4pmD5M:22 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date:References :Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=hXpH6zQREyC1REKT9d6k6sBB/z3n+kTa9+9KZwalgBQ=; b=saUpgCEhgkoNv4uYJPkV56TZtL /P9jokapYLEbfy+iQySpG6iKAAXrtS1yYaSGZID3UNUMKEJfBYxCS9BaOfGhOB7kSByIUuwax61v0 TWdQyqHjrhS3EObmgEM/qnNHX; Received: from 75-166-136-83.hlrn.qwest.net ([75.166.136.83]:36100 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1q9S3z-000T4p-Pi; Wed, 14 Jun 2023 09:05:35 -0600 From: Tom Tromey To: Simon Farre via Gdb-patches Cc: Simon Farre Subject: Re: [PATCH v2] gdb/dap - Getting thread names References: <20230614133518.46605-1-simon.farre.cx@gmail.com> X-Attribution: Tom Date: Wed, 14 Jun 2023 09:05:35 -0600 In-Reply-To: <20230614133518.46605-1-simon.farre.cx@gmail.com> (Simon Farre via Gdb-patches's message of "Wed, 14 Jun 2023 15:35:18 +0200") Message-ID: <875y7q5bk0.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 75.166.136.83 X-Source-L: No X-Exim-ID: 1q9S3z-000T4p-Pi X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 75-166-136-83.hlrn.qwest.net (murgatroyd) [75.166.136.83]:36100 X-Source-Auth: tom+tromey.com X-Email-Count: 1 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-Spam-Status: No, score=-3019.3 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,JMQ_SPF_NEUTRAL,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: >>>>> Simon Farre via Gdb-patches writes: > So I couldn't determine right now, what operation of name change that > GDB does not pick up, but with this patch, GDB will pick up the thread > names for an applications that set the name of a thread in ways that > aren't obvious. I think gdb just reads the thread names on demand. So, on Linux, it doesn't really notice when they change. (On Windows there's a different mechanism and thread names can sometimes be seen by the debugger via an SEH handler.) Maybe gdb could use inotify on the comm files but it's probably not really worthwhile. For DAP, I don't think there's really a way to notify the client of thread name changes anyway. Anyway, this patch is ok. Approved-By: Tom Tromey Tom