From: Tom Tromey <tom@tromey.com>
To: Andrew Burgess via Gdb-patches <gdb-patches@sourceware.org>
Cc: Simon Marchi <simark@simark.ca>,
Andrew Burgess <aburgess@redhat.com>,
Pedro Alves <pedro@palves.net>,
Simon Marchi <simon.marchi@efficios.com>
Subject: Re: [PATCHv3] gdb: building inferior strings from within GDB
Date: Fri, 09 Jun 2023 07:41:41 -0600 [thread overview]
Message-ID: <875y7wah2i.fsf@tromey.com> (raw)
In-Reply-To: <87edmo380i.fsf@redhat.com> (Andrew Burgess via Gdb-patches's message of "Tue, 06 Jun 2023 16:50:05 +0100")
>>>>> "Andrew" == Andrew Burgess via Gdb-patches <gdb-patches@sourceware.org> writes:
Andrew> Thanks for pointing this out. I see what's going on here.
Andrew> What about this patch for fixing it?
Looks good to me.
If this idiom:
Andrew> + const std::string setting ((const char *) argv[0]->contents ().data (),
Andrew> + type0->length ());
is needed elsewhere, then maybe a new function or value method would be good.
For a single use though it doesn't seem to matter.
Tom
next prev parent reply other threads:[~2023-06-09 13:41 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-03 21:49 [PATCH] gdb: fix missing null-character when using value_cstring Andrew Burgess
2023-04-04 13:58 ` Simon Marchi
2023-04-06 13:20 ` Andrew Burgess
2023-04-11 12:58 ` Pedro Alves
2023-04-12 20:47 ` Andrew Burgess
2023-04-13 11:56 ` Pedro Alves
2023-04-07 6:35 ` [PATCHv2] " Andrew Burgess
2023-05-24 14:10 ` [PATCHv3] gdb: building inferior strings from within GDB Andrew Burgess
2023-05-24 15:42 ` Simon Marchi
2023-06-05 12:26 ` Andrew Burgess
2023-06-05 17:57 ` Simon Marchi
2023-06-06 15:50 ` Andrew Burgess
2023-06-09 13:41 ` Tom Tromey [this message]
2023-06-09 14:20 ` Andrew Burgess
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=875y7wah2i.fsf@tromey.com \
--to=tom@tromey.com \
--cc=aburgess@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=pedro@palves.net \
--cc=simark@simark.ca \
--cc=simon.marchi@efficios.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).