From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id 136433857348 for ; Wed, 7 Jun 2023 17:08:34 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 136433857348 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1686157713; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=mztZzCQhcZopLepNz9RP5Qd/h8Lf+uSfnsoI649CDno=; b=O14EF/8zXdYf5byLhuWT30UWQF3nTpk5iMosn45nKBFSboAIoFPN1luqyJVg+LTifK5IHu nA2KnA2zlq/pB2gWw92uDUMIiAkykk1YOYjxVyKE29rRJlShS9LgLDI+Yi6vuiOz3OBxCH BUwF33AyRrk2bPZ5ydqqhy6Nj8SE8xk= Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-301-AdKisWTqOZOVIRGRoBwlZQ-1; Wed, 07 Jun 2023 13:08:31 -0400 X-MC-Unique: AdKisWTqOZOVIRGRoBwlZQ-1 Received: by mail-wm1-f71.google.com with SMTP id 5b1f17b1804b1-3f72720c592so37233975e9.2 for ; Wed, 07 Jun 2023 10:08:30 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1686157710; x=1688749710; h=mime-version:message-id:date:references:in-reply-to:subject:to:from :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=mztZzCQhcZopLepNz9RP5Qd/h8Lf+uSfnsoI649CDno=; b=M7NveCd7o73ufOQar2s9h0/x9BPgAVUlxogesHAKNYTNCEARFDTrcniJsJx4u2e6Jp k/EkfIpjntXtscFrw7vxIM2AsI20c6plBIUylKQW1NzFlPZ2SH1oBzzuEmkOYEY947BP oz0+xA5lnbQr12Ct1xeNmcCY7gqF85y1sjpp7R2uo3nE9/GWg4pphGpEvFVRBbSLR+IG 5mx/aKaCLOkkhunEOaa/OYhe0mpNqNqsJoO2vXY0o9eaq6p24BwqLeN72N2w8I4gGv+u Bqcg+NMXXcPjX9WRD5zx0+yV1d3xbOhknTV3aBYP+ooxI3lL9MYC2bXg6e5iZfYsR0PD OMCA== X-Gm-Message-State: AC+VfDz3OiYrTKytR1o4XZbYzpxaIiBJd4uMxykL/5h38cv2hFzZyVhR KxbTVzOiviwxzLUXrwLtVq9Z/d3fZIsR6twz6oZFdaiK1c/b8yzEDYmbzWgSK2wgcstc1d+gsGi CsVdVA7Jz5Xijvtq9fQ+xS1gdI1qBhQ== X-Received: by 2002:a7b:cb92:0:b0:3f7:29c4:8fbd with SMTP id m18-20020a7bcb92000000b003f729c48fbdmr5411654wmi.27.1686157709902; Wed, 07 Jun 2023 10:08:29 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ69NwixvnaDDjdIN0nF2ktL3GnArmMtAiub3pYIJiQHPLO30DMeM0d9S8KQJmkdeYWhPh/nmA== X-Received: by 2002:a7b:cb92:0:b0:3f7:29c4:8fbd with SMTP id m18-20020a7bcb92000000b003f729c48fbdmr5411644wmi.27.1686157709579; Wed, 07 Jun 2023 10:08:29 -0700 (PDT) Received: from localhost (11.72.115.87.dyn.plus.net. [87.115.72.11]) by smtp.gmail.com with ESMTPSA id t7-20020a1c7707000000b003f6cf9afc25sm2707028wmi.40.2023.06.07.10.08.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 07 Jun 2023 10:08:29 -0700 (PDT) From: Andrew Burgess To: Pedro Alves , gdb-patches@sourceware.org Subject: Re: [PATCH 12/31] Remove gdb/19675 kfails (displaced stepping + clone) In-Reply-To: <20221212203101.1034916-13-pedro@palves.net> References: <20221212203101.1034916-1-pedro@palves.net> <20221212203101.1034916-13-pedro@palves.net> Date: Wed, 07 Jun 2023 18:08:28 +0100 Message-ID: <875y7z19pv.fsf@redhat.com> MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain X-Spam-Status: No, score=-11.8 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_NONE,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Pedro Alves writes: > Now that gdb/19675 is fixed for both native and gdbserver GNU/Linux, > remove the gdb/19675 kfails. > > Change-Id: I95c1c38ca370100675d303cd3c8995860bef465d > Bug: https://sourceware.org/bugzilla/show_bug.cgi?id=19675 Awesome! LGTM. Reviewed-By: Andrew Burgess Thanks, Andrew > --- > gdb/testsuite/gdb.base/step-over-syscall.exp | 44 ++------------------ > 1 file changed, 3 insertions(+), 41 deletions(-) > > diff --git a/gdb/testsuite/gdb.base/step-over-syscall.exp b/gdb/testsuite/gdb.base/step-over-syscall.exp > index 4192fa10826..e87382b2fa6 100644 > --- a/gdb/testsuite/gdb.base/step-over-syscall.exp > +++ b/gdb/testsuite/gdb.base/step-over-syscall.exp > @@ -42,46 +42,17 @@ if { [istarget "i\[34567\]86-*-linux*"] || [istarget "x86_64-*-linux*"] } { > } > > proc_with_prefix check_pc_after_cross_syscall { displaced syscall syscall_insn_next_addr } { > - global gdb_prompt > - > set syscall_insn_next_addr_found [get_hexadecimal_valueof "\$pc" "0"] > > # After the 'stepi' we expect thread 1 to still be selected. > - # However, when displaced stepping over a clone bug gdb/19675 > - # means this might not be the case. > - # > - # Which thread we end up in depends on a race between the original > - # thread-1, and the new thread (created by the clone), so we can't > - # guarantee which thread we will be in at this point. > - # > - # For the fork/vfork syscalls, which are correctly handled by > - # displaced stepping we will always be in thread-1 or the original > - # process at this point. > set curr_thread "unknown" > - gdb_test_multiple "info threads" "" { > - -re "Id\\s+Target Id\\s+Frame\\s*\r\n" { > - exp_continue > - } > - -re "^\\* (\\d+)\\s+\[^\r\n\]+\r\n" { > + gdb_test_multiple "thread" "" { > + -re -wrap "Current thread is (\\d+) .*" { > set curr_thread $expect_out(1,string) > - exp_continue > - } > - -re "^\\s+\\d+\\s+\[^\r\n\]+\r\n" { > - exp_continue > - } > - -re "$gdb_prompt " { > + pass $gdb_test_name > } > } > > - # If we are displaced stepping over a clone, and we ended up in > - # the wrong thread then the following check of the $pc value will > - # fail. > - if { $displaced == "on" && $syscall == "clone" && $curr_thread != 1 } { > - # GDB doesn't support stepping over clone syscall with > - # displaced stepping. > - setup_kfail "*-*-*" "gdb/19675" > - } > - > gdb_assert {$syscall_insn_next_addr != 0 \ > && $syscall_insn_next_addr == $syscall_insn_next_addr_found \ > && $curr_thread == 1} \ > @@ -299,15 +270,6 @@ proc step_over_syscall { syscall } { > > gdb_test "break marker" "Breakpoint.*at.* file .*${testfile}.c, line.*" > > - # If we are displaced stepping over a clone syscall then > - # we expect the following check to fail. See also the > - # code in check_pc_after_cross_syscall. > - if { $displaced == "on" && $syscall == "clone" } { > - # GDB doesn't support stepping over clone syscall with > - # displaced stepping. > - setup_kfail "*-*-*" "gdb/19675" > - } > - > gdb_test "continue" "Continuing\\..*Breakpoint \[0-9\]+, marker \\(\\) at.*" \ > "continue to marker ($syscall)" > } > -- > 2.36.0