From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-il1-x135.google.com (mail-il1-x135.google.com [IPv6:2607:f8b0:4864:20::135]) by sourceware.org (Postfix) with ESMTPS id DA6A73858C52 for ; Fri, 19 May 2023 15:57:07 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org DA6A73858C52 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=adacore.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=adacore.com Received: by mail-il1-x135.google.com with SMTP id e9e14a558f8ab-3381e9ec12bso26759715ab.3 for ; Fri, 19 May 2023 08:57:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=adacore.com; s=google; t=1684511827; x=1687103827; h=mime-version:user-agent:message-id:in-reply-to:date:references :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=4+Rick0psA3TqMc67fKGYYY+7zM27WywVoDF3l+C24k=; b=NzNZ3T8Jbxpa6Uf5aoG/YEQaceoJIVMcIJ0PXrs+qggBFS9ZUFC16Cpvecgew/3tbz o4YwrqjxfKAh+RYoTaHpcJriJVlRBMsi607I8osstVcqjA7eOkahpYhJCLA1Nimnchau cDNm1OolbgDEzrapukrOYA1xGimK79v+K47zFsvK34qSgD4/Rib+g2AsPEz3PDaR3/rH XD5b/Fi2U3GWENiuRV00f/7qHH7ZToDqfpXQx2fB8C6cuWgeNcyeqc+jX19sGW8Db9hf qsTJ8nBEyIe6qukayP0iM0IPdFwPvvAWLiWMbi6IL3YVngv/WMEFFr0FH0FPeXZp44ir dkLQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1684511827; x=1687103827; h=mime-version:user-agent:message-id:in-reply-to:date:references :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=4+Rick0psA3TqMc67fKGYYY+7zM27WywVoDF3l+C24k=; b=TJh8k6lLZ+Yx0Q4bJ5vIbOvLzrXV90q5ojG92+nkoSPiBHhBEGHS+rY52H0CQfheN2 zDIqAUMmfVFJ9TLM5gwmeI2cdukX+lNocmFweinWuVIy8vqXM9YUo82xKR48UdSmvULd jIVt2D5IKL2vRWRjNw4aTDcVf+rHyAfphuHuqSnBto4HP7njwFnUvndNNPhQnxvM+hI/ TVK/ThhXLMmzOxGABuuMmzw++wihD+F5pUXT3Z1ltlnKqbwPXpkk76Y+JA6osAM0EYCZ fZOeO4kL0BvQDeKB2aCfQ0y0FpHgn/8sxcUU8c1B58qpwVseZZjz97Dn8OiGoUd6iOi9 SbjA== X-Gm-Message-State: AC+VfDzekQqk56hUQkKyMMg7RKniSNgfcfarXEYNrbvXTVCI0jdKE70i uOcfwrPfdaAC4/wKk6jXeRd5x2Q/3gATK6GDATMCxA== X-Google-Smtp-Source: ACHHUZ4b1H3gdI1vg+GpMWfC/hei+fi5S1XX0Jlk9BMJneAd05SKQIhjPFy80zMIlNUOfvqi2QUKcQ== X-Received: by 2002:a92:d2ca:0:b0:337:83fc:43c8 with SMTP id w10-20020a92d2ca000000b0033783fc43c8mr1500073ilg.10.1684511827171; Fri, 19 May 2023 08:57:07 -0700 (PDT) Received: from murgatroyd (75-166-157-55.hlrn.qwest.net. [75.166.157.55]) by smtp.gmail.com with ESMTPSA id y16-20020a926410000000b00326ceaf3d96sm1035241ilb.71.2023.05.19.08.57.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 19 May 2023 08:57:06 -0700 (PDT) From: Tom Tromey To: Matt Rice Cc: Tom Tromey , Eli Zaretskii , gdb-patches@sourceware.org Subject: Re: [PATCH 8/9] Implement gdb.execute_mi References: <20230404-dap-loaded-sources-v1-0-75c796bd644b@adacore.com> <20230404-dap-loaded-sources-v1-8-75c796bd644b@adacore.com> <83bkk3tqh3.fsf@gnu.org> <87h6s9zfnt.fsf@tromey.com> <83a5y1v6d1.fsf@gnu.org> <87a5y1z99o.fsf@tromey.com> X-Attribution: Tom Date: Fri, 19 May 2023 09:57:06 -0600 In-Reply-To: (Matt Rice's message of "Thu, 18 May 2023 20:34:21 +0000") Message-ID: <875y8oz54d.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Status: No, score=-5.2 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Matt> I don't have much preference either way, but it brought to mind that Matt> there are issues with kwargs, Matt> with dict keys containing hyphens. If this were a problem though, it Matt> would also apply to other hyphenated Matt> command names, like 'break-insert' regardless of the initial hyphen. Matt> I suppose that people trying to map mi commands to kwargs Matt> would perhaps just have to mangle mi commands... Yeah. I don't think this is a huge issue, and I do agree with Eli that the "-" will cause less confusion when going from the MI docs to writing code. Also it seems to me that the most likely mapping would be the other way -- like, trying to implement "gdb.mi.command" as a function that wraps the MI "-command". Here you'd want to change Python style to MI style. I did consider doing this but it seemed fine to keep it simple. Tom